You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
gitea/routers/web
Jason Song 1e76a824bc
Refactor and enhance issue indexer to support both searching, filtering and paging (#26012)
Fix #24662.

Replace #24822 and #25708 (although it has been merged)


## Background

In the past, Gitea supported issue searching with a keyword and
conditions in a less efficient way. It worked by searching for issues
with the keyword and obtaining limited IDs (as it is heavy to get all)
on the indexer (bleve/elasticsearch/meilisearch), and then querying with
conditions on the database to find a subset of the found IDs. This is
why the results could be incomplete.

To solve this issue, we need to store all fields that could be used as
conditions in the indexer and support both keyword and additional
conditions when searching with the indexer.

## Major changes

- Redefine `IndexerData` to include all fields that could be used as
filter conditions.
- Refactor `Search(ctx context.Context, kw string, repoIDs []int64,
limit, start int, state string)` to `Search(ctx context.Context, options
*SearchOptions)`, so it supports more conditions now.
- Change the data type stored in `issueIndexerQueue`. Use
`IndexerMetadata` instead of `IndexerData` in case the data has been
updated while it is in the queue. This also reduces the storage size of
the queue.
- Enhance searching with Bleve/Elasticsearch/Meilisearch, make them
fully support `SearchOptions`. Also, update the data versions.
- Keep most logic of database indexer, but remove
`issues.SearchIssueIDsByKeyword` in `models` to avoid confusion where is
the entry point to search issues.
- Start a Meilisearch instance to test it in unit tests.
- Add unit tests with almost full coverage to test
Bleve/Elasticsearch/Meilisearch indexer.

---------

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2 years ago
..
admin Move web JSON functions to web context and simplify code (#26132) 2 years ago
auth Move web JSON functions to web context and simplify code (#26132) 2 years ago
devtest Make "cancel" buttons have proper type in modal forms (#25618) 2 years ago
events Implement FSFE REUSE for golang files (#21840) 2 years ago
explore Replace `interface{}` with `any` (#25686) 2 years ago
feed Add context parameter to some database functions (#26055) 2 years ago
healthcheck Remove `db.DefaultContext` in `routers/` and `cmd/` (#26076) 2 years ago
misc Serve pre-defined files in "public", add "security.txt", add CORS header for ".well-known" (#25974) 2 years ago
org Move web JSON functions to web context and simplify code (#26132) 2 years ago
repo Refactor and enhance issue indexer to support both searching, filtering and paging (#26012) 2 years ago
shared Move web JSON functions to web context and simplify code (#26132) 2 years ago
user Refactor and enhance issue indexer to support both searching, filtering and paging (#26012) 2 years ago
auth.go Implement FSFE REUSE for golang files (#21840) 2 years ago
auth_windows.go Implement FSFE REUSE for golang files (#21840) 2 years ago
base.go Fix all possible setting error related storages and added some tests (#23911) 2 years ago
goget.go Support SSH for go get (#24664) 2 years ago
home.go Refactor cookie (#24107) 2 years ago
metrics.go Implement FSFE REUSE for golang files (#21840) 2 years ago
nodeinfo.go Implement FSFE REUSE for golang files (#21840) 2 years ago
swagger_json.go Group template helper functions, remove `Printf`, improve template error messages (#23982) 2 years ago
web.go Fix access check for org-level project (#26182) 2 years ago
webfinger.go Add a link to OpenID Issuer URL in WebFinger response (#26000) 2 years ago