mirror of https://github.com/go-gitea/gitea.git
You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
18de83b2a3
## Changes
- Adds the following high level access scopes, each with `read` and
`write` levels:
- `activitypub`
- `admin` (hidden if user is not a site admin)
- `misc`
- `notification`
- `organization`
- `package`
- `issue`
- `repository`
- `user`
- Adds new middleware function `tokenRequiresScopes()` in addition to
`reqToken()`
- `tokenRequiresScopes()` is used for each high-level api section
- _if_ a scoped token is present, checks that the required scope is
included based on the section and HTTP method
- `reqToken()` is used for individual routes
- checks that required authentication is present (but does not check
scope levels as this will already have been handled by
`tokenRequiresScopes()`
- Adds migration to convert old scoped access tokens to the new set of
scopes
- Updates the user interface for scope selection
### User interface example
<img width="903" alt="Screen Shot 2023-05-31 at 1 56 55 PM"
src="https://github.com/go-gitea/gitea/assets/23248839/654766ec-2143-4f59-9037-3b51600e32f3">
<img width="917" alt="Screen Shot 2023-05-31 at 1 56 43 PM"
src="https://github.com/go-gitea/gitea/assets/23248839/1ad64081-012c-4a73-b393-66b30352654c">
## tokenRequiresScopes Design Decision
- `tokenRequiresScopes()` was added to more reliably cover api routes.
For an incoming request, this function uses the given scope category
(say `AccessTokenScopeCategoryOrganization`) and the HTTP method (say
`DELETE`) and verifies that any scoped tokens in use include
`delete:organization`.
- `reqToken()` is used to enforce auth for individual routes that
require it. If a scoped token is not present for a request,
`tokenRequiresScopes()` will not return an error
## TODO
- [x] Alphabetize scope categories
- [x] Change 'public repos only' to a radio button (private vs public).
Also expand this to organizations
- [X] Disable token creation if no scopes selected. Alternatively, show
warning
- [x] `reqToken()` is missing from many `POST/DELETE` routes in the api.
`tokenRequiresScopes()` only checks that a given token has the correct
scope, `reqToken()` must be used to check that a token (or some other
auth) is present.
- _This should be addressed in this PR_
- [x] The migration should be reviewed very carefully in order to
minimize access changes to existing user tokens.
- _This should be addressed in this PR_
- [x] Link to api to swagger documentation, clarify what
read/write/delete levels correspond to
- [x] Review cases where more than one scope is needed as this directly
deviates from the api definition.
- _This should be addressed in this PR_
- For example:
```go
m.Group("/users/{username}/orgs", func() {
m.Get("", reqToken(), org.ListUserOrgs)
m.Get("/{org}/permissions", reqToken(), org.GetUserOrgsPermissions)
}, tokenRequiresScopes(auth_model.AccessTokenScopeCategoryUser,
auth_model.AccessTokenScopeCategoryOrganization),
context_service.UserAssignmentAPI())
```
## Future improvements
- [ ] Add required scopes to swagger documentation
- [ ] Redesign `reqToken()` to be opt-out rather than opt-in
- [ ] Subdivide scopes like `repository`
- [ ] Once a token is created, if it has no scopes, we should display
text instead of an empty bullet point
- [ ] If the 'public repos only' option is selected, should read
categories be selected by default
Closes #24501
Closes #24799
Co-authored-by: Jonathan Tran <jon@allspice.io>
Co-authored-by: Kyle D <kdumontnu@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
|
2 years ago | |
|---|---|---|
| .. | ||
| actions | 2 years ago | |
| setting | 2 years ago | |
| activity.go | 2 years ago | |
| attachment.go | 2 years ago | |
| blame.go | 2 years ago | |
| branch.go | 2 years ago | |
| cherry_pick.go | 2 years ago | |
| commit.go | 2 years ago | |
| compare.go | 2 years ago | |
| download.go | 2 years ago | |
| editor.go | 2 years ago | |
| editor_test.go | 2 years ago | |
| find.go | 2 years ago | |
| helper.go | 2 years ago | |
| helper_test.go | 2 years ago | |
| http.go | 2 years ago | |
| http_test.go | 2 years ago | |
| issue.go | 2 years ago | |
| issue_content_history.go | 2 years ago | |
| issue_dependency.go | 2 years ago | |
| issue_label.go | 2 years ago | |
| issue_label_test.go | 2 years ago | |
| issue_lock.go | 2 years ago | |
| issue_pin.go | 2 years ago | |
| issue_stopwatch.go | 2 years ago | |
| issue_test.go | 2 years ago | |
| issue_timetrack.go | 2 years ago | |
| issue_watch.go | 2 years ago | |
| lfs.go | 2 years ago | |
| main_test.go | 2 years ago | |
| middlewares.go | 2 years ago | |
| migrate.go | 2 years ago | |
| milestone.go | 2 years ago | |
| packages.go | 2 years ago | |
| patch.go | 2 years ago | |
| projects.go | 2 years ago | |
| projects_test.go | 2 years ago | |
| pull.go | 2 years ago | |
| pull_review.go | 2 years ago | |
| release.go | 2 years ago | |
| release_test.go | 2 years ago | |
| render.go | 2 years ago | |
| repo.go | 2 years ago | |
| search.go | 2 years ago | |
| setting.go | 2 years ago | |
| setting_protected_branch.go | 2 years ago | |
| settings_test.go | 2 years ago | |
| tag.go | 2 years ago | |
| topic.go | 2 years ago | |
| treelist.go | 2 years ago | |
| view.go | 2 years ago | |
| view_test.go | 2 years ago | |
| webhook.go | 2 years ago | |
| wiki.go | 2 years ago | |
| wiki_test.go | 2 years ago | |