You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
gitea/services/convert
Henry Goodman 12cb1d2998
Allow force push to protected branches (#28086)
Fixes #22722 

### Problem
Currently, it is not possible to force push to a branch with branch
protection rules in place. There are often times where this is necessary
(CI workflows/administrative tasks etc).

The current workaround is to rename/remove the branch protection,
perform the force push, and then reinstate the protections.

### Solution
Provide an additional section in the branch protection rules to allow
users to specify which users with push access can also force push to the
branch. The default value of the rule will be set to `Disabled`, and the
UI is intuitive and very similar to the `Push` section.

It is worth noting in this implementation that allowing force push does
not override regular push access, and both will need to be enabled for a
user to force push.

This applies to manual force push to a remote, and also in Gitea UI
updating a PR by rebase (which requires force push)

This modifies the `BranchProtection` API structs to add:
- `enable_force_push bool`
- `enable_force_push_whitelist bool`
- `force_push_whitelist_usernames string[]`
- `force_push_whitelist_teams string[]`
- `force_push_whitelist_deploy_keys bool`

### Updated Branch Protection UI:

<img width="943" alt="image"
src="https://github.com/go-gitea/gitea/assets/79623665/7491899c-d816-45d5-be84-8512abd156bf">

### Pull Request `Update branch by Rebase` option enabled with source
branch `test` being a protected branch:


![image](https://github.com/go-gitea/gitea/assets/79623665/e018e6e9-b7b2-4bd3-808e-4947d7da35cc)
<img width="1038" alt="image"
src="https://github.com/go-gitea/gitea/assets/79623665/57ead13e-9006-459f-b83c-7079e6f4c654">

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
8 months ago
..
activity.go For API attachments, use API URL (#25639) 2 years ago
attachment.go Fix attachment download bug (#27486) 1 year ago
convert.go Allow force push to protected branches (#28086) 8 months ago
git_commit.go Move context from modules to services (#29440) 1 year ago
git_commit_test.go Adjust object format interface (#28469) 1 year ago
issue.go Performance improvements for pull request list API (#30490) 9 months ago
issue_comment.go Update misspell to 0.5.1 and add `misspellings.csv` (#30573) 10 months ago
issue_test.go Move `convert` package to services (#22264) 2 years ago
main_test.go make writing main test easier (#27270) 1 year ago
mirror.go Even more `db.DefaultContext` refactor (#27352) 1 year ago
notification.go Performance improvements for pull request list page (#29900) 11 months ago
package.go Clarify permission "HasAccess" behavior (#30585) 10 months ago
pull.go Performance improvements for pull request list API (#30490) 9 months ago
pull_review.go Fix possible NPE in ToPullReviewList (#29759) 12 months ago
pull_review_test.go Fix possible NPE in ToPullReviewList (#29759) 12 months ago
pull_test.go Fix `Permission` in API returned repository struct (#25388) 2 years ago
release.go add Upload URL to release API (#26663) 2 years ago
release_test.go add Upload URL to release API (#26663) 2 years ago
repository.go Add topics for repository API (#31127) 9 months ago
secret.go feat: implement organization secret creation API (#26566) 2 years ago
status.go refactor improve NoBetterThan (#26126) 2 years ago
user.go Make gitea webhooks openproject compatible (#28435) 9 months ago
user_test.go Add context cache as a request level cache (#22294) 2 years ago
utils.go Move `convert` package to services (#22264) 2 years ago
utils_test.go Rewrite queue (#24505) 2 years ago
wiki.go Fix an actions schedule bug (#28942) 1 year ago