You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
gitea/models
yp05327 daf2a4c047
Fix wrong display of recently pushed notification (#25812)
There's a bug in #25715: 
If user pushed a commit into another repo with same branch name, the
no-related repo will display the recently pushed notification
incorrectly.
It is simple to fix this, we should match the repo id in the sql query.


![image](https://github.com/go-gitea/gitea/assets/18380374/9411a926-16f1-419e-a1b5-e953af38bab1)
The latest commit is 2 weeks ago.

![image](https://github.com/go-gitea/gitea/assets/18380374/52f9ab22-4999-43ac-a86f-6d36fb1e0411)

The notification comes from another repo with same branch name:

![image](https://github.com/go-gitea/gitea/assets/18380374/a26bc335-8e5b-4b9c-a965-c3dc3fa6f252)


After:
In forked repo:

![image](https://github.com/go-gitea/gitea/assets/18380374/ce6ffc35-deb7-4be7-8b09-184207392f32)
New PR Link will redirect to the original repo:

![image](https://github.com/go-gitea/gitea/assets/18380374/7b98e76f-0c75-494c-9462-80cf9f98e786)
In the original repo:

![image](https://github.com/go-gitea/gitea/assets/18380374/5f6a821b-e51a-4bbd-9980-d9eb94a3c847)
New PR Link:

![image](https://github.com/go-gitea/gitea/assets/18380374/1ce8c879-9f11-4312-8c32-695d7d9af0df)

In the same repo:

![image](https://github.com/go-gitea/gitea/assets/18380374/64b56073-4d0e-40c4-b8a0-80be7a775f69)
New PR Link:

![image](https://github.com/go-gitea/gitea/assets/18380374/96e1b6a3-fb98-40ee-b2ee-648039fb0dcf)

08/15 Update:
Follow #26257, added permission check and logic fix mentioned in
https://github.com/go-gitea/gitea/pull/26257#discussion_r1294085203


2024/04/25 Update:
Fix #30611

---------

Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
9 months ago
..
actions Update misspell to 0.5.1 and add `misspellings.csv` (#30573) 10 months ago
activities Filter out duplicate action(activity) items for a repository (#30957) 9 months ago
admin Next round of `db.DefaultContext` refactor (#27089) 1 year ago
asymkey Enable more `revive` linter rules (#30608) 10 months ago
auth Fix wrong table name (#30557) 10 months ago
avatars Replace 10 more gt- classes with tw- (#29945) 11 months ago
db Fix various problems around projects board view (#30696) 9 months ago
dbfs make writing main test easier (#27270) 1 year ago
fixtures Fix wrong display of recently pushed notification (#25812) 9 months ago
git Fix wrong display of recently pushed notification (#25812) 9 months ago
issues Fix automerge will not work because of some events haven't been triggered (#30780) 9 months ago
migrations Remove If Exist check on migration for mssql because that syntax required SQL server 2016 (#30894) 9 months ago
organization Fix wrong display of recently pushed notification (#25812) 9 months ago
packages Fix package list performance (#30520) 10 months ago
perm Clarify permission "HasAccess" behavior (#30585) 10 months ago
project Fix various problems around projects board view (#30696) 9 months ago
pull Add support for sha256 repositories (#23894) 1 year ago
repo Fix wrong display of recently pushed notification (#25812) 9 months ago
secret Make runs-on support variable expression (#29468) 11 months ago
shared/types Refactor locale&string&template related code (#29165) 12 months ago
system Refactor deletion (#28610) 1 year ago
unit Fix data-race during testing (#30999) 9 months ago
unittest Add some tests to clarify the "must-change-password" behavior (#30693) 10 months ago
user Refactor sha1 and time-limited code (#31023) 9 months ago
webhook Store webhook event in database (#29145) 11 months ago
error.go Add merge style `fast-forward-only` (#28954) 1 year ago
fixture_generation.go Replace more db.DefaultContext (#27628) 1 year ago
fixture_test.go Replace more db.DefaultContext (#27628) 1 year ago
main_test.go make writing main test easier (#27270) 1 year ago
org.go Add user blocking (#29028) 11 months ago
org_team.go Clarify permission "HasAccess" behavior (#30585) 10 months ago
org_team_test.go Add user blocking (#29028) 11 months ago
org_test.go Add user blocking (#29028) 11 months ago
repo.go Refactor deletion (#28610) 1 year ago
repo_test.go Penultimate round of `db.DefaultContext` refactor (#27414) 1 year ago
repo_transfer.go chore: use errors.New to replace fmt.Errorf with no parameters will much better (#30621) 10 months ago