You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Nanguan Lin d95102d650 Fix wrong xorm Delete usage (#27995) ... ## Bug in Gitea I ran into this bug when I accidentally used the wrong redirect URL for the oauth2 provider when using mssql. But the oauth2 provider still got added. Most of the time, we use `Delete(&some{id: some.id})` or `In(condition).Delete(&some{})`, which specify the conditions. But the function uses `Delete(source)` when `source.Cfg` is a `TEXT` field and not empty. This will cause xorm `Delete` function not working in mssql. 61ff91f960/models/auth/source.go (L234-L240) ## Reason Because the `TEXT` field can not be compared in mssql, xorm doesn't support it according to [this PR](https://gitea.com/xorm/xorm/pulls/2062) [related code](b23798dc98/internal/statements/statement.go (L552-L558)) in xorm ```go if statement.dialect.URI().DBType == schemas.MSSQL && (col.SQLType.Name == schemas.Text ||   col.SQLType.IsBlob() || col.SQLType.Name == schemas.TimeStampz) {   if utils.IsValueZero(fieldValue) {   continue   }   return nil, fmt.Errorf("column %s is a TEXT type with data %#v which cannot be as compare condition", col.Name, fieldValue.Interface())   } } ``` When using the `Delete` function in xorm, the non-empty fields will auto-set as conditions(perhaps some special fields are not?). If `TEXT` field is not empty, xorm will return an error. I only found this usage after searching, but maybe there is something I missing. --------- Co-authored-by: delvh <dev.lh@web.de>		1 year ago
..
access_token.go	Enhanced auth token / remember me (#27606)	1 year ago
access_token_scope.go	Enhanced auth token / remember me (#27606)	1 year ago
access_token_scope_test.go	Enhanced auth token / remember me (#27606)	1 year ago
access_token_test.go	Enhanced auth token / remember me (#27606)	1 year ago
auth_token.go	Enhanced auth token / remember me (#27606)	1 year ago
main_test.go	make writing main test easier (#27270)	1 year ago
oauth2.go	Refactor Find Sources and fix bug when view a user who belongs to an unactive auth source (#27798)	1 year ago
oauth2_test.go	Final round of `db.DefaultContext` refactor (#27587)	1 year ago
session.go	Next round of `db.DefaultContext` refactor (#27089)	1 year ago
source.go	Fix wrong xorm Delete usage (#27995)	1 year ago
source_test.go	Penultimate round of `db.DefaultContext` refactor (#27414)	1 year ago
twofactor.go	More refactoring of `db.DefaultContext` (#27083)	1 year ago
webauthn.go	Next round of `db.DefaultContext` refactor (#27089)	1 year ago
webauthn_test.go	Next round of `db.DefaultContext` refactor (#27089)	1 year ago