mirror of https://github.com/go-gitea/gitea.git
You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
9607750b5e
`hex.EncodeToString` has better performance than `fmt.Sprintf("%x",
[]byte)`, we should use it as much as possible.
I'm not an extreme fan of performance, so I think there are some
exceptions:
- `fmt.Sprintf("%x", func(...)[N]byte())`
- We can't slice the function return value directly, and it's not worth
adding lines.
```diff
func A()[20]byte { ... }
- a := fmt.Sprintf("%x", A())
- a := hex.EncodeToString(A()[:]) // invalid
+ tmp := A()
+ a := hex.EncodeToString(tmp[:])
```
- `fmt.Sprintf("%X", []byte)`
- `strings.ToUpper(hex.EncodeToString(bytes))` has even worse
performance.
|
2 years ago | |
|---|---|---|
| .. | ||
| avatar.go | 2 years ago | |
| badge.go | 2 years ago | |
| email_address.go | 2 years ago | |
| email_address_test.go | 2 years ago | |
| error.go | 2 years ago | |
| external_login_user.go | 2 years ago | |
| follow.go | 2 years ago | |
| follow_test.go | 2 years ago | |
| list.go | 2 years ago | |
| main_test.go | 2 years ago | |
| openid.go | 2 years ago | |
| openid_test.go | 2 years ago | |
| redirect.go | 2 years ago | |
| redirect_test.go | 2 years ago | |
| search.go | 2 years ago | |
| setting.go | 2 years ago | |
| setting_keys.go | 2 years ago | |
| setting_test.go | 2 years ago | |
| user.go | 2 years ago | |
| user_test.go | 2 years ago | |
| user_update.go | 2 years ago | |