github-forks
/
gitea
mirror of https://github.com/go-gitea/gitea.git
1
0
Fork 0
Code Projects Releases Activity
gitea/services/pull
History
wxiaoguang 542cec98f8
Refactor merge/update git command calls () 
Follow 

* Remove unnecessary ToTrustedCmdArgs calls 
    * the FAQ in  
* Quote: When using ToTrustedCmdArgs, the code will be very complex (see
the changes for examples). Then developers and reviewers can know that
something might be unreasonable.
* The `signArg` couldn't be empty, it's either `-S{keyID}` or
`--no-gpg-sign`.
* Use `signKeyID` instead, add comment "empty for no-sign, non-empty to
sign"
* 5-line code could be extracted to a common `NewGitCommandCommit()` to
handle the `signKeyID`, but I think it's not a must, current code is
clear enough.
..
check.go Add force_merge to merge request and fix checking mergable ()
check_test.go Implement FSFE REUSE for golang files ()
comment.go Rename almost all Ctx functions ()
commit_status.go Supports wildcard protected branch ()
edits.go Implement FSFE REUSE for golang files ()
lfs.go Refactor and tidy-up the merge/update branch code ()
main_test.go Implement FSFE REUSE for golang files ()
merge.go Refactor merge/update git command calls ()
merge_merge.go Refactor and tidy-up the merge/update branch code ()
merge_prepare.go Refactor merge/update git command calls ()
merge_rebase.go Refactor and tidy-up the merge/update branch code ()
merge_squash.go Refactor merge/update git command calls ()
merge_test.go Support template for merge message description ()
patch.go Refactor and tidy-up the merge/update branch code ()
patch_unmerged.go Implement FSFE REUSE for golang files ()
pull.go Refactor and tidy-up the merge/update branch code ()
pull_test.go Support template for merge message description ()
review.go Make Ctrl+Enter submit a pending comment (starting review) instead of submitting a single comment ()
temp_repo.go Refactor and tidy-up the merge/update branch code ()
update.go Refactor and tidy-up the merge/update branch code ()
update_rebase.go Refactor and tidy-up the merge/update branch code ()