github-forks
/
gitea
mirror of https://github.com/go-gitea/gitea.git
1
0
Fork 0
Code Projects Releases Activity
gitea/modules/git
History
Kirill Bolashev 4938945668
Handle files starting with colons in WalkGitLog () 
Currently gitea shows no commit information for files starting with a
colon.

[I set up a minimal repro repository that reproduces this error once
it's migrated on gitea](https://github.com/kbolashev/colon-test)

<img width="1209" alt="image"
src="https://user-images.githubusercontent.com/111061261/219326625-0e6d3a86-8b58-4d67-bc24-8a78963f36b9.png">

This is happening because the filenames piped to the `git log` command
are written as is, and it doesn't work when you have a colon at the
start of the filename, and you need to escape it.


You can test it locally,  if you do
```
mkdir repo
git init
touch :file 
git add . && git commit -m "Add file with colon"
git log -- :file 
```
git log returns nothing. However, if you do `git log -- "\:file"`, it
will show the commit with the file change.

This PR escapes the starting colons in paths in the `LogNameStatusRepo`
function, making gitea return commit info about the file with the bad
filename.

<img width="1209" alt="image"
src="https://user-images.githubusercontent.com/111061261/219328299-46451246-4006-45e3-89b1-c244635ded23.png">

This error shows up only with files starting with colon, anywhere else
in filename is ok. Dashes at the beginning also seem to be working.
I don't know gitea internals well enough to know where else this error
can pop up, so I'm keeping this PR small as suggested by your
contributor guide
..
foreachref Implement FSFE REUSE for golang files ()
internal Refactor git command package to improve security and maintainability ()
pipeline Refactor and tidy-up the merge/update branch code ()
tests/repos Fix commit retrieval by tag ()
url Implement FSFE REUSE for golang files ()
README.md move code.gitea.io/git to code.gitea.io/gitea/modules/git ()
batch_reader.go Implement FSFE REUSE for golang files ()
blame.go Fix blame view missing lines ()
blame_test.go Fix blame view missing lines ()
blob.go Implement FSFE REUSE for golang files ()
blob_gogit.go Implement FSFE REUSE for golang files ()
blob_nogogit.go Implement FSFE REUSE for golang files ()
blob_test.go Implement FSFE REUSE for golang files ()
command.go Refactor merge/update git command calls ()
command_race_test.go Implement FSFE REUSE for golang files ()
command_test.go Refactor git command package to improve security and maintainability ()
commit.go Fix pull request update showing too many commits with multiple branches ()
commit_convert_gogit.go Implement FSFE REUSE for golang files ()
commit_info.go Implement FSFE REUSE for golang files ()
commit_info_gogit.go Implement FSFE REUSE for golang files ()
commit_info_nogogit.go Implement FSFE REUSE for golang files ()
commit_info_test.go Implement FSFE REUSE for golang files ()
commit_reader.go Implement FSFE REUSE for golang files ()
commit_test.go Implement FSFE REUSE for golang files ()
diff.go Implement FSFE REUSE for golang files ()
diff_test.go Implement FSFE REUSE for golang files ()
error.go Implement FSFE REUSE for golang files ()
git.go Support reflogs ()
git_test.go Implement FSFE REUSE for golang files ()
hook.go Implement FSFE REUSE for golang files ()
last_commit_cache.go Use minio/sha256-simd for accelerated SHA256 ()
last_commit_cache_gogit.go Implement FSFE REUSE for golang files ()
last_commit_cache_nogogit.go Implement FSFE REUSE for golang files ()
log_name_status.go Handle files starting with colons in WalkGitLog ()
notes.go Implement FSFE REUSE for golang files ()
notes_gogit.go Implement FSFE REUSE for golang files ()
notes_nogogit.go Implement FSFE REUSE for golang files ()
notes_test.go Implement FSFE REUSE for golang files ()
parse_gogit.go Implement FSFE REUSE for golang files ()
parse_gogit_test.go Implement FSFE REUSE for golang files ()
parse_nogogit.go Implement FSFE REUSE for golang files ()
parse_nogogit_test.go Implement FSFE REUSE for golang files ()
ref.go Util type to parse ref name ()
remote.go Implement FSFE REUSE for golang files ()
repo.go Use proxy for pull mirror ()
repo_archive.go Refactor git command package to improve security and maintainability ()
repo_attribute.go Refactor legacy strange git operations ()
repo_attribute_test.go Remove deadcode ()
repo_base.go Implement FSFE REUSE for golang files ()
repo_base_gogit.go Implement FSFE REUSE for golang files ()
repo_base_nogogit.go Implement FSFE REUSE for golang files ()
repo_blame.go Refactor git command package to improve security and maintainability ()
repo_blob.go Implement FSFE REUSE for golang files ()
repo_blob_gogit.go Implement FSFE REUSE for golang files ()
repo_blob_nogogit.go Implement FSFE REUSE for golang files ()
repo_blob_test.go Implement FSFE REUSE for golang files ()
repo_branch.go Implement FSFE REUSE for golang files ()
repo_branch_gogit.go Refactor git command package to improve security and maintainability ()
repo_branch_nogogit.go Refactor git command package to improve security and maintainability ()
repo_branch_test.go Implement FSFE REUSE for golang files ()
repo_commit.go Fix pull request update showing too many commits with multiple branches ()
repo_commit_gogit.go Fix commit retrieval by tag ()
repo_commit_nogogit.go Fix commit retrieval by tag ()
repo_commit_test.go Fix commit retrieval by tag ()
repo_commitgraph.go Implement FSFE REUSE for golang files ()
repo_commitgraph_gogit.go Implement FSFE REUSE for golang files ()
repo_compare.go Fix GetFilesChangedBetween if the file name may be escaped ()
repo_compare_test.go Implement FSFE REUSE for golang files ()
repo_gpg.go Implement FSFE REUSE for golang files ()
repo_hook.go Implement FSFE REUSE for golang files ()
repo_index.go Use complete SHA to create and query commit status ()
repo_language_stats.go Implement FSFE REUSE for golang files ()
repo_language_stats_gogit.go Implement FSFE REUSE for golang files ()
repo_language_stats_nogogit.go Implement FSFE REUSE for golang files ()
repo_language_stats_test.go Implement FSFE REUSE for golang files ()
repo_object.go Implement FSFE REUSE for golang files ()
repo_ref.go Implement FSFE REUSE for golang files ()
repo_ref_gogit.go Implement FSFE REUSE for golang files ()
repo_ref_nogogit.go Implement FSFE REUSE for golang files ()
repo_ref_test.go Fix commit retrieval by tag ()
repo_stats.go Refactor git command package to improve security and maintainability ()
repo_stats_test.go Fix commit retrieval by tag ()
repo_tag.go Refactor git command package to improve security and maintainability ()
repo_tag_gogit.go Implement FSFE REUSE for golang files ()
repo_tag_nogogit.go Refactor git command package to improve security and maintainability ()
repo_tag_test.go Fix commit retrieval by tag ()
repo_test.go Fix commit retrieval by tag ()
repo_tree.go Refactor git command package to improve security and maintainability ()
repo_tree_gogit.go Use complete SHA to create and query commit status ()
repo_tree_nogogit.go Use complete SHA to create and query commit status ()
sha1.go Use complete SHA to create and query commit status ()
sha1_gogit.go Implement FSFE REUSE for golang files ()
sha1_nogogit.go Implement FSFE REUSE for golang files ()
sha1_test.go Implement FSFE REUSE for golang files ()
signature.go Implement FSFE REUSE for golang files ()
signature_gogit.go Implement FSFE REUSE for golang files ()
signature_nogogit.go Implement FSFE REUSE for golang files ()
submodule.go Implement FSFE REUSE for golang files ()
submodule_test.go Implement FSFE REUSE for golang files ()
tag.go Implement FSFE REUSE for golang files ()
tag_test.go Implement FSFE REUSE for golang files ()
tree.go Implement FSFE REUSE for golang files ()
tree_blob.go Implement FSFE REUSE for golang files ()
tree_blob_gogit.go Implement FSFE REUSE for golang files ()
tree_blob_nogogit.go Implement FSFE REUSE for golang files ()
tree_entry.go Remember to attach the parent tree when converting TreeEntry() -> Tree() ()
tree_entry_gogit.go Implement FSFE REUSE for golang files ()
tree_entry_mode.go Implement FSFE REUSE for golang files ()
tree_entry_nogogit.go Implement FSFE REUSE for golang files ()
tree_entry_test.go Implement FSFE REUSE for golang files ()
tree_gogit.go Implement FSFE REUSE for golang files ()
tree_nogogit.go Refactor git command package to improve security and maintainability ()
utils.go Implement FSFE REUSE for golang files ()
utils_test.go Implement FSFE REUSE for golang files ()

README.md

Git Module

This module is merged from https://github.com/go-gitea/git which is a Go module to access Git through shell commands. Now it's a part of gitea's main repository for easier pull request.