You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Giteabot b369ed579d Fix Actions being enabled accidentally (#24802) (#24810) ... Backport #24802 by @wolfogre Regression of #24536. If the user doesn't explicitly disable Actions, it will be enabled. 1. Gitea will call `loadRepositoryFrom` before `loadActionsFrom`. 25d4f95df2/modules/setting/setting.go (L234-L237) 2. In `loadRepositoryFrom`, `rootCfg.Section("actions").Key("ENABLED").MustBool(true)` will set `actions.ENABLED` with `true`. 25d4f95df2/modules/setting/repository.go (L313-L315) 3. In `loadActionsFrom`, `rootCfg.Section("actions")` will get a section with Actions enabled. 25d4f95df2/modules/setting/actions.go (L23-L26) Although the cause of the problem was using `true` by copy-paste mistake, it also surprised me that **`rootCfg.Section("actions").Key("ENABLED").MustBool(true)` doesn't only read, but also write.** Co-authored-by: Jason Song <i@wolfogre.com>		2 years ago
..
actions.go	Refactor the setting to make unit test easier (#22405)	2 years ago
admin.go	Refactor the setting to make unit test easier (#22405)	2 years ago
api.go	Refactor the setting to make unit test easier (#22405)	2 years ago
attachment.go	Add `.patch` to `attachment.ALLOWED_TYPES` (#23580) (#23582)	2 years ago
cache.go	Refactor the setting to make unit test easier (#22405)	2 years ago
camo.go	Refactor the setting to make unit test easier (#22405)	2 years ago
config_provider.go	handle deprecated settings (#22992)	2 years ago
cors.go	Fix incorrect CORS default values (#24206) (#24217)	2 years ago
cron.go	Refactor the setting to make unit test easier (#22405)	2 years ago
cron_test.go	Refactor the setting to make unit test easier (#22405)	2 years ago
database.go	Refactor `setting.Database.UseXXX` to methods (#23354) (#23356)	2 years ago
database_sqlite.go	Implement FSFE REUSE for golang files (#21840)	2 years ago
database_test.go	Implement FSFE REUSE for golang files (#21840)	2 years ago
federation.go	Refactor the setting to make unit test easier (#22405)	2 years ago
git.go	Support reflogs (#22451) (#23438)	2 years ago
highlight.go	Refactor the setting to make unit test easier (#22405)	2 years ago
i18n.go	Refactor the setting to make unit test easier (#22405)	2 years ago
incoming_email.go	Refactor the setting to make unit test easier (#22405)	2 years ago
indexer.go	handle deprecated settings (#22992)	2 years ago
indexer_test.go	Implement FSFE REUSE for golang files (#21840)	2 years ago
lfs.go	handle deprecated settings (#22992)	2 years ago
log.go	Refactor the setting to make unit test easier (#22405)	2 years ago
mailer.go	Make mailer SMTP check have timed context (#24751) (#24759)	2 years ago
mailer_test.go	Refactor the setting to make unit test easier (#22405)	2 years ago
markup.go	Refactor the setting to make unit test easier (#22405)	2 years ago
metrics.go	Refactor the setting to make unit test easier (#22405)	2 years ago
migrations.go	Refactor the setting to make unit test easier (#22405)	2 years ago
mime_type_map.go	Refactor the setting to make unit test easier (#22405)	2 years ago
mirror.go	handle deprecated settings (#22992)	2 years ago
oauth2.go	Refactor the setting to make unit test easier (#22405)	2 years ago
other.go	Refactor the setting to make unit test easier (#22405)	2 years ago
packages.go	Refactor the setting to make unit test easier (#22405)	2 years ago
packages_test.go	Implement FSFE REUSE for golang files (#21840)	2 years ago
picture.go	Refactor the setting to make unit test easier (#22405)	2 years ago
project.go	Refactor the setting to make unit test easier (#22405)	2 years ago
proxy.go	Refactor the setting to make unit test easier (#22405)	2 years ago
queue.go	Refactor the setting to make unit test easier (#22405)	2 years ago
repository.go	Fix Actions being enabled accidentally (#24802) (#24810)	2 years ago
security.go	Refactor the setting to make unit test easier (#22405)	2 years ago
server.go	handle deprecated settings (#22992)	2 years ago
service.go	Refactor the setting to make unit test easier (#22405)	2 years ago
session.go	Refactor the setting to make unit test easier (#22405)	2 years ago
setting.go	Fix incorrect CurrentUser check for docker rootless (#24435)	2 years ago
setting_test.go	Implement FSFE REUSE for golang files (#21840)	2 years ago
ssh.go	Refactor the setting to make unit test easier (#22405)	2 years ago
storage.go	Make minio package support legacy MD5 checksum (#23768) (#23770)	2 years ago
storage_test.go	Refactor the setting to make unit test easier (#22405)	2 years ago
task.go	handle deprecated settings (#22992)	2 years ago
time.go	Refactor the setting to make unit test easier (#22405)	2 years ago
ui.go	Don't set meta `theme-color` by default (#24340) (#24346)	2 years ago
webhook.go	Refactor the setting to make unit test easier (#22405)	2 years ago