mirror of https://github.com/go-gitea/gitea.git
You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
One of the proposals in #23328 This PR introduces a simple expression calculator (templates/eval/eval.go), it can do basic expression calculations. Many untested template helper functions like `Mul` `Add` can be replaced by this new approach. Then these `Add` / `Mul` / `percentage` / `Subtract` / `DiffStatsWidth` could all use this `Eval`. And it provides enhancements for Golang templates, and improves readability. Some examples: ---- * Before: `{{Add (Mul $glyph.Row 12) 12}}` * After: `{{Eval $glyph.Row "*" 12 "+" 12}}` ---- * Before: `{{if lt (Add $i 1) (len $.Topics)}}` * After: `{{if Eval $i "+" 1 "<" (len $.Topics)}}` ## FAQ ### Why not use an existing expression package? We need a highly customized expression engine: * do the calculation on the fly, without pre-compiling * deal with int/int64/float64 types, to make the result could be used in Golang template. * make the syntax could be used in the Golang template directly * do not introduce too much complex or strange syntax, we just need a simple calculator. * it needs to strictly follow Golang template's behavior, for example, Golang template treats all non-zero values as truth, but many 3rd packages don't do so. ### What's the benefit? * Developers don't need to add more `Add`/`Mul`/`Sub`-like functions, they were getting more and more. Now, only one `Eval` is enough for all cases. * The new code reads better than old `{{Add (Mul $glyph.Row 12) 12}}`, the old one isn't familiar to most procedural programming developers (eg, the Golang expression syntax). * The `Eval` is fully covered by tests, many old `Add`/`Mul`-like functions were never tested. ### The performance? It doesn't use `reflect`, it doesn't need to parse or compile when used in Golang template, the performance is as fast as native Go template. ### Is it too complex? Could it be unstable? The expression calculator program is a common homework for computer science students, and it's widely used as a teaching and practicing purpose for developers. The algorithm is pretty well-known. The behavior can be clearly defined, it is stable. |
2 years ago | |
---|---|---|
.. | ||
actions | 2 years ago | |
activitypub | 2 years ago | |
analyze | 2 years ago | |
auth | 2 years ago | |
avatar | 2 years ago | |
base | 2 years ago | |
cache | 2 years ago | |
charset | 2 years ago | |
container | 2 years ago | |
context | 2 years ago | |
csv | 2 years ago | |
doctor | 2 years ago | |
emoji | 2 years ago | |
eventsource | 2 years ago | |
generate | 2 years ago | |
git | 2 years ago | |
gitgraph | 2 years ago | |
graceful | 2 years ago | |
hcaptcha | 2 years ago | |
highlight | 2 years ago | |
hostmatcher | 2 years ago | |
html | 2 years ago | |
httpcache | 2 years ago | |
httplib | 2 years ago | |
indexer | 2 years ago | |
issue/template | 2 years ago | |
json | 2 years ago | |
label | 2 years ago | |
lfs | 2 years ago | |
log | 2 years ago | |
markup | 2 years ago | |
mcaptcha | 2 years ago | |
metrics | 2 years ago | |
migration | 2 years ago | |
mirror | 2 years ago | |
nosql | 2 years ago | |
notification | 2 years ago | |
options | 2 years ago | |
packages | 2 years ago | |
paginator | 2 years ago | |
pprof | 2 years ago | |
private | 2 years ago | |
process | 2 years ago | |
proxy | 2 years ago | |
proxyprotocol | 2 years ago | |
public | 2 years ago | |
queue | 2 years ago | |
recaptcha | 2 years ago | |
references | 2 years ago | |
regexplru | 2 years ago | |
repository | 2 years ago | |
secret | 2 years ago | |
session | 2 years ago | |
setting | 2 years ago | |
sitemap | 2 years ago | |
ssh | 2 years ago | |
storage | 2 years ago | |
structs | 2 years ago | |
svg | 2 years ago | |
sync | 2 years ago | |
system | 2 years ago | |
templates | 2 years ago | |
test | 2 years ago | |
timeutil | 2 years ago | |
translation | 2 years ago | |
turnstile | 2 years ago | |
typesniffer | 2 years ago | |
updatechecker | 2 years ago | |
upload | 2 years ago | |
uri | 2 years ago | |
user | 2 years ago | |
util | 2 years ago | |
validation | 2 years ago | |
watcher | 2 years ago | |
web | 2 years ago | |
webhook | 2 years ago |