You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

wxiaoguang 0bc8bb3cc4 Make issue meta dropdown support Enter, confirm before reloading (#23014) ... As the title. Label/assignee share the same code. * Close #22607 * Close #20727 Also: * partially fix for #21742, now the comment reaction and menu work with keyboard. * partially fix for #17705, in most cases the comment won't be lost. * partially fix for #21539 * partially fix for #20347 * partially fix for #7329 ### The `Enter` support Before, if user presses Enter, the dropdown just disappears and nothing happens or the window reloads. After, Enter can be used to select/deselect labels, and press Esc to hide the dropdown to update the labels (still no way to cancel .... maybe you can do a Cmd+R or F5 to refresh the window to discard the changes .....) This is only a quick patch, the UX is still not perfect, but it's much better than before. ### The `confirm` before reloading And more fixes for the `reload` problem, the new behaviors: * If nothing changes (just show/hide the dropdown), then the page won't be reloaded. * If there are draft comments, show a confirm dialog before reloading, to avoid losing comments. That's the best effect can be done at the moment, unless completely refactor these dropdown related code. Screenshot of the confirm dialog: <details>  </details> --------- Co-authored-by: Brecht Van Lommel <brecht@blender.org> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>		2 years ago
..
admin	Fix some more hidden problems (#23074)	2 years ago
comp	Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)	2 years ago
aria.js	Make issue meta dropdown support Enter, confirm before reloading (#23014)	2 years ago
aria.md	Improve frontend guidelines (#23007)	2 years ago
captcha.js	Add new captcha: cloudflare turnstile (#22369)	2 years ago
citation.js	fix webpackChunkName for citation-js-csl (#21806)	2 years ago
clipboard.js	Use link in UI which returned a relative url but not html_url which contains an absolute url (#21986)	2 years ago
codeeditor.js	Quick fixes monaco-editor error: "vs.editor.nullLanguage" (#21734)	2 years ago
colorpicker.js	JS refactors (#22227)	2 years ago
common-global.js	Improve PR Review Box UI (#22986)	2 years ago
common-issue.js	Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)	2 years ago
common-organization.js	Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)	2 years ago
contextpopup.js	JS refactors (#22227)	2 years ago
copycontent.js	JS refactors (#22227)	2 years ago
dropzone.js	JS refactors (#22227)	2 years ago
emoji.js	JS refactors (#22227)	2 years ago
eventsource.sharedworker.js	Fix the JS error "EventSource is not defined" caused by some non-standard browsers (#20584)	3 years ago
file-fold.js	JS refactors (#22227)	2 years ago
formatting.js	JS refactors (#22227)	2 years ago
heatmap.js	JS refactors (#22227)	2 years ago
imagediff.js	Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)	2 years ago
install.js	Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)	2 years ago
notification.js	Move helpers to be prefixed with `gt-` (#22879)	2 years ago
org-team.js	Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)	2 years ago
pull-view-file.js	Replace unstyled meter with progress (#19968)	3 years ago
repo-branch.js	Add apply-patch, basic revert and cherry-pick functionality (#17902)	3 years ago
repo-code.js	Fix links for the menus in the view file page (#22795)	2 years ago
repo-code.test.js	Ignore line anchor links with leading zeroes (#21728)	2 years ago
repo-commit.js	Fix hidden commit status on multiple checks (#22889)	2 years ago
repo-common.js	Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)	2 years ago
repo-diff-filetree.js	JS refactors (#22227)	2 years ago
repo-diff.js	Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)	2 years ago
repo-editor.js	Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)	2 years ago
repo-findfile.js	Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)	2 years ago
repo-findfile.test.js	Escape path for the file list (#22741)	2 years ago
repo-graph.js	Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)	2 years ago
repo-home.js	Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)	2 years ago
repo-issue-content.js	Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)	2 years ago
repo-issue-pr-form.js	JS refactors (#22227)	2 years ago
repo-issue.js	Improve PR Review Box UI (#22986)	2 years ago
repo-legacy.js	Make issue meta dropdown support Enter, confirm before reloading (#23014)	2 years ago
repo-migrate.js	Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)	2 years ago
repo-migration.js	Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)	2 years ago
repo-projects.js	Scoped labels (#22585)	2 years ago
repo-release.js	Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)	2 years ago
repo-settings.js	Remove customized (unmaintained) dropdown, improve aria a11y for dropdown (#19861)	3 years ago
repo-template.js	Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)	2 years ago
repo-unicode-escape.js	Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)	2 years ago
repo-wiki.js	Enable spellcheck for EasyMDE, use contenteditable mode (#19776)	3 years ago
serviceworker.js	JS refactors (#22227)	2 years ago
sshkey-helper.js	Use explicit jQuery import, remove unused eslint globals (#18435)	3 years ago
stopwatch.js	Move helpers to be prefixed with `gt-` (#22879)	2 years ago
tablesort.js	JS refactors (#22227)	2 years ago
tribute.js	JS refactors (#22227)	2 years ago
user-auth-webauthn.js	Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)	2 years ago
user-auth.js	Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)	2 years ago
user-settings.js	Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)	2 years ago