You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
gitea/routers/api/packages
Lunny Xiao 900e158064
refactor auth interface to return error when verify failure (#22119) (#22259)
backport #22119

This PR changed the Auth interface signature from `Verify(http
*http.Request, w http.ResponseWriter, store DataStore, sess
SessionStore) *user_model.User`
to 
`Verify(http *http.Request, w http.ResponseWriter, store DataStore, sess
SessionStore) (*user_model.User, error)`.

There is a new return argument `error` which means the verification
condition matched but verify process failed, we should stop the auth
process.

Before this PR, when return a `nil` user, we don't know the reason why
it returned `nil`. If the match condition is not satisfied or it
verified failure? For these two different results, we should have
different handler. If the match condition is not satisfied, we should
try next auth method and if there is no more auth method, it's an
anonymous user. If the condition matched but verify failed, the auth
process should be stop and return immediately.

This will fix #20563

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: Jason Song <i@wolfogre.com>
2 years ago
..
composer Add support for HEAD requests in Maven registry (#21834) (#21929) 2 years ago
conan refactor auth interface to return error when verify failure (#22119) (#22259) 2 years ago
container refactor auth interface to return error when verify failure (#22119) (#22259) 2 years ago
generic Add support for HEAD requests in Maven registry (#21834) (#21929) 2 years ago
helm Add support for HEAD requests in Maven registry (#21834) (#21929) 2 years ago
helper Add Package Registry (#16510) 3 years ago
maven Add support for HEAD requests in Maven registry (#21834) (#21929) 2 years ago
npm Fix condition for is_internal (#22095) (#22132) 2 years ago
nuget refactor auth interface to return error when verify failure (#22119) (#22259) 2 years ago
pub Add support for HEAD requests in Maven registry (#21834) (#21929) 2 years ago
pypi Add support for HEAD requests in Maven registry (#21834) (#21929) 2 years ago
rubygems Add support for HEAD requests in Maven registry (#21834) (#21929) 2 years ago
vagrant Add support for HEAD requests in Maven registry (#21834) (#21929) 2 years ago
api.go refactor auth interface to return error when verify failure (#22119) (#22259) 2 years ago