mirror of https://github.com/go-gitea/gitea.git
You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Before:

After:

There's a bug in the recent logic, `CalcCommitStatus` will always return
the first item of `statuses` or error status, because `state` is defined
with default value which should be `CommitStatusSuccess`
Then
``` golang
if status.State.NoBetterThan(state) {
```
this `if` will always return false unless `status.State =
CommitStatusError` which makes no sense.
So `lastStatus` will always be `nil` or error status.
Then we will always return the first item of `statuses` here or only
return error status, and this is why in the first picture the commit
status is `Success` but not `Failure`.
|
2 years ago | |
---|---|---|
.. | ||
actions | 2 years ago | |
activities | 2 years ago | |
admin | 2 years ago | |
asymkey | 2 years ago | |
auth | 2 years ago | |
avatars | 2 years ago | |
db | 2 years ago | |
dbfs | 2 years ago | |
fixtures | 2 years ago | |
git | 2 years ago | |
issues | 2 years ago | |
migrations | 2 years ago | |
organization | 2 years ago | |
packages | 2 years ago | |
perm | 2 years ago | |
project | 2 years ago | |
pull | 2 years ago | |
repo | 2 years ago | |
secret | 2 years ago | |
shared/types | 2 years ago | |
system | 2 years ago | |
unit | 2 years ago | |
unittest | 2 years ago | |
user | 2 years ago | |
webhook | 2 years ago | |
error.go | 2 years ago | |
fixture_generation.go | 2 years ago | |
fixture_test.go | 2 years ago | |
main_test.go | 2 years ago | |
migrate.go | 2 years ago | |
migrate_test.go | 2 years ago | |
org.go | 2 years ago | |
org_team.go | 2 years ago | |
org_team_test.go | 2 years ago | |
org_test.go | 2 years ago | |
repo.go | 2 years ago | |
repo_collaboration.go | 2 years ago | |
repo_collaboration_test.go | 2 years ago | |
repo_test.go | 2 years ago | |
repo_transfer.go | 2 years ago | |
repo_transfer_test.go | 2 years ago |