You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Lunny Xiao 900e158064 refactor auth interface to return error when verify failure (#22119) (#22259) ... backport #22119 This PR changed the Auth interface signature from `Verify(http *http.Request, w http.ResponseWriter, store DataStore, sess SessionStore) *user_model.User` to `Verify(http *http.Request, w http.ResponseWriter, store DataStore, sess SessionStore) (*user_model.User, error)`. There is a new return argument `error` which means the verification condition matched but verify process failed, we should stop the auth process. Before this PR, when return a `nil` user, we don't know the reason why it returned `nil`. If the match condition is not satisfied or it verified failure? For these two different results, we should have different handler. If the match condition is not satisfied, we should try next auth method and if there is no more auth method, it's an anonymous user. If the condition matched but verify failed, the auth process should be stop and return immediately. This will fix #20563 Co-authored-by: KN4CK3R <admin@oldschoolhack.me> Co-authored-by: Jason Song <i@wolfogre.com>		2 years ago
..
agit	Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551)	2 years ago
asymkey	Refactor AssertExistsAndLoadBean to use generics (#20797)	3 years ago
attachment	Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551)	2 years ago
auth	refactor auth interface to return error when verify failure (#22119) (#22259)	2 years ago
automerge	Add more linters to improve code readability (#19989)	3 years ago
comments	Move issues related files into models/issues (#19931)	3 years ago
context	Move almost all functions' parameter db.Engine to context.Context (#19748)	3 years ago
cron	Refactor git command arguments and make all arguments to be safe to be used (#21535)	2 years ago
externalaccount	Refactor auth package (#17962)	3 years ago
forms	Revert unrelated changes for SMTP auth (#21767) (#21768)	2 years ago
gitdiff	Refactor git command arguments and make all arguments to be safe to be used (#21535)	2 years ago
issue	Fix issue/PR numbers (#22037) (#22044)	2 years ago
lfs	Prevent Authorization header for presigned LFS urls (#21531)	2 years ago
mailer	Correct the fallbacks for mailer configuration (#21945) (#21953)	2 years ago
markup	Link mentioned user in markdown only if they are visible to viewer (#21554)	2 years ago
migrations	Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551)	2 years ago
mirror	Refactor git command arguments and make all arguments to be safe to be used (#21535)	2 years ago
org	Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551)	2 years ago
packages	refactor auth interface to return error when verify failure (#22119) (#22259)	2 years ago
pull	Use complete SHA to create and query commit status (#22244) (#22257)	2 years ago
release	Revert "Do not send notifications for draft releases (#21451)" (#21594)	2 years ago
repository	Use complete SHA to create and query commit status (#22244) (#22257)	2 years ago
task	Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551)	2 years ago
user	Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551)	2 years ago
webhook	Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551)	2 years ago
wiki	Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551)	2 years ago