You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
gitea/models/git
Henry Goodman 12cb1d2998
Allow force push to protected branches (#28086)
Fixes #22722 

### Problem
Currently, it is not possible to force push to a branch with branch
protection rules in place. There are often times where this is necessary
(CI workflows/administrative tasks etc).

The current workaround is to rename/remove the branch protection,
perform the force push, and then reinstate the protections.

### Solution
Provide an additional section in the branch protection rules to allow
users to specify which users with push access can also force push to the
branch. The default value of the rule will be set to `Disabled`, and the
UI is intuitive and very similar to the `Push` section.

It is worth noting in this implementation that allowing force push does
not override regular push access, and both will need to be enabled for a
user to force push.

This applies to manual force push to a remote, and also in Gitea UI
updating a PR by rebase (which requires force push)

This modifies the `BranchProtection` API structs to add:
- `enable_force_push bool`
- `enable_force_push_whitelist bool`
- `force_push_whitelist_usernames string[]`
- `force_push_whitelist_teams string[]`
- `force_push_whitelist_deploy_keys bool`

### Updated Branch Protection UI:

<img width="943" alt="image"
src="https://github.com/go-gitea/gitea/assets/79623665/7491899c-d816-45d5-be84-8512abd156bf">

### Pull Request `Update branch by Rebase` option enabled with source
branch `test` being a protected branch:


![image](https://github.com/go-gitea/gitea/assets/79623665/e018e6e9-b7b2-4bd3-808e-4947d7da35cc)
<img width="1038" alt="image"
src="https://github.com/go-gitea/gitea/assets/79623665/57ead13e-9006-459f-b83c-7079e6f4c654">

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
7 months ago
..
branch.go Fix wrong display of recently pushed notification (#25812) 8 months ago
branch_list.go Fix branch order (#31174) 8 months ago
branch_test.go Start to migrate from `util.OptionalBool` to `optional.Option[bool]` (#29329) 11 months ago
commit_status.go Fix duplicate status check contexts (#30660) 9 months ago
commit_status_summary.go Fix commitstatus summary (#30431) 10 months ago
commit_status_test.go Fix duplicate status check contexts (#30660) 9 months ago
lfs.go Remove GetByBean method because sometimes it's danger when query condition parameter is zero and also introduce new generic methods (#28220) 1 year ago
lfs_lock.go chore: use errors.New to replace fmt.Errorf with no parameters will much better (#30621) 9 months ago
main_test.go make writing main test easier (#27270) 1 year ago
protected_banch_list_test.go Fix branch protection priority (#24045) 2 years ago
protected_branch.go Allow force push to protected branches (#28086) 7 months ago
protected_branch_list.go Start to migrate from `util.OptionalBool` to `optional.Option[bool]` (#29329) 11 months ago
protected_branch_test.go Supports wildcard protected branch (#20825) 2 years ago
protected_tag.go Add tag protection via rest api #17862 (#31295) 8 months ago
protected_tag_test.go Implement FSFE REUSE for golang files (#21840) 2 years ago