You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
gitea/routers/private
Henry Goodman 12cb1d2998
Allow force push to protected branches (#28086)
Fixes #22722 

### Problem
Currently, it is not possible to force push to a branch with branch
protection rules in place. There are often times where this is necessary
(CI workflows/administrative tasks etc).

The current workaround is to rename/remove the branch protection,
perform the force push, and then reinstate the protections.

### Solution
Provide an additional section in the branch protection rules to allow
users to specify which users with push access can also force push to the
branch. The default value of the rule will be set to `Disabled`, and the
UI is intuitive and very similar to the `Push` section.

It is worth noting in this implementation that allowing force push does
not override regular push access, and both will need to be enabled for a
user to force push.

This applies to manual force push to a remote, and also in Gitea UI
updating a PR by rebase (which requires force push)

This modifies the `BranchProtection` API structs to add:
- `enable_force_push bool`
- `enable_force_push_whitelist bool`
- `force_push_whitelist_usernames string[]`
- `force_push_whitelist_teams string[]`
- `force_push_whitelist_deploy_keys bool`

### Updated Branch Protection UI:

<img width="943" alt="image"
src="https://github.com/go-gitea/gitea/assets/79623665/7491899c-d816-45d5-be84-8512abd156bf">

### Pull Request `Update branch by Rebase` option enabled with source
branch `test` being a protected branch:


![image](https://github.com/go-gitea/gitea/assets/79623665/e018e6e9-b7b2-4bd3-808e-4947d7da35cc)
<img width="1038" alt="image"
src="https://github.com/go-gitea/gitea/assets/79623665/57ead13e-9006-459f-b83c-7079e6f4c654">

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
7 months ago
..
tests/repos Fix verifyCommits error when push a new branch (#26664) 1 year ago
actions.go Clean up log messages (#30313) 10 months ago
default_branch.go Refactor names (#31405) 8 months ago
hook_post_receive.go Refactor names (#31405) 8 months ago
hook_post_receive_test.go Move database operations of merging a pull request to post receive hook and add a transaction (#30805) 9 months ago
hook_pre_receive.go Allow force push to protected branches (#28086) 7 months ago
hook_proc_receive.go Make sure git version&feature are always prepared (#30877) 9 months ago
hook_verification.go Clean up log messages (#30313) 10 months ago
hook_verification_test.go Adjust object format interface (#28469) 1 year ago
internal.go Refactor names (#31405) 8 months ago
internal_repo.go Refactor names (#31405) 8 months ago
key.go Refactor names (#31405) 8 months ago
mail.go Clean up log messages (#30313) 10 months ago
main_test.go make writing main test easier (#27270) 1 year ago
manager.go Refactor names (#31405) 8 months ago
manager_process.go Move context from modules to services (#29440) 11 months ago
manager_unix.go Move context from modules to services (#29440) 11 months ago
manager_windows.go Move context from modules to services (#29440) 11 months ago
restore_repo.go Move context from modules to services (#29440) 11 months ago
serv.go Refactor names (#31405) 8 months ago
ssh_log.go Move context from modules to services (#29440) 11 months ago