github-forks
/
gitea
mirror of https://github.com/go-gitea/gitea.git
1
0
Fork 0
Code Projects Releases Activity
gitea/routers/web
History
wxiaoguang 59d060622d
Improve RSS () 
Follow  

### Major changes

1. `ServerError` doesn't do format, so remove the `%s`
2. Simplify `RenderBranchFeed` (slightly)
3. Remove unused `BranchFeedRSS`
4. Make `feed.RenderBranchFeed` respect `EnableFeed` config
5. Make `RepoBranchTagSelector.vue` respect `EnableFeed` setting,
otherwise there is always RSS icon
6. The `(branchURLPrefix + item.url).replace('src', 'rss')` doesn't seem
right for all cases, for example, the string `src` could appear in
`branchURLPrefix`, so we need a separate `rssURLPrefix`
7. The `<a>` in Vue menu needs `@click.stop`, otherwise the menu itself
would be triggered at the same time
8. Change `<a><button></button></a>` to `<a role=button>`
9. Use `{{PathEscapeSegments .TreePath}}` instead of `{{range $i, $v :=
.TreeNames}}/{{$v}}{{end}}`


Screenshot of changed parts:

<details>


![image](https://user-images.githubusercontent.com/2114189/234315538-66603694-9093-48a8-af33-83575fd7a018.png)


![image](https://user-images.githubusercontent.com/2114189/234315786-f1efa60b-012e-490b-8ce2-d448dc6fe5c9.png)


![image](https://user-images.githubusercontent.com/2114189/234334941-446941bc-1baa-4256-8850-ccc439476cda.png)

</details>


### Other thoughts

Should we remove the RSS icon from the branch dropdown list? It seems
too complex for a list UI, and users already have the chance to get the
RSS feed URL from "branches" page.

---------

Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: silverwind <me@silverwind.io>
..
admin Use auto-updating, natively hoverable, localized time elements ()
auth Respect the REGISTER_MANUAL_CONFIRM setting when registering via OIDC ()
devtest Remove untranslatable `on_date` key ()
events Implement FSFE REUSE for golang files ()
explore Add ONLY_SHOW_RELEVANT_REPOS back, fix explore page bug, make code more strict ()
feed Improve RSS ()
healthcheck Refactor `setting.Database.UseXXX` to methods ()
misc Introduce GitHub markdown editor, keep EasyMDE as fallback ()
org Only delete secrets belonging to its owner ()
repo Improve RSS ()
shared Only delete secrets belonging to its owner ()
user Only delete secrets belonging to its owner ()
auth.go Implement FSFE REUSE for golang files ()
auth_windows.go Implement FSFE REUSE for golang files ()
base.go Improve Wiki TOC ()
goget.go refactor some functions to support ctx as first parameter ()
home.go Refactor cookie ()
metrics.go Implement FSFE REUSE for golang files ()
nodeinfo.go Implement FSFE REUSE for golang files ()
swagger_json.go Group template helper functions, remove `Printf`, improve template error messages ()
web.go Improve RSS ()
webfinger.go Use User.ID instead of User.Name in ActivityPub API for Person IRI ()