mirror of https://github.com/go-gitea/gitea.git
You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
21a1d76911
### The CustomEvent prefix There was already `ce-quick-submit`, the `ce-` prefix seems better than `us-`. Rename the only `us-` prefixed `us-load-context-popup` to `ce-` prefixed. ### Styles and Attributes in Go HTML Template https://github.com/go-gitea/gitea/pull/21855#issuecomment-1429643073 Suggest to stick to `class="c1 {{if $var}}c2{{end}}"` The readability and maintainability should be applied to the code which is read by developers, but not for the generated outputs. The template code is the code for developers, while the generated HTML are only for browsers. The `class="c1 {{if $var}}c2{{end}}"` style is clearer for developers and more intuitive, and the generated HTML also makes browsers happy (a few spaces do not affect anything) Think about a more complex case: * `class="{{if $active}}active{{end}} menu item {{if $show}}show{{end}} {{if $warn}}warn{{end}}"` * --vs-- * `class="{{if $active}}active {{end}}menu item{{if $show}} show{{end}}{{if $warn}} warn{{end}}"` The first style make it clearer to see each CSS class name with its `{{if}}` block. Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> |
2 years ago | |
|---|---|---|
| .. | ||
| .eslintrc.yaml | 3 years ago | |
| ActivityHeatmap.vue | 2 years ago | |
| ContextPopup.vue | 2 years ago | |
| DashboardRepoList.js | 2 years ago | |
| DiffFileList.vue | 2 years ago | |
| DiffFileTree.vue | 2 years ago | |
| DiffFileTreeItem.vue | 2 years ago | |
| PullRequestMergeForm.vue | 2 years ago | |
| RepoActionView.vue | 2 years ago | |
| RepoActivityTopAuthors.vue | 3 years ago | |
| RepoBranchTagDropdown.js | 2 years ago | |
| VueComponentLoader.js | 2 years ago | |