github-forks
/
gitea
mirror of https://github.com/go-gitea/gitea.git
1
0
Fork 0
Code Projects Releases Activity
gitea/modules/private
History
Lunny Xiao ebf0c96940
Move database operations of merging a pull request to post receive hook and add a transaction () 
Merging PR may fail because of various problems. The pull request may
have a dirty state because there is no transaction when merging a pull
request. ref
https://github.com/go-gitea/gitea/pull/25741#issuecomment-2074126393

This PR moves all database update operations to post-receive handler for
merging a pull request and having a database transaction. That means if
database operations fail, then the git merging will fail, the git client
will get a fail result.

There are already many tests for pull request merging, so we don't need
to add a new one.

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
..
actions.go Return `responseText` instead of string in some functions ()
hook.go Move database operations of merging a pull request to post receive hook and add a transaction ()
internal.go Refactor internal API for git commands, use meaningful messages instead of "Internal Server Error" ()
key.go Return `responseText` instead of string in some functions ()
mail.go Return `responseText` instead of string in some functions ()
manager.go Replace `interface{}` with `any` ()
request.go Return `responseText` instead of string in some functions ()
restore_repo.go Fix regression: access log template, gitea manager cli command ()
serv.go Refactor internal API for git commands, use meaningful messages instead of "Internal Server Error" ()