You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
gitea/templates/user/settings
delvh 81fe5d6185
Convert `<div class="button">` to `<button class="button">` (#23337)
This improves a lot of accessibility shortcomings.
Every possible instance of `<div class="button">` matching the command
`ag '<[^ab].*?class=.*?[" ]button[ "]' templates/ | grep -v 'dropdown'`
has been converted when possible.
divs with the `dropdown` class and their children were omitted as
1. more analysis must be conducted whether the dropdowns still work as
intended when they are a `button` instead of a `div`.
2. most dropdowns have `div`s as children. The HTML standard disallows
`div`s inside `button`s.
3. When a dropdown child that's part of the displayed text content is
converted to a `button`, the dropdown can be focused twice

Further changes include that all "gitea-managed" buttons with JS code
received an `e.preventDefault()` so that they don't accidentally submit
an underlying form, which would execute instead of cancel the action.
Lastly, some minor issues were fixed as well during the refactoring.

## Future improvements

As mentioned in
https://github.com/go-gitea/gitea/pull/23337#discussion_r1127277391,
`<a>`s without `href` attribute are not focusable.
They should later on be converted to `<button>`s.

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2 years ago
..
security Convert `<div class="button">` to `<button class="button">` (#23337) 2 years ago
account.tmpl Convert `<div class="button">` to `<button class="button">` (#23337) 2 years ago
appearance.tmpl Add main landmark to templates and adjust titles (#22670) 2 years ago
applications.tmpl Convert `<div class="button">` to `<button class="button">` (#23337) 2 years ago
applications_oauth2.tmpl Allow creation of OAuth2 applications for orgs (#18084) 2 years ago
applications_oauth2_edit.tmpl Add main landmark to templates and adjust titles (#22670) 2 years ago
applications_oauth2_edit_form.tmpl Record OAuth client type at registration (#21316) 2 years ago
applications_oauth2_list.tmpl Move helpers to be prefixed with `gt-` (#22879) 2 years ago
grants_oauth2.tmpl Move helpers to be prefixed with `gt-` (#22879) 2 years ago
hook_new.tmpl Add user webhooks (#21563) 2 years ago
hooks.tmpl Add user webhooks (#21563) 2 years ago
keys.tmpl Add main landmark to templates and adjust titles (#22670) 2 years ago
keys_gpg.tmpl Convert `<div class="button">` to `<button class="button">` (#23337) 2 years ago
keys_principal.tmpl Convert `<div class="button">` to `<button class="button">` (#23337) 2 years ago
keys_ssh.tmpl Convert `<div class="button">` to `<button class="button">` (#23337) 2 years ago
navbar.tmpl Add user webhooks (#21563) 2 years ago
organization.tmpl Add context cache as a request level cache (#22294) 2 years ago
packages.tmpl Add Chef package registry (#22554) 2 years ago
packages_cleanup_rules_edit.tmpl Add main landmark to templates and adjust titles (#22670) 2 years ago
packages_cleanup_rules_preview.tmpl Add main landmark to templates and adjust titles (#22670) 2 years ago
profile.tmpl Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 2 years ago
repos.tmpl Convert `<div class="button">` to `<button class="button">` (#23337) 2 years ago
secrets.tmpl Add user secrets (#22191) 2 years ago