You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
gitea/routers/api/v1
Otto Richter (fnetX) 3362620ee3
Fix api error message if fork exists (#24487)
On the @Forgejo instance of Codeberg, we discovered that forking a repo
which is already forked now returns a 500 Internal Server Error, which
is unexpected. This is an attempt at fixing this.

The error message in the log:
~~~
2023/05/02 08:36:30 .../api/v1/repo/fork.go:147:CreateFork() [E]
[6450cb8e-113] ForkRepository: repository is already forked by user
[uname: ...., repo path: .../..., fork path: .../...]
~~~

The service that is used for forking returns a custom error message
which is not checked against.

About the order of options:
The case that the fork already exists should be more common, followed by
the case that a repo with the same name already exists for other
reasons. The case that the global repo limit is hit is probably not the
likeliest.

Co-authored-by: Otto Richter <otto@codeberg.org>
Co-authored-by: Giteabot <teabot@gitea.io>
2 years ago
..
activitypub Use User.ID instead of User.Name in ActivityPub API for Person IRI (#23823) 2 years ago
admin Fix unclear `IsRepositoryExist` logic (#24374) 2 years ago
misc Use globally shared HTMLRender (#24436) 2 years ago
notify Move `convert` package to services (#22264) 2 years ago
org Fix admin team access mode value in team_unit table (#24012) 2 years ago
packages Add Debian package registry (#24426) 2 years ago
repo Fix api error message if fork exists (#24487) 2 years ago
settings Implement FSFE REUSE for golang files (#21840) 2 years ago
swagger Add API for gitignore templates (#22783) 2 years ago
user Add activity feeds API (#23494) 2 years ago
utils Add user webhooks (#21563) 2 years ago
api.go Add API for gitignore templates (#22783) 2 years ago
auth.go Implement FSFE REUSE for golang files (#21840) 2 years ago
auth_windows.go Implement FSFE REUSE for golang files (#21840) 2 years ago