mirror of https://github.com/go-gitea/gitea.git
You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
06f968d662
Backport #20925 This commit updates the `GET /api/v1/repos/{owner}/{repo}/archive/{archive}` endpoint which prior to this PR had a couple of issues. 1. The endpoint had a hard-coded 20s timeout for the archiver to complete after which a 500 (Internal Server Error) was returned to client. For a scripted API client there was no clear way of telling that the operation timed out and that it should retry. 2. Whenever the timeout _did occur_, the code used to panic. This was caused by the API endpoint "delegating" to the same call path as the web, which uses a slightly different way of reporting errors (HTML rather than JSON for example). More specifically, `api/v1/repo/file.go#GetArchive` just called through to `web/repo/repo.go#Download`, which expects the `Context` to have a `Render` field set, but which is `nil` for API calls. Hence, a `nil` pointer error. The code addresses (1) by dropping the hard-coded timeout. Instead, any timeout/cancelation on the incoming `Context` is used. The code addresses (2) by updating the API endpoint to use a separate call path for the API-triggered archive download. This avoids producing HTML-errors on errors (it now produces JSON errors). Signed-off-by: Peter Gardfjäll <peter.gardfjall.work@gmail.com> Signed-off-by: Peter Gardfjäll <peter.gardfjall.work@gmail.com> Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Peter Gardfjäll <peter.gardfjall.work@gmail.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> |
3 years ago | |
|---|---|---|
| .. | ||
| activitypub | ||
| analyze | 3 years ago | |
| appstate | ||
| auth | 3 years ago | |
| avatar | 3 years ago | |
| base | 3 years ago | |
| cache | 3 years ago | |
| charset | 3 years ago | |
| container | ||
| context | 3 years ago | |
| convert | 3 years ago | |
| csv | 3 years ago | |
| doctor | 3 years ago | |
| emoji | ||
| eventsource | 3 years ago | |
| generate | ||
| git | 3 years ago | |
| gitgraph | 3 years ago | |
| graceful | 3 years ago | |
| hcaptcha | ||
| highlight | 3 years ago | |
| hostmatcher | 3 years ago | |
| httpcache | 3 years ago | |
| httplib | ||
| indexer | 3 years ago | |
| json | ||
| lfs | 3 years ago | |
| log | 3 years ago | |
| markup | 3 years ago | |
| metrics | ||
| migration | 3 years ago | |
| nosql | 3 years ago | |
| notification | 3 years ago | |
| options | 3 years ago | |
| packages | 3 years ago | |
| paginator | ||
| password | ||
| pprof | ||
| private | ||
| process | 3 years ago | |
| proxy | ||
| public | 3 years ago | |
| queue | ||
| recaptcha | ||
| references | 3 years ago | |
| regexplru | 3 years ago | |
| repository | 3 years ago | |
| secret | ||
| session | ||
| setting | 3 years ago | |
| ssh | 3 years ago | |
| storage | ||
| structs | 3 years ago | |
| svg | 3 years ago | |
| sync | ||
| templates | 3 years ago | |
| test | 3 years ago | |
| timeutil | 3 years ago | |
| translation | ||
| typesniffer | 3 years ago | |
| updatechecker | ||
| upload | ||
| uri | ||
| user | ||
| util | 3 years ago | |
| validation | 3 years ago | |
| web | 3 years ago | |