github-forks
/
gitea
mirror of https://github.com/go-gitea/gitea.git
1
0
Fork 0
Code Projects Releases Activity
gitea/routers/private/tests/repos/repo1_hook_verification/objects
History
CaiCandong 815d267c80
Fix verifyCommits error when push a new branch () 
> ### Description
> If a new branch is pushed, and the repository has a rule that would
require signed commits for the new branch, the commit is rejected with a
500 error regardless of whether it's signed.
> 
> When pushing a new branch, the "old" commit is the empty ID
(0000000000000000000000000000000000000000). verifyCommits has no
provision for this and passes an invalid commit range to git rev-list.
Prior to 1.19 this wasn't an issue because only pre-existing individual
branches could be protected.
> 
> I was able to reproduce with
[try.gitea.io/CraigTest/test](https://try.gitea.io/CraigTest/test),
which is set up with a blanket rule to require commits on all branches.


Fix 
Very thanks to @Craig-Holmquist-NTI for reporting the bug and suggesting
an valid solution!

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
..
0b Fix verifyCommits error when push a new branch ()
2b Fix verifyCommits error when push a new branch ()
08 Fix verifyCommits error when push a new branch ()
8b Fix verifyCommits error when push a new branch ()
9c Fix verifyCommits error when push a new branch ()
13 Fix verifyCommits error when push a new branch ()
23 Fix verifyCommits error when push a new branch ()
65 Fix verifyCommits error when push a new branch ()
72 Fix verifyCommits error when push a new branch ()
93 Fix verifyCommits error when push a new branch ()
97 Fix verifyCommits error when push a new branch ()
a9 Fix verifyCommits error when push a new branch ()
ba Fix verifyCommits error when push a new branch ()
bb Fix verifyCommits error when push a new branch ()
cb Fix verifyCommits error when push a new branch ()
d7 Fix verifyCommits error when push a new branch ()
e3 Fix verifyCommits error when push a new branch ()
e6 Fix verifyCommits error when push a new branch ()
e8 Fix verifyCommits error when push a new branch ()
info Fix verifyCommits error when push a new branch ()
tmp_objdir-incoming-a21648 Fix verifyCommits error when push a new branch ()