You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
gitea/services/pull
Henry Goodman 12cb1d2998
Allow force push to protected branches (#28086)
Fixes #22722 

### Problem
Currently, it is not possible to force push to a branch with branch
protection rules in place. There are often times where this is necessary
(CI workflows/administrative tasks etc).

The current workaround is to rename/remove the branch protection,
perform the force push, and then reinstate the protections.

### Solution
Provide an additional section in the branch protection rules to allow
users to specify which users with push access can also force push to the
branch. The default value of the rule will be set to `Disabled`, and the
UI is intuitive and very similar to the `Push` section.

It is worth noting in this implementation that allowing force push does
not override regular push access, and both will need to be enabled for a
user to force push.

This applies to manual force push to a remote, and also in Gitea UI
updating a PR by rebase (which requires force push)

This modifies the `BranchProtection` API structs to add:
- `enable_force_push bool`
- `enable_force_push_whitelist bool`
- `force_push_whitelist_usernames string[]`
- `force_push_whitelist_teams string[]`
- `force_push_whitelist_deploy_keys bool`

### Updated Branch Protection UI:

<img width="943" alt="image"
src="https://github.com/go-gitea/gitea/assets/79623665/7491899c-d816-45d5-be84-8512abd156bf">

### Pull Request `Update branch by Rebase` option enabled with source
branch `test` being a protected branch:


![image](https://github.com/go-gitea/gitea/assets/79623665/e018e6e9-b7b2-4bd3-808e-4947d7da35cc)
<img width="1038" alt="image"
src="https://github.com/go-gitea/gitea/assets/79623665/57ead13e-9006-459f-b83c-7079e6f4c654">

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
7 months ago
..
check.go Fix misspelling of mergable (#30896) 9 months ago
check_test.go Replace assert.Fail with assert.FailNow (#27578) 1 year ago
comment.go Update misspell to 0.5.1 and add `misspellings.csv` (#30573) 10 months ago
commit_status.go Use db.ListOptionsAll instead of db.ListOptions{ListAll: true} (#29995) 11 months ago
commit_status_test.go Fixing the issue when status check per rule matches multiple actions (#29631) 11 months ago
edits.go Implement FSFE REUSE for golang files (#21840) 2 years ago
lfs.go Remove GetByBean method because sometimes it's danger when query condition parameter is zero and also introduce new generic methods (#28220) 1 year ago
main_test.go make writing main test easier (#27270) 1 year ago
merge.go Fix duplicate sub-path for avatars (#31365) 8 months ago
merge_ff_only.go Add merge style `fast-forward-only` (#28954) 1 year ago
merge_merge.go Add merge style `fast-forward-only` (#28954) 1 year ago
merge_prepare.go Refactor merge/update git command calls (#23366) 2 years ago
merge_rebase.go Simplify how git repositories are opened (#28937) 1 year ago
merge_squash.go Simplify how git repositories are opened (#28937) 1 year ago
merge_test.go Support template for merge message description (#22248) 2 years ago
patch.go Fix slow patch checking with commits that add or remove many files (#31548) 7 months ago
patch_unmerged.go Implement FSFE REUSE for golang files (#21840) 2 years ago
pull.go Update misspell to 0.5.1 and add `misspellings.csv` (#30573) 10 months ago
pull_test.go Simplify how git repositories are opened (#28937) 1 year ago
review.go Resolve lint for unused parameter and unnecessary type arguments (#30750) 9 months ago
review_test.go Prevent re-review and dismiss review actions on closed and merged PRs (#30065) 11 months ago
temp_repo.go Make sure git version&feature are always prepared (#30877) 9 months ago
update.go Allow force push to protected branches (#28086) 7 months ago
update_rebase.go Resolve lint for unused parameter and unnecessary type arguments (#30750) 9 months ago