You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
gitea/services/doctor
Lunny Xiao 5f82ead13c
Simplify how git repositories are opened (#28937)
## Purpose
This is a refactor toward building an abstraction over managing git
repositories.
Afterwards, it does not matter anymore if they are stored on the local
disk or somewhere remote.

## What this PR changes
We used `git.OpenRepository` everywhere previously.
Now, we should split them into two distinct functions:

Firstly, there are temporary repositories which do not change:

```go
git.OpenRepository(ctx, diskPath)
```

Gitea managed repositories having a record in the database in the
`repository` table are moved into the new package `gitrepo`:

```go
gitrepo.OpenRepository(ctx, repo_model.Repo)
```

Why is `repo_model.Repository` the second parameter instead of file
path?
Because then we can easily adapt our repository storage strategy.
The repositories can be stored locally, however, they could just as well
be stored on a remote server.

## Further changes in other PRs
- A Git Command wrapper on package `gitrepo` could be created. i.e.
`NewCommand(ctx, repo_model.Repository, commands...)`. `git.RunOpts{Dir:
repo.RepoPath()}`, the directory should be empty before invoking this
method and it can be filled in the function only. #28940
- Remove the `RepoPath()`/`WikiPath()` functions to reduce the
possibility of mistakes.

---------

Co-authored-by: delvh <dev.lh@web.de>
1 year ago
..
authorizedkeys.go Move doctor package from modules to services (#28856) 1 year ago
breaking.go Move doctor package from modules to services (#28856) 1 year ago
checkOldArchives.go Move doctor package from modules to services (#28856) 1 year ago
dbconsistency.go Move doctor package from modules to services (#28856) 1 year ago
dbversion.go Move doctor package from modules to services (#28856) 1 year ago
doctor.go Move doctor package from modules to services (#28856) 1 year ago
fix8312.go Move doctor package from modules to services (#28856) 1 year ago
fix16961.go Move doctor package from modules to services (#28856) 1 year ago
fix16961_test.go Move doctor package from modules to services (#28856) 1 year ago
heads.go Move doctor package from modules to services (#28856) 1 year ago
lfs.go Move doctor package from modules to services (#28856) 1 year ago
mergebase.go Move doctor package from modules to services (#28856) 1 year ago
misc.go Simplify how git repositories are opened (#28937) 1 year ago
paths.go Move doctor package from modules to services (#28856) 1 year ago
repository.go Move doctor package from modules to services (#28856) 1 year ago
storage.go Move doctor package from modules to services (#28856) 1 year ago
usertype.go Move doctor package from modules to services (#28856) 1 year ago