You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
gitea/modules
zeripath 2e36ba0a00
Send mail to issue/pr assignee/reviewer also when OnMention is set (#18707) (#18765)
Backport #18707

Addresses #17892, where emails notifications are not sent to assignees (issue and PR) and reviewers (PR) when they have the email setting Only email on mention enabled.

From the user experience perspective, when a user gets a issue/PR assigned or a PR review request, he/she would expect to be implicitly mentioned since the assignment or request is personal and targeting a single person only. Thus I see #17892 as a bug. Could we therefore mark this ticket as such?

The changed code just explicitly checks for the EmailNotificationsOnMention setting beside the existing EmailNotificationsEnabled check. Too rude?

@lunny mentioned a mock mail server for tests, is there something ready. How could I make use of it?

See #12774 (comment)

Fix #17892

Co-authored-by: flozzone <flozzone@gmail.com>
3 years ago
..
activitypub Create pub/priv keypair for federation (#17071) 3 years ago
analyze Use git attributes to determine generated and vendored status for language stats and diffs (#16773) 4 years ago
appstate Decouple unit test code from business code (#17623) 3 years ago
auth Support webauthn (#17957) 3 years ago
avatar Fix various typos (#18219) 3 years ago
base Simplify parameter types (#18006) 3 years ago
cache Test cache during init (#17852) 3 years ago
charset Add warning for BIDI characters in page renders and in diffs (#17562) 3 years ago
context If rendering has failed due to a net.OpError stop rendering (#18642) (#18645) 3 years ago
convert Add MirrorUpdated field to Repository API type (#18267) 3 years ago
csv Fix various typos (#18219) 3 years ago
doctor Fix various typos (#18219) 3 years ago
emoji Run processors on whole of text (#16155) 4 years ago
eventsource Simplify parameter types (#18006) 3 years ago
generate Support webauthn (#17957) 3 years ago
git Fix isempty detection of git repository (#18746) (#18750) 3 years ago
gitgraph Collaborator trust model should trust collaborators (#18539) (#18557) 3 years ago
graceful Make SSL cipher suite configurable (#17440) 3 years ago
hcaptcha hCaptcha Support (#12594) 4 years ago
highlight Add .gitattribute assisted language detection to blame, diff and render (#17590) 3 years ago
hostmatcher Simplify parameter types (#18006) 3 years ago
httpcache Use a variable but a function for IsProd because of a slight performance increment (#17368) 3 years ago
httplib refactor: move from io/ioutil to io and os package (#17109) 3 years ago
indexer Upgrade bleve from v2.0.6 to v2.3.0 (#18132) 3 years ago
json Move repository model into models/repo (#17933) 3 years ago
lfs Fix source typos (#18227) 3 years ago
log Simplify parameter types (#18006) 3 years ago
markup Prevent NPE on partial match of compare URL and allow short SHA1 compare URLs (#18472) (#18473) 3 years ago
metrics Refactor auth package (#17962) 3 years ago
migration Fix various typos (#18219) 3 years ago
nosql Remove unnecessary variable assignments (#17695) 3 years ago
notification Send mail to issue/pr assignee/reviewer also when OnMention is set (#18707) (#18765) 3 years ago
options Remove golang vendored directory (#18277) 3 years ago
password Fixed assert statements. (#16089) 4 years ago
pprof refactor: move from io/ioutil to io and os package (#17109) 3 years ago
private Move keys to models/asymkey (#17917) 3 years ago
process Fix various typos (#18219) 3 years ago
proxy Return nil proxy function if proxy not enabled (#16742) 4 years ago
public Fix mime-type detection for HTTP server (#18371) 3 years ago
queue Restart zero worker if there is still work to do (#18658) (#18672) 3 years ago
recaptcha refactor: move from io/ioutil to io and os package (#17109) 3 years ago
references Add API to get issue/pull comments and events (timeline) (#17403) 3 years ago
repository Add `GetUserTeams` (#18499) (#18531) 3 years ago
secret Simplify parameter types (#18006) 3 years ago
session Refactor auth package (#17962) 3 years ago
setting Prevent security failure due to bad APP_ID (#18678) (#18682) 3 years ago
ssh Simplify parameter types (#18006) 3 years ago
storage refactor: move from io/ioutil to io and os package (#17109) 3 years ago
structs Add MirrorUpdated field to Repository API type (#18267) 3 years ago
svg refactor: move from io/ioutil to io and os package (#17109) 3 years ago
sync Fix missing unlock in uniquequeue (#9790) 5 years ago
templates Remove golang vendored directory (#18277) 3 years ago
test Unify and simplify TrN for i18n (#18141) 3 years ago
timeutil Don't store assets modified time into generated files (#18193) 3 years ago
translation Sort locales according to their names (#18211) 3 years ago
typesniffer Read expected buffer size (#17409) 3 years ago
updatechecker Fix various typos (#18219) 3 years ago
upload Simplify parameter types (#18006) 3 years ago
uri Prevent NPE if gitea uploader fails to open url (#18080) 3 years ago
user Add gitea-vet (#10948) 5 years ago
util Increase Salt randomness (#18179) 3 years ago
validation Upgrade chi to v5 (#17298) 3 years ago
web Simplify parameter types (#18006) 3 years ago