You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
gitea/services/pull
Markus Amshove a11ccc9fcd
Disallow merge when required checked are missing (#29143)
fixes #21892 

This PR disallows merging a PR when not all commit status contexts
configured in the branch protection are met.

Previously, the PR was happy to merge when one commit status was
successful and the other contexts weren't reported.

Any feedback is welcome, first time Go :-)
I'm also not sure if the changes in the template break something else

Given the following branch protection:


![branch_protection](https://github.com/go-gitea/gitea/assets/2401875/f871b4e4-138b-435a-b496-f9ad432e3dec)

This was shown before the change:


![before](https://github.com/go-gitea/gitea/assets/2401875/60424ff0-ee09-4fa0-856e-64e6e3fb0612)

With the change, it is now shown as this:


![after](https://github.com/go-gitea/gitea/assets/2401875/4e464142-efb1-4889-8166-eb3be26c8f3d)

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
1 year ago
..
check.go Simplify how git repositories are opened (#28937) 1 year ago
check_test.go
comment.go Simplify how git repositories are opened (#28937) 1 year ago
commit_status.go Disallow merge when required checked are missing (#29143) 1 year ago
edits.go
lfs.go
main_test.go
merge.go Add merge style `fast-forward-only` (#28954) 1 year ago
merge_ff_only.go Add merge style `fast-forward-only` (#28954) 1 year ago
merge_merge.go Add merge style `fast-forward-only` (#28954) 1 year ago
merge_prepare.go
merge_rebase.go Simplify how git repositories are opened (#28937) 1 year ago
merge_squash.go Simplify how git repositories are opened (#28937) 1 year ago
merge_test.go
patch.go Simplify how git repositories are opened (#28937) 1 year ago
patch_unmerged.go
pull.go Simplify how git repositories are opened (#28937) 1 year ago
pull_test.go Simplify how git repositories are opened (#28937) 1 year ago
review.go Simplify how git repositories are opened (#28937) 1 year ago
temp_repo.go
update.go
update_rebase.go