github-forks
/
gitea
mirror of https://github.com/go-gitea/gitea.git
1
0
Fork 0
Code Projects Releases Activity
gitea/models/migrations
History
Lunny Xiao e8b6d28ab9
Fix bug hidden on CI and make ci failed if tests failure () () 
Backport  

The tests on migration tests failed but CI reports successfully


https://github.com/go-gitea/gitea/actions/runs/7364373807/job/20044685969#step:8:141

This PR will fix the bug on migrations and also the CI hidden behaviour.

The reason is on the Makefile

`GITEA_ROOT="$(CURDIR)" GITEA_CONF=tests/mysql.ini $(GO) test
$(GOTESTFLAGS) -tags='$(TEST_TAGS)' $(MIGRATE_TEST_PACKAGES)` will
return the error exit code.

But

`for pkg in $(shell $(GO) list
code.gitea.io/gitea/models/migrations/...); do \
GITEA_ROOT="$(CURDIR)" GITEA_CONF=tests/mysql.ini $(GO) test
$(GOTESTFLAGS) -tags '$(TEST_TAGS)' $$pkg; \
	done`

will not work.

---------

Co-authored-by: Giteabot <teabot@gitea.io>
..
base Fix bug hidden on CI and make ci failed if tests failure () ()
fixtures Fix bug hidden on CI and make ci failed if tests failure () ()
v1_6 Rename `Sync2` -> `Sync` ()
v1_7 Rename `Sync2` -> `Sync` ()
v1_8 Rename `Sync2` -> `Sync` ()
v1_9 Rename `Sync2` -> `Sync` ()
v1_10 Rename `Sync2` -> `Sync` ()
v1_11 Rename `Sync2` -> `Sync` ()
v1_12 Rename `Sync2` -> `Sync` ()
v1_13 Rename `Sync2` -> `Sync` ()
v1_14 Rename `Sync2` -> `Sync` ()
v1_15 Rename `Sync2` -> `Sync` ()
v1_16 Fix bug hidden on CI and make ci failed if tests failure () ()
v1_17 Rename `Sync2` -> `Sync` ()
v1_18 Refactor system setting () ()
v1_19 Rename `Sync2` -> `Sync` ()
v1_20 Rename `Sync2` -> `Sync` ()
v1_21 handle repository.size column being NULL in migration v263 () ()
migrations.go Add Index to `action.user_id` () ()