github-forks
/
gitea
mirror of https://github.com/go-gitea/gitea.git
1
0
Fork 0
Code Projects Releases Activity
gitea/models/issues
History
william-allspice e9c64f41a6
Distinguish official vs non-official reviews, add tool tips, and upgr… () 
This Pull Request is a follow up to
https://github.com/go-gitea/gitea/pull/31886:

1. Adds a UI indicator between official (green) and unofficial (grey)
approved pull requests on the Pull Request page (as suggested by
@kdumontnu )
2. Adds tooltips adding clarity to the type and status of a review on
the Pull Request page (as suggested by @kdumontnu)
3. Updates text adding more clarity to required approvals (as suggested
by @kdumontnu)
4. Updates text on the branch settings page explaining what branch
approval limitations (as suggested by @yp05327)

Official approval:
<img width="376" alt="Screenshot 2024-08-26 at 1 03 52 PM"
src="https://github.com/user-attachments/assets/500f083d-bfc0-45c5-82b7-b98e20495696">

Unofficial approval:
<img width="442" alt="Screenshot 2024-08-26 at 12 53 15 PM"
src="https://github.com/user-attachments/assets/e8c565ff-5886-4ce1-8b79-a0fa26c282f7">

Rejected approval:
<img width="452" alt="Screenshot 2024-08-26 at 12 53 06 PM"
src="https://github.com/user-attachments/assets/aebc0e2f-7052-4dea-8098-7caa0db86617">

Stale approval:
<img width="546" alt="Screenshot 2024-08-26 at 1 07 59 PM"
src="https://github.com/user-attachments/assets/da599ff3-e35c-4fa3-8141-ed80b738dd77">

Requested review tooltip:
<img width="434" alt="Screenshot 2024-08-26 at 12 53 22 PM"
src="https://github.com/user-attachments/assets/460d163e-8724-43b6-8760-34b285da8fe2">

Updated text for approvals:
<img width="991" alt="Screenshot 2024-08-26 at 12 54 00 PM"
src="https://github.com/user-attachments/assets/ab3ff012-9742-4c1b-933d-21addcb89f2c">

Updated text for allowlisted/whitelisted approvals:
<img width="990" alt="Screenshot 2024-08-26 at 1 01 40 PM"
src="https://github.com/user-attachments/assets/1a5bae61-d9e0-4d96-b86f-92610b0940d1">

Protected branch settings text:
<img width="1022" alt="Screenshot 2024-08-26 at 1 01 14 PM"
src="https://github.com/user-attachments/assets/892ce208-e1c2-41f7-8fec-46d5a0e7e776">

Comments list:
<img width="1048" alt="Screenshot 2024-08-28 at 9 25 31 AM"
src="https://github.com/user-attachments/assets/9c5c00c5-06cf-43b3-b413-4f7f673609b2">

---------

Co-authored-by: Kyle D. <kdumontnu@gmail.com>
..
assignees.go Performance improvements for pull request list API ()
assignees_test.go Remove deadcode under models/issues ()
comment.go Add issue comment when moving issues from one column to another of the project ()
comment_code.go Use repo as of renderctx's member rather than a repoPath on metas ()
comment_list.go Only update poster in issue/comment list if it has been loaded ()
comment_test.go More `db.DefaultContext` refactor ()
content_history.go Fix issue & comment history bugs ()
content_history_test.go Fix issue & comment history bugs ()
dependency.go Penultimate round of `db.DefaultContext` refactor ()
dependency_test.go Penultimate round of `db.DefaultContext` refactor ()
issue.go Performance improvements for pull request list API ()
issue_index.go Another round of `db.DefaultContext` refactor ()
issue_label.go Performance improvements for pull request list API ()
issue_label_test.go Penultimate round of `db.DefaultContext` refactor ()
issue_list.go Add issue comment when moving issues from one column to another of the project ()
issue_list_test.go Add context parameter to some database functions ()
issue_lock.go Penultimate round of `db.DefaultContext` refactor ()
issue_project.go Rename project board -> column to make the UI less confusing ()
issue_search.go Refactor issue label selection ()
issue_stats.go Use db.ListOptions directly instead of Paginator interface to make it easier to use and fix performance of /pulls and /issues ()
issue_test.go Allow non-admin users to delete review requests ()
issue_update.go Prevent simultaneous editing of comments and issues ()
issue_user.go Add combined index for issue_user.uid and issue_id ()
issue_user_test.go Fix bug with sqlite load read ()
issue_watch.go Even more `db.DefaultContext` refactor ()
issue_watch_test.go Next round of `db.DefaultContext` refactor ()
issue_xref.go Add user blocking ()
issue_xref_test.go Resolve lint for unused parameter and unnecessary type arguments ()
label.go Refactor issue label selection ()
label_test.go Optimization of labels handling in issue_search ()
main_test.go make writing main test easier ()
milestone.go remove util.OptionalBool and related functions ()
milestone_list.go Added default sorting milestones by name ()
milestone_test.go remove util.OptionalBool and related functions ()
pull.go Fix null requested_reviewer from API ()
pull_list.go Fix PullRequestList.GetIssueIDs's logic ()
pull_test.go Refactor StringsToInt64s ()
reaction.go Add container.FilterSlice function ()
review.go Distinguish official vs non-official reviews, add tool tips, and upgr… ()
review_list.go Fix null requested_reviewer from API ()
review_test.go Prevent re-review and dismiss review actions on closed and merged PRs ()
stopwatch.go Remove deadcode under models/issues ()
stopwatch_test.go Next round of `db.DefaultContext` refactor ()
tracked_time.go Update misspell to 0.5.1 and add `misspellings.csv` ()
tracked_time_test.go remove util.OptionalBool and related functions ()