You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

wxiaoguang d4f35bd681 Use a general approch to improve a11y for all checkboxes and dropdowns. (#23542) ... This PR follows #22599 and #23450 The major improvements: 1. The `aria-*.js` are totally transparent now, no need to call `attachDropdownAria` explicitly anymore. * It hooks the `$.fn.checkbox` and `$.fn.dropdown`, then our patch works. * It makes all dynamically generated checkbox/dropdown work with a11y without any change * eg: the `conversation.find('.dropdown').dropdown();` in `repo-diff.js` 2. Since it's totally transparent now, it could be easier to modify or remove in the future. 3. It handles all selection labels as well (by onLabelCreate), so it supports "multiple selection dropdown" now. * It partially completes one of my TODOs: `TODO: multiple selection is not supported yet.` 4. The code structure is clearer, code blocks are splitted into different functions. * The old `attachOneDropdownAria` was splitted into separate functions. * It makes it easier to add more fine tunes in the future, and co-work with contributors. 6. The code logic is similar as before, only two new parts: 1. the `ariaCheckboxFn` and `ariaDropdownFn` functions 2. the `onLabelCreate` and `updateSelectionLabel` functions In `aria-dropdown.js` I had to mix jQuery and Vanilla JS somewhat, I think the code is still understandable, otherwise the code would be much more complex to read. Thanks to fsologureng for the idea about "improving the 'delete icon' with aria attributes". If there is anything unclear or incorrect, feel free to ask and discuss, or propose new PRs for it.		2 years ago
..
components	Remove stars in dashboard repo list (#23530)	2 years ago
features	Use a general approch to improve a11y for all checkboxes and dropdowns. (#23542)	2 years ago
markup	update to mermaid v10 (#23178)	2 years ago
modules	Use a general approch to improve a11y for all checkboxes and dropdowns. (#23542)	2 years ago
standalone	Add new JS linter rules (#17699)	3 years ago
test	Use link in UI which returned a relative url but not html_url which contains an absolute url (#21986)	2 years ago
utils	Refactor branch/tag selector to Vue SFC (#23421)	2 years ago
webcomponents	Polyfill the window.customElements (#23592)	2 years ago
bootstrap.js	Quick fixes monaco-editor error: "vs.editor.nullLanguage" (#21734)	2 years ago
index.js	Use a general approch to improve a11y for all checkboxes and dropdowns. (#23542)	2 years ago
jquery.js	Upgrade jQuery to 3.5.0, remove jQuery-Migrate, fix deprecations (#11055)	5 years ago
serviceworker.js	Fix serviceworker output file and misc improvements (#11562)	5 years ago
svg.js	Refactor branch/tag selector to Vue SFC (#23421)	2 years ago
svg.test.js	Remove vitest globals (#21505)	2 years ago
utils.js	Scoped labels (#22585)	2 years ago
utils.test.js	Fix links for the menus in the view file page (#22795)	2 years ago