mirror of https://github.com/go-gitea/gitea.git
You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
17c5c654a5
* Prevent double-login for Git HTTP and LFS and simplify login There are a number of inconsistencies with our current methods for logging in for git and lfs. The first is that there is a double login process. This is particularly evident in 1.13 where there are no less than 4 hash checks for basic authentication due to the previous IsPasswordSet behaviour. This duplicated code had individual inconsistencies that were not helpful and caused confusion. This PR does the following: * Remove the specific login code from the git and lfs handlers except for the lfs special bearer token * Simplify the meaning of DisableBasicAuthentication to allow Token and Oauth2 sign-in. * The removal of the specific code from git and lfs means that these both now have the same login semantics and can - if not DisableBasicAuthentication - login from external services. Further it allows Oauth2 token authentication as per our standard mechanisms. * The change in the recovery handler prevents the service from re-attempting to login - primarily because this could easily cause a further panic and it is wasteful. * add test Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Andrew Thornton <art27@cantab.net> |
4 years ago | |
|---|---|---|
| .. | ||
| analyze | 4 years ago | |
| auth | 4 years ago | |
| avatar | 4 years ago | |
| base | 4 years ago | |
| cache | 4 years ago | |
| charset | 4 years ago | |
| context | 4 years ago | |
| convert | 4 years ago | |
| cron | 4 years ago | |
| csv | 4 years ago | |
| doctor | 4 years ago | |
| emoji | 4 years ago | |
| eventsource | 4 years ago | |
| generate | 4 years ago | |
| git | 4 years ago | |
| gitgraph | 4 years ago | |
| graceful | 4 years ago | |
| hcaptcha | 4 years ago | |
| highlight | 4 years ago | |
| httpcache | 4 years ago | |
| httplib | 4 years ago | |
| indexer | 4 years ago | |
| lfs | 4 years ago | |
| log | 4 years ago | |
| markup | 4 years ago | |
| matchlist | 4 years ago | |
| metrics | ||
| migrations | 4 years ago | |
| nosql | 4 years ago | |
| notification | 4 years ago | |
| options | 4 years ago | |
| password | 5 years ago | |
| pprof | ||
| private | 4 years ago | |
| process | 4 years ago | |
| public | 4 years ago | |
| queue | 4 years ago | |
| recaptcha | 4 years ago | |
| references | 4 years ago | |
| repofiles | 4 years ago | |
| repository | 4 years ago | |
| secret | 4 years ago | |
| session | 4 years ago | |
| setting | 4 years ago | |
| ssh | 4 years ago | |
| storage | 4 years ago | |
| structs | 4 years ago | |
| svg | ||
| sync | ||
| task | 4 years ago | |
| templates | 4 years ago | |
| test | 4 years ago | |
| timeutil | 4 years ago | |
| translation | 4 years ago | |
| upload | 4 years ago | |
| uri | 4 years ago | |
| user | ||
| util | 4 years ago | |
| validation | 4 years ago | |
| web | 4 years ago | |