You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
gitea/services
Jason Song 174213530d
Fix `Permission` in API returned repository struct (#25388)
The old code generates `structs.Repository.Permissions` with only
`access.Permission.AccessMode`, however, it should check the units too,
or the value could be incorrect. For example,
`structs.Repository.Permissions.Push` could be false even the doer has
write access to code unit.

Should fix
https://github.com/renovatebot/renovate/issues/14059#issuecomment-1047961128
(Not reported by it, I just found it when I was looking into this bug)

---

Review tips:

The major changes are
- `modules/structs/repo.go`
https://github.com/go-gitea/gitea/pull/25388/files#diff-870406f6857117f8b03611c43fca0ab9ed6d6e76a2d0069a7c1f17e8fa9092f7
- `services/convert/repository.go`
https://github.com/go-gitea/gitea/pull/25388/files#diff-7736f6d2ae894c9edb7729a80ab89aa183b888a26a811a0c1fdebd18726a7101

And other changes are passive.
2 years ago
..
actions Fix `Permission` in API returned repository struct (#25388) 2 years ago
agit Use the type RefName for all the needed places and fix pull mirror sync bugs (#24634) 2 years ago
asymkey Add context cache as a request level cache (#22294) 2 years ago
attachment Preserve file size when creating attachments (#23406) 2 years ago
auth Change default email domain for LDAP users (#25425) 2 years ago
automerge Improve queue and logger context (#24924) 2 years ago
context Decouple the different contexts from each other (#24786) 2 years ago
convert Fix `Permission` in API returned repository struct (#25388) 2 years ago
cron Use the new download domain replace the old (#25405) 2 years ago
externalaccount Implement FSFE REUSE for golang files (#21840) 2 years ago
forms Remove "CHARSET" config option for MySQL, always use "utf8mb4" (#25413) 2 years ago
gitdiff Show outdated comments in files changed tab (#24936) 2 years ago
issue Add codeowners feature (#24910) 2 years ago
lfs Move some regexp out of functions (#25430) 2 years ago
mailer Improve queue and logger context (#24924) 2 years ago
markup Decouple the different contexts from each other (#24786) 2 years ago
migrations Fix panic when migrating a repo from GitHub with issues (#25246) 2 years ago
mirror Use the type RefName for all the needed places and fix pull mirror sync bugs (#24634) 2 years ago
org Refactor rename user and rename organization (#24052) 2 years ago
packages Add CRAN package registry (#22331) 2 years ago
pull Add codeowners feature (#24910) 2 years ago
release Use the type RefName for all the needed places and fix pull mirror sync bugs (#24634) 2 years ago
repository Refactor web package and context package (#25298) 2 years ago
task Improve queue and logger context (#24924) 2 years ago
user Refactor rename user and rename organization (#24052) 2 years ago
webhook Fix `Permission` in API returned repository struct (#25388) 2 years ago
wiki Improve wiki user title test (#24559) 2 years ago