You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
wxiaoguang
1fcf96ad01
Improve PR Review Box UI (#22986)
This PR follows:
* #22950
### Before
The Review Box has many problems:
* It doesn't work for small screens.
* It has an anonying animation which makes the UI laggy.
* It uses "custom dropdown menu" which is very difficult to fine tune.
* `$().toggle('visible')` is not a correct call
* jQuery just accepts any invalid `duration` argument:
`$().toggle('anyting')`
* The button is not a button.
<details>
![image](https://user-images.githubusercontent.com/2114189/219948865-6da3f39c-6fde-4c86-9e42-da5020f3d0c3.png)
</details>
### After
These problems are fixed, and eliminate many `!important` games.
<details>
![image](https://user-images.githubusercontent.com/2114189/219952744-8862fe1a-7ef1-49e4-bf92-2d0c1f104ee4.png)
![image](https://user-images.githubusercontent.com/2114189/219952771-be169a76-45fd-47a8-8f9c-b447d064f4ca.png)
![image](https://user-images.githubusercontent.com/2114189/219952784-3f52e9b7-64ce-4ad1-9553-64c33fb83042.png)
</details>
And most dropdown icons still looks good:
<details>
![image](https://user-images.githubusercontent.com/2114189/219952942-52866a00-e0f9-4af7-8fb5-eb1a8cad1ff3.png)
![image](https://user-images.githubusercontent.com/2114189/219948909-b3bfb844-f84e-4b79-ab1f-382ec66dec31.png)
</details>
Co-authored-by: delvh <leon@kske.dev>
|
2 years ago |
.. |
admin
|
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)
|
2 years ago |
comp
|
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)
|
2 years ago |
aria.js
|
Add ARIA support for Fomantic UI checkboxes (#22599)
|
2 years ago |
aria.md
|
Improve frontend guidelines (#23007)
|
2 years ago |
captcha.js
|
Add new captcha: cloudflare turnstile (#22369)
|
2 years ago |
citation.js
|
…
|
|
clipboard.js
|
Use link in UI which returned a relative url but not html_url which contains an absolute url (#21986)
|
2 years ago |
codeeditor.js
|
…
|
|
colorpicker.js
|
JS refactors (#22227)
|
2 years ago |
common-global.js
|
Improve PR Review Box UI (#22986)
|
2 years ago |
common-issue.js
|
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)
|
2 years ago |
common-organization.js
|
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)
|
2 years ago |
contextpopup.js
|
JS refactors (#22227)
|
2 years ago |
copycontent.js
|
JS refactors (#22227)
|
2 years ago |
dropzone.js
|
JS refactors (#22227)
|
2 years ago |
emoji.js
|
JS refactors (#22227)
|
2 years ago |
eventsource.sharedworker.js
|
…
|
|
file-fold.js
|
JS refactors (#22227)
|
2 years ago |
formatting.js
|
JS refactors (#22227)
|
2 years ago |
heatmap.js
|
JS refactors (#22227)
|
2 years ago |
imagediff.js
|
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)
|
2 years ago |
install.js
|
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)
|
2 years ago |
notification.js
|
Move helpers to be prefixed with `gt-` (#22879)
|
2 years ago |
org-team.js
|
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)
|
2 years ago |
pull-view-file.js
|
…
|
|
repo-branch.js
|
…
|
|
repo-code.js
|
Fix links for the menus in the view file page (#22795)
|
2 years ago |
repo-code.test.js
|
…
|
|
repo-commit.js
|
Fix hidden commit status on multiple checks (#22889)
|
2 years ago |
repo-common.js
|
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)
|
2 years ago |
repo-diff-filetree.js
|
JS refactors (#22227)
|
2 years ago |
repo-diff.js
|
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)
|
2 years ago |
repo-editor.js
|
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)
|
2 years ago |
repo-findfile.js
|
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)
|
2 years ago |
repo-findfile.test.js
|
Escape path for the file list (#22741)
|
2 years ago |
repo-graph.js
|
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)
|
2 years ago |
repo-home.js
|
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)
|
2 years ago |
repo-issue-content.js
|
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)
|
2 years ago |
repo-issue-pr-form.js
|
JS refactors (#22227)
|
2 years ago |
repo-issue.js
|
Improve PR Review Box UI (#22986)
|
2 years ago |
repo-legacy.js
|
Remove unnecessary and incorrect `find('.menu').toggle()` (#22987)
|
2 years ago |
repo-migrate.js
|
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)
|
2 years ago |
repo-migration.js
|
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)
|
2 years ago |
repo-projects.js
|
Scoped labels (#22585)
|
2 years ago |
repo-release.js
|
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)
|
2 years ago |
repo-settings.js
|
…
|
|
repo-template.js
|
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)
|
2 years ago |
repo-unicode-escape.js
|
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)
|
2 years ago |
repo-wiki.js
|
…
|
|
serviceworker.js
|
JS refactors (#22227)
|
2 years ago |
sshkey-helper.js
|
…
|
|
stopwatch.js
|
Move helpers to be prefixed with `gt-` (#22879)
|
2 years ago |
tablesort.js
|
JS refactors (#22227)
|
2 years ago |
tribute.js
|
JS refactors (#22227)
|
2 years ago |
user-auth-webauthn.js
|
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)
|
2 years ago |
user-auth.js
|
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)
|
2 years ago |
user-settings.js
|
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)
|
2 years ago |