mirror of https://github.com/go-gitea/gitea.git
You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Follow: * #22697 There are some bugs in #22697: * https://github.com/go-gitea/gitea/pull/22697#issuecomment-1577957966 * the webauthn failure message is never shown and causes console error * The `document.getElementById('register-button')` and `document.getElementById('login-button')` is wrong * there is no such element in code * it causes JS error when a browser doesn't provide webauthn * the end user can't see the real error message These bugs are fixed in this PR. Other changes: * Use simple HTML/CSS layouts, no need to use too many `gt-` patches * Make the webauthn page have correct "page-content" layout * The "data-webauthn-error-msg" elements are only used to provide locale texts, so move them into a single "gt-hidden", then no need to repeat a lot of "gt-hidden" in code * The `{{.CsrfTokenHtml}}` is a no-op because there is no form * Many `hideElem('#webauthn-error')` in code is no-op because the `webauthn-error` already has "gt-hidden" by default * Make the tests for "URLEncodedBase64" really test with concrete cases. Screenshots: * Error message when webauthn fails (before, there is no error message): <details>  </details> * Error message when webauthn is unavailable <details>  </details> |
2 years ago | |
---|---|---|
.. | ||
activate.tmpl | 2 years ago | |
captcha.tmpl | 2 years ago | |
change_passwd.tmpl | 2 years ago | |
change_passwd_inner.tmpl | 3 years ago | |
finalize_openid.tmpl | 2 years ago | |
forgot_passwd.tmpl | 2 years ago | |
grant.tmpl | 2 years ago | |
grant_error.tmpl | 2 years ago | |
link_account.tmpl | 2 years ago | |
oidc_wellknown.tmpl | 3 years ago | |
prohibit_login.tmpl | 2 years ago | |
reset_passwd.tmpl | 2 years ago | |
signin.tmpl | 2 years ago | |
signin_inner.tmpl | 2 years ago | |
signin_navbar.tmpl | 2 years ago | |
signin_openid.tmpl | 2 years ago | |
signup.tmpl | 2 years ago | |
signup_inner.tmpl | 2 years ago | |
signup_openid_connect.tmpl | 2 years ago | |
signup_openid_navbar.tmpl | 2 years ago | |
signup_openid_register.tmpl | 2 years ago | |
twofa.tmpl | 2 years ago | |
twofa_scratch.tmpl | 2 years ago | |
webauthn.tmpl | 2 years ago | |
webauthn_error.tmpl | 2 years ago |