22 Commits (6b0df6d8da76d77a9b5c42dcfa78dbfe197fd56d)

Author	SHA1	Message	Date
wxiaoguang	f4538791f5	Refactor internal API for git commands, use meaningful messages instead of "Internal Server Error" (#23687) ... # Why this PR comes At first, I'd like to help users like #23636 (there are a lot) The unclear "Internal Server Error" is quite anonying, scare users, frustrate contributors, nobody knows what happens. So, it's always good to provide meaningful messages to end users (of course, do not leak sensitive information). When I started working on the "response message to end users", I found that the related code has a lot of technical debt. A lot of copy&paste code, unclear fields and usages. So I think it's good to make everything clear. # Tech Backgrounds Gitea has many sub-commands, some are used by admins, some are used by SSH servers or Git Hooks. Many sub-commands use "internal API" to communicate with Gitea web server. Before, Gitea server always use `StatusCode + Json "err" field` to return messages. * The CLI sub-commands: they expect to show all error related messages to site admin * The Serv/Hook sub-commands (for git clients): they could only show safe messages to end users, the error log could only be recorded by "SSHLog" to Gitea web server. In the old design, it assumes that: * If the StatusCode is 500 (in some functions), then the "err" field is error log, shouldn't be exposed to git client. * If the StatusCode is 40x, then the "err" field could be exposed. And some functions always read the "err" no matter what the StatusCode is. The old code is not strict, and it's difficult to distinguish the messages clearly and then output them correctly. # This PR To help to remove duplicate code and make everything clear, this PR introduces `ResponseExtra` and `requestJSONResp`. * `ResponseExtra` is a struct which contains "extra" information of a internal API response, including StatusCode, UserMsg, Error * `requestJSONResp` is a generic function which can be used for all cases to help to simplify the calls. * Remove all `map["err"]`, always use `private.Response{Err}` to construct error messages. * User messages and error messages are separated clearly, the `fail` and `handleCliResponseExtra` will output correct messages. * Replace all `Internal Server Error` messages with meaningful (still safe) messages. This PR saves more than 300 lines, while makes the git client messages more clear. Many gitea-serv/git-hook related essential functions are covered by tests. --------- Co-authored-by: delvh <dev.lh@web.de>	2 years ago
flynnnnnnnnnn	e81ccc406b	Implement FSFE REUSE for golang files (#21840) ... Change all license headers to comply with REUSE specification. Fix #16132 Co-authored-by: flynnnnnnnnnn <flynnnnnnnnnn@github> Co-authored-by: John Olheiser <john.olheiser@gmail.com>	2 years ago
Gusted	6c0fe1f3ec	refactor httplib (#18338) ... - Remove a lot of unused code(most if not all were introduced in gogs for webhooks usages). Co-authored-by: techknowlogick <techknowlogick@gitea.io>	3 years ago
Eng Zer Jun	f2e7d5477f	refactor: move from io/ioutil to io and os package (#17109) ... The io/ioutil package has been deprecated as of Go 1.16, see https://golang.org/doc/go1.16#ioutil. This commit replaces the existing io/ioutil functions with their new definitions in io and os packages. Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> Co-authored-by: techknowlogick <techknowlogick@gitea.io>	3 years ago
Lunny Xiao	9f31f3aa8a	Add an abstract json layout to make it's easier to change json library (#16528) ... * Add an abstract json layout to make it's easier to change json library * Fix import * Fix import sequence * Fix blank lines * Fix blank lines	4 years ago
zeripath	3dcb3e9073	Second attempt at preventing zombies (#16326) ... * Second attempt at preventing zombies * Ensure that the pipes are closed in ssh.go * Ensure that a cancellable context is passed up in cmd/* http requests * Make cmd.fail return properly so defers are obeyed * Ensure that something is sent to stdout in case of blocks here Signed-off-by: Andrew Thornton <art27@cantab.net> * placate lint Signed-off-by: Andrew Thornton <art27@cantab.net> * placate lint 2 Signed-off-by: Andrew Thornton <art27@cantab.net> * placate lint 3 Signed-off-by: Andrew Thornton <art27@cantab.net> * fixup Signed-off-by: Andrew Thornton <art27@cantab.net> * Apply suggestions from code review Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: Lauris BH <lauris@nix.lv>	4 years ago
Lunny Xiao	3d5bb3e6a3	fix webhook timeout bug (#15613) ... * Also fix the potential problem in httplib	4 years ago
zeripath	f0e15250b9	Migrate to use jsoniter instead of encoding/json (#14841) ... * Migrate to use jsoniter * fix tests * update gitea.com/go-chi/binding Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: 6543 <6543@obermui.de>	4 years ago
kolaente	f9ec2f89f2	Add golangci (#6418)	6 years ago
Antoine GIRARD	b3fd94c13d	Add sensitive headers (#3429) ... * Add HeaderWithSensitiveCase methods to respect casing * Update webhook.go	7 years ago
Sandro Santilli	00d08473b8	Use GiteaServer as the user agent for http requests (#3404) ... Otherwise we're still presenting ourselves as GogsServer...	7 years ago
Lunny Xiao	2eeae84cbd	Add internal routes for ssh hook comands (#1471) ... * add internal routes for ssh hook comands * fix lint * add comment on why package named private not internal but the route name is internal * add comment above package private why package named private not internal but the route name is internal * remove exp time on internal access * move routes from /internal to /api/internal * add comment and defer on UpdatePublicKeyUpdated	8 years ago
Ethan Koenig	021904e4e6	Fix typos in models/ and modules/ (#1248)	8 years ago
Schwobaland	2f7dc28b22	add ProxyFromEnvironment if none set (#1096)	8 years ago
Lunny Xiao	bd5ea3e222	Golint fixed for modules/httplib	8 years ago
Unknwon	de3be370f7	Remove unused tests ... Module httplib will be replaced a well done third-party package soon, so remove its unused tests	9 years ago
Unknwon	b9f5def5dc	fix insecure tls when trigger task	9 years ago
Unknwon	23f42d92c9	add webhook recent deliveries	10 years ago
Unknwon	ce8d4cc80b	#634	10 years ago
Unknwon	97a373f5e7	Fix #362, update code with upstream	11 years ago
Unknwon	9a1d5d2489	Finish new web hook pages	11 years ago
Unknown	e573855a4f	Fix #98, support web hook	11 years ago