github-forks
/
gitea
mirror of https://github.com/go-gitea/gitea.git
1
0
Fork 0
Code Projects Releases Activity
6,928 Commits
17 Branches
226 Tags
815 MiB
Commit Graph

2094 Commits (4a685f8b872a3d4c101c5e8165fa99e696c8fb45)

Author SHA1 Message Date
Andrew 3f67676059 Implement basic Open Graph support. ()
Lunny Xiao 8a0be5e9f0 Bug fixed for deleted label in issue comment () 
* bug fixed for deleted label in issue comment

* fix indent
Morgan Bazalgette 442145dbd3 Fix public activity showing private repos () 
* Fix public activity showing private repos ()

Signed-off-by: Morgan Bazalgette <the@howl.moe>

* error check after setting is_private to true

* Add test for UpdateRepository w/ visibility change
Andrew 42835c7f82 Implement archive cleanup () 
* Implement archive cleanup

Fixes 

Signed-off-by: Andrew <write@imaginarycode.com>

* Make sure to close the directory file

* Resolve issues noted by @strk

* edit cheatsheet app.ini [ci skip]

* oops [ci skip]
Lunny Xiao cf0f451c37 Add delete branch track on pull request comments () 
* add delete branch track on pull request comments

* don't change vendor
Lunny Xiao b6dd6210ea bug fixed for issue count ()
Ethan Koenig a6751cec04 Unit tests for issue_milestone ()
Ethan Koenig 13973348df Gogs -> Gitea ()
Ethan Koenig e6b4448ba3 Fix bug in Issue.GetIsRead ()
Ethan Koenig 181c8d9c99 Fix consistency check ()
Ethan Koenig d2329e1c26 Use assert in legacy unit tests ()
Ethan Koenig 5fbab97373 Fix broken test fixture ()
Bo-Yi Wu b13232f524 feat: support paginater on star tab of user profile. ()
Ethan Koenig ceae143e78 Consistency checks for unit tests ()
Bo-Yi Wu 71d35dae8c fix: wrong pages number which includes private repository count. ()
Ethan Koenig 438e1a7d46 Fix inconsistencies in unit test fixtures
Lunny Xiao f35b20b042 track issue title changes ()
Ethan Koenig 027591a3a5 Redirects for renamed repos () 
* Redirects for renamed repos

* Remove unused phrase from locales
Bwko bf647ce143 Check for manual merging of a pull request () 
When an open pull request got manually merged mark the pull request as
merged
Andrey Nering 7c3dc51655 Merge pull request from ethantkoenig/fix/remove_org_repo 
Fix bug in removeOrgRepo
Ethan Koenig f82ea42679 Fix bug in removeOrgRepo
Ethan Koenig 5972aa9af3 Fix inconsistencies in test fixtures
Lunny Xiao 8a421b1fd7 Add units concept for modulable functions of a repository () 
* Add units concept for modulable functions of a repository

* remove unused comment codes & fix lints and tests

* remove unused comment codes

* use struct config instead of map

* fix lint

* rm wrong files

* fix tests
Ethan Koenig d0960b8035 Move IssueUser code to separate file () 
Also add unit tests
Andrey Nering d4035d1cb1 Merge pull request from appleboy/patch-2001 
refactor: set default order by recently star on start tab
Bo-Yi Wu a90a215662 feat: Add search bar on user profile page. ()
Bo-Yi Wu b6da658553 test: Add user mail testing. ()
Lunny Xiao 3e0525b47d Track assignee for issue () 
* track assignee for issue

* fix lint

* use getUserByID instead Get
Ethan Koenig 68bdaf0a6b Drop redundant columns from issue_user table ()
Bo-Yi Wu e2de16065a refactor: set default order by recently star.
Gabriel Jackson bf6f61cc69 Cleanup log messaging 
This change corrects a few logging issues:

 * Standardized formatting errors with '%v'.
 * Standardized failure warning word usage.
 * Corrected an instance of using the standard log library when
   the gitea log library should be used instead.
Bo-Yi Wu d7d094bd8a fix: ignore email notifications if user is not active. ()
Anton Skorokhod 79ab69fe30 Add X-GitHub-* headers for webhook to get clubhouse.io integration working ()
Lunny Xiao 081485ecfd add milestone changed traker on issue view ()
Ethan Koenig 10644d6dd7 Bug fixes and unit tests for models/issue_label ()
Ethan Koenig 0a02fb3c4f Windows compatibility for unit tests ()
Ethan Koenig 2eb15f4a61 Unit tests and remove unused functions in models/notification () 
* Unit tests and remove unused functions in models/notification

* Read -> Unread
Lunny Xiao f94869d2d1 Track labels changed on issue view & resolved () 
* track labels changed on issue view & resolved 

* add missing head comment & sort & fix refresh
Ethan Koenig 7765593018 Better settings for unit tests ()
Thomas Boerger 78535fb08e Allow custom public files () 
* Allow custom public files

* Gofmt code, lots of places not related to this pr
Andrey Nering cc31a21192 Merge pull request from andreynering/notifications-step-5 
Notifications step 5
Andrey Nering 5348e8b71a Fix color: closed PR was showing as purple instead of red
Andrey Nering 31c717f579 Merge pull request from ethantkoenig/tests/wiki 
Unit tests for models/wiki
Ethan Koenig bb76285762 Unit tests for models/wiki
Ethan Koenig a2412492da Unit tests and bug fix for models/org
Lunny Xiao bb5a6b7a07 fix xorm NewSession uncorrected usages ()
Bo-Yi Wu 25663b5816 refactor: Remove unnecessary type conversions ()
Ethan Koenig da1b6164fe Fix FIXME and remove superfluous queries in models/org ()
Bo-Yi Wu 691fbdf1d3 fix: delete attachment after remove comment.
Ethan Koenig 0934d1b1ea Bug fixes and unit tests for models/webhook ()
Ethan Koenig a6832c234d Unit tests for models/star ()
Lunny Xiao 8c2381103a bug fixed issues 500 resolved ()
Ethan Koenig 8093b3372e Less boilerplate in models/ unit tests ()
Ethan Koenig 833f8b94c2 Search bar for issues/pulls ()
Andrey Nering 521d429b58 Fix link of some repos on stars page () 
Link was wrong the repo was of another owner
Bwko 74ed6dc3ad Add option to app.ini to enable local import paths ()
Bwko 1257d43e14 Add a reserved path check to the wiki ()
Lunny Xiao f8c2903484 fixed bugs on Wiki and resolved ()
Philip Couling 1610b9f547 Spun attachments into seperate go file () 
Moved attachments into seperate go file
Ethan Koenig 74bbec3bf9 Fix permission bugs in team API ()
Ethan Koenig fcf02e4961 API Endpoints for organization members ()
Matthias Loibl d1006150fb Refactor process package and introduce ProcessManager{} with tests () 
* Add a process.Manager singleton with process.GetManager()

* Use process.GetManager everywhere

* Fix godoc comments for process module

* Increment process counter id after locking the mutex
Andrew 6dd096b7f0 Two factor authentication support () 
* Initial commit for 2FA support

Signed-off-by: Andrew <write@imaginarycode.com>

* Add vendored files

* Add missing depends

* A few clean ups

* Added improvements, proper encryption

* Better encryption key

* Simplify "key" generation

* Make 2FA enrollment page more robust

* Fix typo

* Rename twofa/2FA to TwoFactor

* UNIQUE INDEX -> UNIQUE
Philip Couling 64375d875b Attach to release () 
* Moved attachaments POST url from /issues/attachments to /attachments

* Implemented attachment upload on release page

* Implemented downloading attachments on the release page

* Added zip and gzip files to default allowed attachments

* Implemented uploading attachments on edit release

* Renamed UploadIssueAttachment to UploadAttachment
btrepp 302fa42980 Removes reliance on server specific SQL () 
Breaks the retrieval of repositories into two queries
This fetches the paged ids in one go, then the
actual repository information in a second query

Some databases do not support SELECT with *
when group by is used.
Ethan Koenig a6f5efa0bb Fix ambiguity bug in getCommentsByRepoIDSince ()
Ethan Koenig 27fcf8d30a Bug fixes for webhook API ()
Lunny Xiao 87ad4961f6 bug fixed for update repository ()
Andrey Nering 769e0a3ea6 Notifications: mark as read/unread and pin () 
* Use relative URLs

* Notifications - Mark as read/unread

* Feature of pinning a notification

* On view issue, do not mark as read a pinned notification
Bo-Yi Wu cbf2a967c5 refactor: Add new deleteOrg func. ()
Ethan Koenig b316b2e740 Unit tests for models/admin
Ethan Koenig 973282dae2 Better coverage in pull_test ()
Ethan Koenig 862948ab88 Better coverage and TODOs for update_test ()
Ethan Koenig 4b23e6a694 Unit tests for models/action ()
derSuessmann 51d578ff33 Add Keep email private (see issue ). () 
- Add site-wide option DEFAULT_KEEP_EMAIL_PRIVATE.
- Add the new option to the install and admin/config pages.
- Add the new option to app.ini in the service section.
- Add the new option to the settings struct.
- Add English text strings to i18n.
- Add field KeepEmailPrivate to user struct.
- Add field KeepEmailPrivate to user form.
- Add option to UI.
- Add using noreply email address if user has "Keep Email Private".
An email address <LowerName>@<NO_REPLY_ADDRESS> is now used in commit
messages (and hopefully all other git log relevant places). The
change relies on the fact that git commands should use
user.NetGitSig().
- Add hiding of email address in UI, if user has set "Keep Email Private".
- Add condition to show email address only on explore/users and user
pages, if user has not set "Keep Email Private".
- Add noreply email in API if set "Keep Email Private".
- Add a new service setting NO_REPLY_ADDRESS. The value of this
setting is used as the domain part for the user's email address in
git log, iff he decides to keep his email address private.
If the user decides to keep his email address private and this
option is not set 'noreply.example.org' is used, which no MTA
should send email to.

Add NO_REPLY_ADDRESS to conf/app.ini.
Ethan Koenig 6072b03291 Unit tests for models/access.go ()
Ethan Koenig 8422ab542c API endpoint for subscribers ()
Andrey Nering 03b45284e1 Merge pull request from ethantkoenig/tests/pull 
Unit tests for models/pull.go
Andrey Nering 84b7d29d34 Create missing database indexes ()
Ethan Koenig 72bfabfada Unit tests for models/pull.go
Ethan Koenig 1a7fc53c98 API endpoint for stargazers ()
Lunny Xiao 61306fa737 Make releases faster than before and resolved () 
* make releases faster than before and resolved 

* fix comment
Andrey Nering 79d527195d Merge pull request from andreynering/notifications-step-2 
Notifications - Step 2
Ethan Koenig c5f0d4b1a0 Fix SQL bug in models/access () 
Previously got a 'relation repo_access does not exist' error in User_GetRepositoryAccesses
Berk Demirkır bdad3b259a Check primary email address fields on CreateUser () 
* Check primary email address fields on CreateUser

As this check wasn't available, uid=1 (and possibly guests too, if registration is open) is able to register new users with existing email addresses. This leads to numerous 500 errors.

* Update user.go

* Lower the email first. Then check
Ethan Koenig 1207bda94b Fix typos in models/ ()
Andrey Nering b354cf362e Add pagination for notifications
Lunny Xiao 09dabe2ff2 fix bug ()
Lunny Xiao 980dd0bf51 Update xorm and dependencies vendor for feature to dump to other database () 
* update xorm and dependencies vendor for feature to dump to other database

* fix golint
Kjell Kvinge 4b0974ec10 Fix benchmarktests ()
Lunny Xiao 3c7116382f change the default action when deleting a release to not delete tag
Ethan Koenig 0c301f7b5c Release API endpoints
Lunny Xiao 6e5fffbd3f resolved : when migrate empty wiki repo, then ignore ()
Ethan Koenig de8b73dd92 Unit tests for token and update models
Schwobaland c0904f1942 Restrict creating organisations by user () 
* restrict creating organizations based on right on user

* revert bindata.go

* reverse vendor lib

* revert goimports change

* set AllowCreateOrganization default value to true

* revert locale

* added default value for AllowCreateOrganization

* fix typo in migration-comment

* fix comment

* add coments in migration
Bo-Yi Wu 6510e57758 fix gofmt error 
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
Andrey Nering 42904cb98a Notification - Step 1 () 
* Notification - Step 1

* Add copyright headers

* Cache issue and repository on notification model
typeless 937b4b5aa1 Speed up conflict checking in pull request creation () 
* Speed up conflict checking in pull request creation

In order to check conflicts of a PR, we set up a working tree by
cloning the base branch, which is quite time-consuming when the repository is huge.
Instead, this PR uses `git read-tree` and `git apply --check --cached` to check conflicts.

For 

* Use $GIT_INDEX_FILE instead of --index-output to avoid lockfile problem

The lockfile gets renamed to the final destination after the operation
finishes. But it must be located in the same filesystem, which prevents
us from using /tmp.

* Temporary file names should not prefixed with '-'
Andrey Nering b992858883 Tab on user profile to show starred repos () 
* Tab on user profile to show starred repos

* Make golint happy and use transactions on StarRepo function

* x -> sess

* Use sess.Close() instead of sess.Rollback()

* Add copyright

* Fix lint
Lunny Xiao 799d0c2030 slight optimization for GetUserRepositories ()
Kjell Kvinge 22e1bd31c6 commithgraph / timeline () 
* Add model and tests for graph

* Add route and router for graph

* Add assets for graph

* Add template for graph
Bwko 331316894e Replace Gogs with Gitea ()
Lunny Xiao c463b1b8cb Optimization for user.GetRepositoryAccesses to reduce db query times () 
* optimization for user.GetRepositoryAccesses to reduce db query times

* fix missing cache
Lunny Xiao ba134bd27a fix 500 when delete orgnization and resolved
Ethan Koenig 2342df183b API Endpoints for collaborators ()
Fabian Zaremba 2e7ccecfe6 Git LFS support v2 () 
* Import github.com/git-lfs/lfs-test-server as lfs module base

Imported commit is 3968aac269a77b73924649b9412ae03f7ccd3198

Removed:

Dockerfile CONTRIBUTING.md mgmt* script/ vendor/ kvlogger.go
.dockerignore .gitignore README.md

* Remove config, add JWT support from github.com/mgit-at/lfs-test-server

Imported commit f0cdcc5a01599c5a955dc1bbf683bb4acecdba83

* Add LFS settings

* Add LFS meta object model

* Add LFS routes and initialization

* Import github.com/dgrijalva/jwt-go into vendor/

* Adapt LFS module: handlers, routing, meta store

* Move LFS routes to /user/repo/info/lfs/*

* Add request header checks to LFS BatchHandler / PostHandler

* Implement LFS basic authentication

* Rework JWT secret generation / load

* Implement LFS SSH token authentication with JWT

Specification: https://github.com/github/git-lfs/tree/master/docs/api

* Integrate LFS settings into install process

* Remove LFS objects when repository is deleted

Only removes objects from content store when deleted repo is the only
referencing repository

* Make LFS module stateless

Fixes bug where LFS would not work after installation without
restarting Gitea

* Change 500 'Internal Server Error' to 400 'Bad Request'

* Change sql query to xorm call

* Remove unneeded type from LFS module

* Change internal imports to code.gitea.io/gitea/

* Add Gitea authors copyright

* Change basic auth realm to "gitea-lfs"

* Add unique indexes to LFS model

* Use xorm count function in LFS check on repository delete

* Return io.ReadCloser from content store and close after usage

* Add LFS info to runWeb()

* Export LFS content store base path

* LFS file download from UI

* Work around git-lfs client issue with unauthenticated requests

Returning a dummy Authorization header for unauthenticated requests
lets git-lfs client skip asking for auth credentials
See: https://github.com/github/git-lfs/issues/1088

* Fix unauthenticated UI downloads from public repositories

* Authentication check order, Finish LFS file view logic

* Ignore LFS hooks if installed for current OS user

Fixes Gitea UI actions for repositories tracking LFS files.
Checks for minimum needed git version by parsing the semantic version
string.

* Hide LFS metafile diff from commit view, marking as binary

* Show LFS notice if file in commit view is tracked

* Add notbefore/nbf JWT claim

* Correct lint suggestions - comments for structs and functions

- Add comments to LFS model
- Function comment for GetRandomBytesAsBase64
- LFS server function comments and lint variable suggestion

* Move secret generation code out of conditional

Ensures no LFS code may run with an empty secret

* Do not hand out JWT tokens if LFS server support is disabled
Philip Couling d4924d45d6 Implement sendmail () 
* Implemented sendmail. This piggybacks on existing configuration to keep the change simple

* Changed privicy of new sendSMTP and sendSendmail functions

* Fixed Lint errors

* Seperated SMTP and sendmail into their own senders

* Making new structs private as they should not be used externally now

* Added sendmail setting to ini file

* Minor code cleanup
Bwko fa3abc22c0 Added sorting to organizations, repos & users page ()
Bwko a345a03d99 Added sorting to the labels & milestones page ()
Ethan Koenig d0932ef147 Bug fixes for Issues filters () 
Correctly handle simultaneous assignee/poster filters, and conflicting assignee filters
Ethan Koenig 8a4161c723 API Endpoint for watching ()
btrepp 25b5ffb6af Enables mssql support () 
* Enables mssql support

Port of dlobs work in gogs.
Enables options in index.js
Enables MSSQL as a database option in go.
Sets ID to 0 on initial migration. Required for
MSSQL insert statements.

Signed-off-by: Beau Trepp <beautrepp@gmail.com>

* Vendors in denisenkom/go-mssqldb

Includes golang.org/x/crypto/md4
as this is required by go-msssqldb

Signed-off-by: Beau Trepp <beautrepp@gmail.com>
Lunny Xiao a822bba3e1 Add default values for settings () 
* add default values for settings

* more default values

* more default settings and labels resource

* mv locale to options
Thomas Boerger b33078fa33 Bindata is optional and over-writable on restart () 
* Moved conf assets into options folder

* Dropped old bindata

* Started to integrate options bindata and accessors

* Do not enforce a builtin app.ini

* Replaced bindata calls with options

* Dropped bindata task from makefile, it's the generate task now

* Always embedd app.ini to provide sane config defaults

* Use sane defaults for the configuration

* Defined default value for SSH_KEYGEN_PATH

* Dropped "NEVER EVER MODIFY THIS FILE" header from app.ini

* Fixed new paths in latest test additions

* Drop bindata with make clean task

* Set more proper default values
Lunny Xiao c21e2c4151 fix tag webhook 404 error ()
Lunny Xiao 47a7529d96 update code.gitea.io/git ()
Lunny Xiao 0c5c34d7dd UpdateIssueUsersByMentions was calling database write operations while () 
a transaction session was in progress. MailParticipants was failing
silently because of the SQLITE_LOCKED error. Make sure failures in
MailParticipants enter the log, and pass on the transaction context.

issue: let caller pass in database context, and use it
issue_comment: obtain database context to pass to UpdateIssueMentions
issue_comment: log any error from call to MailParticipants
issue_mail: pass on database context to UpdateIssueMentions
Ethan Koenig 4c89a9c33c Bug fixes and tests for modules/base () 
Also address other TODOs
Kim "BKC" Carlbäcker df7fa4e995 issue comment api fix () 
* ListAllInRepo & Delete Issue-Comments

* Moar data in issue-comments
Alexander Lunegov d5d21b67d2 Fix string format verbs ()
Denis Denisov 380e32e129 Fix random string generator () 
* Remove unused custom-alphabet feature of random string generator

Fix random string generator

Random string generator should return error if it fails to read random data via crypto/rand

* Fixes variable (un)initialization mixed assign
Update test GetRandomString
Michael de Wit 1d30457a94 change test mail subject and body to 'Gitea Test Mail!' 
Signed-off-by: Michael de Wit <mjwwit@gmail.com>
Lunny Xiao 7c46667e71 fixed vulnerabilities labels ()
Richie B2B 44428fdc38 Remove fixed FIXME ()
Richie B2B 0d6e88baef Fix typo ()
Lunny Xiao 15c3d14d55 fixed vulnerabilities on deleting release ()
Lunny Xiao b4c794058a fixed vulnerabilities ()
Lunny Xiao d771e978a1 Don't use custom PBKDF2 function ()
Lunny Xiao 73710c00a8 bug fixed branch name for pushupdate ()
Denis Denisov f0a989c1d0 Correction LDAP validation () 
* Correction LDAP username validation

As https://msdn.microsoft.com/en-us/library/aa366101(v=vs.85).aspx describe spaces should not be in start or at the end of username but they can be inside the username. So please check my solution for it.

* Check for zero length passwords in LDAP module.

According to https://tools.ietf.org/search/rfc4513#section-5.1.2 LDAP client should always check before bind whether a password is an empty value. There are at least one LDAP implementation which does not return error if you try to bind with DN set and empty password - AD.

* Clearing the login/email spaces at the [start/end]
Bwko abcd39f7d5 In the wiki title replace tab with a space ()
Bwko cbcb4361d5 Fixes issue 
Delete old temp local copy before we create a new temp local copy
Ethan Koenig 401a8db0ed Remove stale comment in models/repo.go ()
Ethan Koenig 04b9a7e7a2 Bug fixes for repo permissions in API 
Also move duplicated code into repo.APIFormat(..)
Thomas Boerger 83ed234472 Integrate templates into bindata optionally () 
Integrated optional bindata for the templates
Kim "BKC" Carlbäcker d07c955e2a Fix regression in PR-API () 
* Fix  (regression in PR-API )
Bwko 0118b275b6 Fix for 
Suppress the error when we're removing a file that may not exist
Denis Denisov c8f300b2cd Safe compare password (timing attack) ()
Kim "BKC" Carlbäcker 0f05470cb8 [API] Pull Requests ()
Kim "BKC" Carlbäcker e8e0539b45 Linting
Kim "BKC" Carlbäcker e6cfccdd40 GitHub API Compliance (& linting)
Bwko 4ff0db0246 Catch os... errors
Bwko 5ab85372da Added rel="noopener" to target="_blank" hrefs () 
* Added rel="noopener" to target="_blank" hrefs

* Replaced gogs.io/docs with docs.gitea.io
Lunny Xiao 646e02b521 typo
Thomas Boerger 6dd2c3b2db
Fixed linting errors for variable definitions
Kim "BKC" Carlbäcker 42ec5ce740 Fix breakage from vendor-update
Kim "BKC" Carlbäcker dad806d3ea CreateBranch-hook has shasum. Use the full ref for fetching shasum
Kim "BKC" Carlbäcker f364522468 Tag-webhooks are useless without shasums
Andrey Nering fd53028139 Merge pull request from Bwko/Lint/user.go 
Lint models/user.go
Bwko bad1bc6518 Lint models/repo.go
Bwko a5aae1c145 Lint models/repo_*
Bwko 9963d61233 Lint models/user.go
Lunny Xiao 27d66855eb golint fixed for models/migrations ()
Lunny Xiao 1d0f811399 golint fixed for models/pull.go ()
Lunny Xiao 9fc609ce17 golint fixed for models/issue_comment.go
Thomas Boerger 9948f0daaa Merge pull request from lunny/lunny/golint_models_org_team 
Golint for models/org_team.go
Lunny Xiao f215d78157 rename all uID -> userID on models/org_team.go
Lunny Xiao bf8d90c5cc golint fixed for models/models.go ()
Lunny Xiao 21846d16e5 golint for models/org_team.go
Lunny Xiao ec87a75c00 golint fixed for modules/auth
Bwko a4ece1f223 Fixes typos
Thomas Boerger 5efdccd1d8 Merge pull request from Bwko/lint/org.go 
Lint models/org.go
Thomas Boerger 9a984c0d49 Merge pull request from Bwko/lint/repo_mirror 
Lint models/repo_mirror.go
Thomas Boerger fe3908d099 Merge pull request from Bwko/lint/repo_branch 
Lint models/repo_branch.go
Thomas Boerger e23a9d22e5 Merge pull request from Bwko/lint/ssh_key 
Lint models/ssh_key.go
Thomas Boerger 93d527a0a4 Merge pull request from Bwko/lint/access.go 
Lint models/access.go
Thomas Boerger 8347a55cc2 Merge pull request from Bwko/lint/user_email 
Lint models/user_email.go
Lunny Xiao 94da472717 Golint fixed for modules/setting () 
* golint fixed for modules/setting

* typo fixed and renamed UNIXSOCKET to UnixSocket
Bwko 0b9cf10340 Lint models/org.go & models.go
Bwko 7bf7042013 Lint models/repo_mirror.go
Bwko ce8c9ef580 Lint models/repo_branch.go
Bwko 6cde041080 Lint models/ssh_key.go
Bwko 2bb1601d7c Lint models/access.go
Bwko 066f515a47 Lint models/user_email.go
Thomas Boerger 574e49c854 Merge pull request from Bwko/lint/admin.go 
Lint models/admin.go
Thomas Boerger 21b7d30174 Merge pull request from Bwko/lint/update&slack 
Lint models/update.go, release.go & webhook_slack.go
Thomas Boerger e9c6053b86 Merge pull request from Bwko/fix/typo 
Fix typos
Thomas Boerger 3e6f363471 Merge pull request from lunny/lunny/golint_modules_avatar 
Golint fixed for modules/avatar
Thomas Boerger 7c5de1e393 Merge pull request from lunny/lunny/golint_modules_markdown 
Golint fixed for modules/markdown
Lunny Xiao 3c87c57d96 golint fixed for modules/avatar
Bwko c0ca6644ad Lint/issue &mail () 
* Lint models/release.go

* Lint models/ issue_label, issue_mail & mail.go
Bwko 081c2a9395 Lint models/token.go ()
Lunny Xiao 76604d8f90 fixed test build error
Bwko 33a2ac3830 Lint models/update.go & webhook_slack.go
Lunny Xiao 304bbd3f25 golint fixed for modules/markdown
Bwko d8e11a8eaa Lint models/admin.go
Bwko ece19f4a5e Lint models/release.go
Lunny Xiao 450969c158 test database is connect OK after db config initialized ()
Sandro Santilli 1c3044b873 Lint models/login_source.go
Thomas Boerger 0a66c2a2d9 Merge pull request from strk/issue-lint 
Lint issue.go
Thomas Boerger e512411863 Merge pull request from strk/git_diff-lint 
Lint git_diff.go
Thomas Boerger 03b6880089 Merge pull request from strk/error-lint 
Lint error.go
Sandro Santilli 8aa960f129 Actually document the missing bits
Sandro Santilli 3fba29c571 Expand documentations
Sandro Santilli 0a61d54a9c Expand documentation a bit more
Sandro Santilli dd9d0f3732 Lint action.go
Sandro Santilli 170f2e98cc Lint error.go 
This was done semi-programmatically, not really documenting anything
Sandro Santilli 6e644726d0 Lint git_diff.go 
Semi-automatic linting (don't really document things)
Sandro Santilli 4dd1eb57bd Lint issue.go
stroucki 3a3782bb7f Handle ssh key import better () 
* Handle user ssh key input better

ssh_key: when user submitted keys had a newline at the end, strings.Split
would have created a slice with an empty last element, and the key type
check would be incorrect. Perhaps a better way is to look for 'ssh-rsa' or
'ssh-dsa' at the beginning of the string, but this is simple.

* ssh_key: correct indentation
Sandro Santilli c25063d834 Lint webhook.go, unexports simpleMarshalJSON ()
Bwko 2a449bd4b1 Fix typos
Ethan Koenig 0834e492c0 API endpoints for stars
Bo-Yi Wu d9ffe99972 fix variable assigned and not used. 
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
Sandro Santilli 592a4ec4d3 Fix lint errors in models/wiki (just add methods docs) 
See
Andrey Nering 739f07c98e Remember diff view style ()
LefsFlare 3ef022b071 Fixes possible vulnerabilities with keyword hijacking () 
- Added public entries to reserved keywords list
- Rename variables
- Derped comment
Lunny Xiao 3dedc027ac Bug fixed for issues ()
Lunny Xiao 0baaa7728a bug fixed caused by ()
Lunny Xiao 30a37311f8 use in instead string join ()
Lunny Xiao 555d8b16cb fixed bug caused Find should be Get ()
Lunny Xiao ade6d4a20f optimization on database IN
Lunny Xiao 9bf28a2799 bug fixed for 500 caused by get org users ()
Thibault Meyer ddee4c8b58
Normalize files with gofmt
Sandro Santilli a1c5f02444 Fix import path of go-sdk () 
From code.gitea.io/go-sdk/gitea
  To code.gitea.io/sdk/gitea
Thibault Meyer b12f2a5916
Remove unused import
Thibault Meyer b0ddced2b5
Merge remote-tracking branch 'upstream/master' into feature/rewrite-xorm-queries 
# Conflicts:
#	models/git_diff.go
#	models/issue.go
#	models/org.go
#	models/pull.go
#	models/repo.go
Thibault Meyer a4454f5d0f
Rewrite XORM queries
Sandro Santilli 4247304f5a Update import paths from github.com/go-gitea to code.gitea.io () 
- Update import paths from github.com/go-gitea to code.gitea.io
- Fix import path for travis

See https://docs.travis-ci.com/user/languages/go#Go-Import-Path
Matthias Loibl 94b2747375 Remove go version from build tags ()
Lunny Xiao 1b238fe4d5 Merge pull request from joubertredrat/feature-last-login 
Last Login for admin manage your users
Lunny Xiao c6c840faf7 Merge pull request from lunny/lunny/SQL_instead_Sql 
use x.SQL instead of x.Sql
Thibault Meyer 3a10a0c1ca
Ordering organizations and users by name
Lunny Xiao 7dcc3bc3d7 use x.SQL instead of x.Sql
Joubert RedRat f91cbf0fed Support to last login feature
Lunny Xiao c511f1c6c3 Merge pull request from LefsFlarey/issue/3675 
Fix 500 error caused by deleted users on issues ()
Flare a6c487f6ca
Fix err not being nil
Lunny Xiao 5667d4daae Merge pull request from bkcsoft/gt/2164-release-pagination 
Add Pagination to Releases-page (and de-duplicate pagination templates)
Sandro Santilli 864d1b1f9f Fix type in unused constant name () 
* Write LDAP, SMTP, PAM, DLDAP back to all uppercase

* Fix type in unused constant name

* Other MixCased fixes

* Complete MixerCasing of template constants

* Re uppercase LTS and LDAPS suffixes

* Uppercase JSON suffix in constant names

* Proper case LoginNoType

* Prefix unexported template path constants with "tpl"
Sandro Santilli aadd7dcdc3 And others
Sandro Santilli b3828e38a5 more
Sandro Santilli 05fd9d3f09 Security protocols
Sandro Santilli 7612b5ec40 More mixage
Sandro Santilli 64196d4036 More overlooks
Sandro Santilli f14232d2e9 This one I overlooked before
Sandro Santilli 60c82a8780 More...
Sandro Santilli f6a11e0de1 More MixedCase consts
Sandro Santilli f388661bda ACCESS_MODE_* -> AccessMode*
Sandro Santilli 0b62aeb495 More MixedCase consts
Sandro Santilli 80eea77953 Use MixedCase constant names 
See https://github.com/golang/go/wiki/CodeReviewComments#mixed-caps
Thomas Boerger 5d430c9e68 Merge pull request from go-gitea/go-sdk 
Replaced gogits go-gogs-client with go-sdk
Sandro Santilli ee963f67c1 Merge pull request from strk/GOGS_drop 
Replace GOGS with GITEA in variable names
Joubert RedRat 28bee28102 Replace Gogs to Gitea in installation options
Thomas Boerger 4c6c16f358
Replaced go-gogs-client with go-sdk imports
Sandro Santilli 30be1f4826 Fix typo in unused constant name
Sandro Santilli b7263f31a5 Replace GOGS with GITEA in variable names 
Still use GOGS_WORK_DIR and GOGS_CUSTOM env variables
as a fallback if the equivalent GITEA_* are not set,
warning user about the need for change.

Does not change "gogs" to "gitea" in webhook type name
Because "gogs" hook type is part of the API (routes) and used
in templates...

Closes
Kim "BKC" Carlbäcker 86fb1a0cb1 Add Pagination to Releases-page
Sandro Santilli 6e4252dad4 Replace gogits/git-module dependency with go-gitea/git () 
* Replace gogits/git-module dependency with go-gitea/git

Fixes 

* Remove git alias for git module import (not needed)
LefsFlare 55a4d46f5d Adds checking of reserved keywords against team names ()
Thibault Meyer fe8bfa54de Ordering team by name ascending except for 'Owners' ()
Matthias Loibl 953c099428 Add missing version & gogs package
Matthias Loibl 1f44b01e2a Fix imports found by goimports.
Thomas Boerger 648c6fdd60
Vet complains about "should have signature MarshalJSON() ([]byte, error)", replaced with custom name
Flare fd6be0d17e
Still print error if user does not exist
Matthias Loibl a4fa889ced Run goimports on the whole project () 
Signed-off-by: Matthias Loibl <mail@matthiasloibl.com>
Rémy Boulanouar 8dc49dc114 Implementation of the feature to redirect to an external issue tracker
Rémy Boulanouar 2d68bd1ef9 Change import reference to match gitea instead of gogs ()
Sandro Santilli af03d00780 Fix sender of issue notifications 
It is the FROM field in mailer configuration that needs be used,
not the USER field, which is for authentication.

Closes https://github.com/gogits/gogs/issues/3615
LefsFlare 2bec8a4f1e Changed interface ()
Flare 1b59e6f910
Fix 500 error caused by deleted users on issues ()
Unknwon 6da55159a2
LoadRepoConfig after ORM is initialized
Unknwon c50d59874d
incorrect URL produced by AvatarLink
Unknwon 7c1fbed057 Fix panic when attempt login with non-exist user
Unknwon c2afdf2192 Minor code fix [CI SKIP]
Unknwon 152e715999 models/login_source: code improvement
Unknwon 99c2ae7b35 use alert instead 500 for duplicated login source name
Unknwon 8516dfcb6c able to sync now for mirrors 
- Refactor code to use sync.UniqueQueue
- Closes
Unknwon c1ecb6c60a modules/sync: add UniqueQueue
Unknwon 43297148b2 modules/sync: rename SingleInstancePool to ExclusivePool
Unknwon 643142acab Web editor: support upload files
Unknwon 28cf0e6aaa code quality improvement
Thibault Meyer 92fb30c526 Load a set of predefined labels () 
* Can use a predefined set of labels

* Change UI

* Fix HTML file indentation

* Avoid reading file from other directory (security issue)

* Apply a better fix

* Remove not used variable

* Merge upstream/develop

* Do modifications

* Raname

* remove binding + rename variable
LFlare 3738b6399e Fixed typo () 
Git convention has it capitalised.
Unknwon 62b0dc4853 Web editor: fix cannot create new file in subdirectory
Unknwon 579e5e4fee Web editor: disallow edit mirror repository
Unknwon 0114fdcba4 Web editor: improve delete file process
Unknwon dad5c15520 allow setting preferred licenses 
- Closes
Unknwon c30b856d14 use user’s info for committer and author
Unknwon 13c106af77 label: adjust forecolor boundary
Unknwon ce1e4348da fix wiki HTTP/S clone URL does not have .wiki suffix
Unknwon 37305a59ca migrations: sync table first
Unknwon bb359a74f1 migrations: set comment updated as created
Unknwon 6b98d58906 code cleanup
Iwan Budi Kusnanto 8dca9f95fa issues comment API : list, create, edit () 
add `since` query string support to list issue comment
Thibault Meyer f50e568fd1 Fix : Sort labels by name () 
* Fix  : Order labels by name

* Order labels by name on Issues view
Unknwon f8a48ffaad Web editor: improve code quality
Kurt Madel 67fb0fe6a5 added support to set pull_request event from api ()
Unknwon 0b273ac4d5 code cleanup
Kim "BKC" Carlbäcker 06602a84ff Fix PR-webhook issue where Label-data is stale () () 
* Fix PR-webhook issue where Label-data is stale

* Conventions \o/

* logs are nice if they're consistent...
Unknwon a00c932bbc General code quality improvement
Unknwon 6f9a95f830 add HTMLURL to webhook type 
- Fill Milestone and Assignee field when available in webhook payload
Unknwon 8bf57be9ba Fix git diff tests
Unknwon b1504ed99a add diff signs which does not have inline diff
Unknwon 9349def72e reproduce diff signs 
Commited wrong file.
Unknwon 2625193a48 models/repo_editor: improve code quality
Unknwon f3c3258921 Fix repository owner can assign self
Unknwon 4042d1f0c3 models/issue: improve quality and performance of NewIssue function
Unknwon 6c8fcb3af2 fix clone fail when wiki is empty
Unknwon 94392a7af3 Fix empty repository panic on send test webhook
Unknwon cc647ba9d5 fix security issue of REAMDE path in create repository
Unknwon 54e0ada9d5 Web editor: improve delete file
Unknwon cd89f6c502 Web editor: improve edit file and diff preview
Unknwon 660e7a178a modules/sync: move sync objects to independent module
Unknwon 15845cb287 Code clean up for new config options
Richard Mahn d0a0239bac Squashed commit of the following: 
commit 0afcb843d7ffd596991c4885cab768273a6eb42c
Author: Richard Mahn <richard_mahn@wycliffeassociates.org>
Date:   Sun Jul 31 17:13:29 2016 -0600

    Removed Upload stats as the upload table is just a temporary table

commit 7ecd73ff5535612d79d471409173ee7f1fcfa157
Author: Richard Mahn <richard_mahn@wycliffeassociates.org>
Date:   Sun Jul 31 08:42:41 2016 -0600

    Fix for CodeMirror mode

commit c29b9ab531e2e7af0fb5db24dc17e51027dd1174
Author: Richard Mahn <richard_mahn@wycliffeassociates.org>
Date:   Sun Jul 31 08:03:33 2016 -0600

    Made tabbing in editor use spaces

commit 23af384c53206a8a40e11e45bf49d7a149c4adcd
Author: Richard Mahn <richard_mahn@wycliffeassociates.org>
Date:   Sun Jul 31 07:56:46 2016 -0600

    Fix for data-url

commit cfb8a97591cb6fc0a92e49563b7b764c524db0e9
Merge: 7fc8a89 991ce42
Author: Richard Mahn <richard_mahn@wycliffeassociates.org>
Date:   Sun Jul 31 07:42:53 2016 -0600

    Merge remote-tracking branch 'gogits/develop' into feature-create-and-edit-repo-file

    Conflicts:
    	modules/bindata/bindata.go
    	public/js/gogs.js

commit 7fc8a89cb495478225b02d613e647f99a1489634
Merge: fd3d86c c03d040
Author: Richard Mahn <richard_mahn@wycliffeassociates.org>
Date:   Sun Jul 31 07:40:00 2016 -0600

    Merge branch 'feature-create-and-edit-repo-file' of github.com:richmahn/gogs into feature-create-and-edit-repo-file

commit fd3d86ca6bbc02cfda566a504ffd6b03db4f75ef
Author: Richard Mahn <richard_mahn@wycliffeassociates.org>
Date:   Sun Jul 31 07:39:44 2016 -0600

    Code cleanup

commit c03d0401c1049eeeccc32ab1f9c3303c130be5ee
Author: Richard Mahn <richard_mahn@wycliffeassociates.org>
Date:   Fri Jul 29 15:38:23 2016 -0600

    Code cleanup

commit 98e1206ccf9f9a4503c020e3a7830cf9f861dfae
Author: Richard Mahn <richard_mahn@wycliffeassociates.org>
Date:   Thu Jul 28 18:36:01 2016 -0600

    Code cleanup and fixes

commit c2895dc742f25f8412879c9fa15e18f27f42f194
Author: Richard Mahn <richard_mahn@wycliffeassociates.org>
Date:   Thu Jul 28 18:24:04 2016 -0600

    Fixes per Unknwon's requests

commit 6aa7e46b21ad4c96e562daa2eac26a8fb408f8ef
Merge: 889e9fa ad7ea88
Author: Richard Mahn <richard_mahn@wycliffeassociates.org>
Date:   Thu Jul 28 17:13:43 2016 -0600

    Merge remote-tracking branch 'gogits/develop' into feature-create-and-edit-repo-file

    Conflicts:
    	modules/bindata/bindata.go
    	modules/setting/setting.go

commit 889e9faf1bd8559a4979c8f46005d488c1a234d4
Author: Richard Mahn <richard_mahn@wycliffeassociates.org>
Date:   Fri Jul 22 14:09:18 2016 -0600

    Fix in gogs.js

commit 47603edf223f147b114be65f3bd27bc1e88827a5
Merge: bb57912 cf85e9e
Author: Richard Mahn <richard_mahn@wycliffeassociates.org>
Date:   Fri Jul 22 14:07:36 2016 -0600

    Merge remote-tracking branch 'gogits/develop' into feature-create-and-edit-repo-file

    Conflicts:
    	modules/bindata/bindata.go
    	public/js/gogs.js

commit bb5791255867a71c11a77b639db050ad09c597a4
Author: Richard Mahn <richard_mahn@wycliffeassociates.org>
Date:   Fri Jul 22 14:02:18 2016 -0600

    Update for using CodeMirror mode addon

commit d10d128c51039be19e2af9c66c63db66a9f2ec6d
Author: Richard Mahn <richard_mahn@wycliffeassociates.org>
Date:   Tue Jul 19 16:12:57 2016 -0600

    Update for Edit

commit 34a34982025144e3225e389f7849eb6273c1d576
Merge: fa1b752 1c7dcdd
Author: Richard Mahn <richard_mahn@wycliffeassociates.org>
Date:   Tue Jul 19 11:52:02 2016 -0600

    Merge remote-tracking branch 'gogits/develop' into feature-create-and-edit-repo-file

    Conflicts:
    	modules/bindata/bindata.go

commit fa1b752be29cd455c5184ddac2ffe80b3489763e
Author: Richard Mahn <richard_mahn@wycliffeassociates.org>
Date:   Fri Jul 15 18:35:42 2016 -0600

    Feature for editing, creating, uploading and deleting files
Unknwon dccb0c15b9 Replace convert.To with APIFormat calls
Unknwon 3f7f4852ef fully support of webhooks for pull request
Unknwon f59d2dd034 Code clean up
Unknwon 5be881756b add test suites
Thibault Meyer 4296427214 Fix : Cannot connect to PostgreSQL via IPv6 address () 
* Change PostgreSQL connstring parsing to handle IPv6

* Fix used variable

* Remove redundant code + use variable
Unknwon 96f92e6105 Fix email FROM
Unknwon 70fbcd2f27 models: rename EnableTidb to EnableTiDB
Unknwon 5850308a37 support connect PostgreSQL via unix socket
Unknwon 7e9b42c87d code clean up
Unknwon 5077408d78 code cleanup and minor issue fix
Andrew 0885784f13 Wiki mirroring implementation () 
* Implement wiki mirroring, add Update mirrors operation to admin dashboard

* bindata.go update after merge

* Implement checking Git repo endpoint existence, support for BB included

* Remove admin dashboard operation
Fix bindata.go

* Apply gofmt to repo model file

* Try to remove bindata from PR

* Revert accepted wiki names change in favor of better system

* Remove unused imports
Unknwon 0f26f3678a use doer email for FROM field of issues
Kim Carlbäcker b756806ee9 Add "support" for git-daemon-export-ok () () 
* add git-daemon-export-ok "support"

* Slight fix to git-daemon-export-ok

* Add error-checking for git-demon-export-ok

* Remove old comments and fixed logging-issues

* Check if git-daemon-export-ok exists or not
lstahlman ea192147ea Add test pull request task on merging a PR. Fixes ()
Thibault Meyer 8ad92bb8a4 Verify list len before use it with IN ()
Thibault Meyer fc68fb951c Feature : Redefine global mirror interval () 
* add mirror::GLOBAL_INTERVAL on app.ini

* rename key to DEFAULT_INTERVAL

* add key on default app.ini + move code
Unknwon 5448d29b2e wrong dashboard issue count for create by you
lstahlman 89f71b44f7 Add committer information to API and Webhooks. Also fixes ()
Unknwon c5d4a9e046 Add commit timestamp to webhook
Unknwon b0b88d9bc5 add config option for Git GC
lstahlman 699c71d319 Fix for Links of pull request comment email should use pulls URL ()
Unknwon e5bf4281b5 early response 200 when ?go-get=1
Sandro Santilli 90dd0657b5 Add support for federated avatars () 
* Add support for federated avatars

Fixes 

Removes avatar fetching duplication code
Adds an "Enable Federated Avatar" checkbox in user settings
(defaults to unchecked)

Moves avatar settings all in the same form, making
local and remote avatars mutually exclusive

Renames UploadAvatarForm to AvatarForm
as it's not anymore only for uploading

* Run gofmt on all modified files

* Move Avatar form in its own page

* Add go-libravatar dependency to vendor/ dir

Hopefully helps with accepting the contribution.
See also 

* Revert "Add go-libravatar dependency to vendor/ dir"

This reverts commit a8cb93ae640bbb90f7d25012fc257bda9fae9b82.

* Make federated avatar setting a global configuration

Removes the per-user setting

* Move avatar handling back to base tool, disable federated avatar in offline mode

* Format, handle error

* Properly set fallback host

* Use unsupported github.com mirror for importing go-libravatar

* Remove comment showing life exists outside of github.com

... pity, but contribution would not be accepted otherwise

* Use Combo for Get and Post methods over /avatar

* FEDERATED_AVATAR -> ENABLE_FEDERATED_AVATAR

* Fix persistance of federated avatar lookup checkbox at install time

* Federated Avatars -> Enable Federated Avatars

* Use len(string) == 0 instead of string == ""

* Move import line where it belong

See
https://github.com/Unknwon/go-code-convention/blob/master/en-US/import_packages.md

Pity the import url is still the unofficial one, but oh well...

* Save a line (and waste much more expensive time)

* Remove redundant parens

* Remove an empty line

* Remove empty lines

* Reorder lines to make diff smaller

* Remove another newline

Unknwon review got me start a fight against newlines

* Move DISABLE_GRAVATAR and ENABLE_FEDERATED_AVATAR after OFFLINE_MODE

On re-reading the diff I figured what Unknwon meant here:
https://github.com/gogits/gogs/pull/3320/files#r73741106

* Remove newlines that weren't there before my intervention
Unknwon ec92565f23 fix missing sub-url prefix in relative avatar link
Andrey Nering 2772791fda Improve diff highlight () 
- Try to reduce memory allocations
- Add possibility to disable diff highlight (can improve performance for large diffs)
- Tweaking with cost for prettier (cleaner) diffs
- Do not calculate diff when the number of removed lines in a block is not equal to the number of added lines (this usually resulted in ugly diffs)
Thibault Meyer 30fda0f1ae Fix : Release dont use tag creation date () 
* Fix : Release dont use tag creation date

* Simplify code and apply gofmt

* remove useless block (ctx.Repo.GitRepo.GetTag) on EditReleasePost

* apply gofmt on modified files
Unknwon 50422f1fc2 always use relative avatar link in the template
Unknwon e7fd65f0cf better code structure and batch minor improvements
lstahlman 2eeb0ec9b0 Additional API support for labels () 
* Add API support for labels.

* Error handling for adding/replacing multiple issue labels

* Revisions to function names and error handling. Use issue.ClearLabels in replace/clear functions

* Additional code cleanup
Unknwon 10dc330640 dump content directly to HTTP ResponseWriter
Dennis Chen dfab54d5a2 Diff patch () 
* Add support for .diff and .patch

Add the ability to get text-diff and format-patch by adding .diff or
.patch in the end of a commit url. Issue 

* models: git_diff: various fixes

* Renames commitId to commitID.
* Writes stderr to a bytes.Buffer and displays proper error message on
command failure.
* Various style changes.

Signed-off-by: Dennis Chen <barracks510@gmail.com>
마누엘 36a63dd059 models/release: Update Sha1 if tag already exists () 
Since the release struct is initialized with the current `HEAD` of the
current `release.Target` the commit id has to be updated if the tag
commit already exists. Otherwise the linked commit on the release page
will target the current `HEAD` at release time.
Unknwon 8aa0a76702 fix wrong table name in Join
Unknwon 2d76de2574 fix x.Iterate returns nothing inside session scope with SQLite3
Unknwon 4d8b905541 models/ssh_key: code cleaning
Unknwon 899e799459 support delete issue comment
Unknwon a562228c5e Add org.getUserTeams to reduce redundant code
Unknwon e74630ae3b add pagination for repositories
Unknwon 1f2e173a74 Refactor User.Id to User.ID
Unknwon 46e96c008c Use struct for UI settings
Unknwon 250be011c7 Remove redundant Unix timestamp method call 
Unix() already uses UTC as timezone
Unknwon 4e822c1911 conf: change default mirror checking interval to 10m
Unknwon 69f5308761 use different reversed words and patterns for repository and user
Unknwon 4f78abe7dc fix create organization ignores full name property
Unknwon 745167d57a create user path before rename repository while transfer 
os.Rename does not create parent directory automatically when not exist
Unknwon c912494609 detect invalid tag name git error
Siarhei Navatski cf85e9eb7b add IsSubmodule field to DiffFile and hide view file button on diff page for submodules ()
Dennis Chen 6488ee12be avatar: make custom and generated avatars equal () 
Sets all avatars to use PNG image format.
Keeps avatars consistent at 290x290px resolution.

Signed-off-by: Dennis Chen <barracks510@gmail.com>
Unknwon 5761342f32 fix SQLite3 session read/update conflict on create new issue
Unknwon 57af7432fc fix wrong logic judgement
lstahlman e7a4f96fb6 Updated Issues and Issues Stats functions to include table aliases. This addresses errors involving ambiguous column references when filtering issues by the view type "Mentioning you". ()
Unknwon 60110adc06 models/webhook: restrict deletion to be explicitly with repo and org ID
Unknwon c083d76567 able to prohibit user login
Unknwon 52322ef624 models/user_mail: refactor EmailAddress
Sandro Santilli a4ea3bd015 Return avatar link as absolute url () 
Fixes relative urls coming from api/v1

See https://github.com/drone/drone/issues/1701
Unknwon 3d93532c87 fix can't get webhook detail of organization
Unknwon f1b8d52eb3 fix no mail notification when issue is closed/reopened
Unknwon 7ca5f8f119 models/repo: remove redundant info for some repo methods 
RepoLink -> Link, RepoRelLink -> RelLink, FullRepoLink -> FullLink
Kim Carlbäcker d950bf68e3 Ignore Response Body for Slack Hooks ()
Unknwon a752f09055 validate username attribute fetched from LDAP
Unknwon 70a281a39b preserve cases for action content
Unknwon 9fcf66f0e0 Minor fix for
Pablo Saavedra 98b152030d The pruning for the synchronized mirrors is a option now. Default value: enable_prune = true () 
Executed go fmt

getEngine() not handles DB parameters () ()

Uses .AllCols() for Update in updateMirror()

Spanish traslation removed

Fixed a wrong way to ommit the --prune option in process.ExecDir() for MirrorUpdate function
Pheng Heong TAN 467d7dacb6 Modify behaviour of repo-delete. () 
Re: issues  and 

As a result of modifications to the contents of the conf folder, `make bindata`
was run, causing an update to bindata.go.

Meta
-----
This commit will be rebased onto the 'develop' branch.
Unknwon d62ab49978 retrieve webhook with repo_id 
This prevents user retrieve arbitrary webhook by changing URL to
access webhook from other unauthorized repositories.
Unknwon e30c701386 disallow repository name . and .. 
Since . and .. has browser automatical behaviors, we need to disallow those names.
Unknwon 401bf944ef Use SecurityProtocol to replace UseSSL in LDAP config 
Initially proposed by  and fixes  as well.
Unknwon 4b25bdfbc4 support correct page size and link header
Tom 528682a294 getEngine() not handles DB parameters () ()
Unknwon 3a30c06345 Fix wiki vulnerabilities 
- Arbitrary file creation leading to command execution
- .md file creation/deletion

Reported by Gabriel Campana.
Andrey Nering 743d22669a Re-work MAX_DIFF_LINES: supress diff per file, not the whole diff ()
Andrey Nering 6efb1e5626 Localize collaboration settings. () 
Closes
Sandro Santilli 8a248696e9 Use a gopher as default avatar (rather than the gravatar logo) () 
Also changes the avatar from a jpeg to a png, to allow for
transparent background. The indexed png is also smaller in size.

Note that at the moment the default avatar is only used when
the user requested a custom avatar and the custom avatar file
is not found (should never happen).

In the future the default avatar could be used as a default
return when by-mail avatar lookups fail too (both gravatar
and libravatar support passing a default)
Franz Schmidt 8b35c194ec Fixes ()
Robin Lambertz ac05f88641 Fix ()
SjonHortensius 17a4d8a5e5 Fix capitalisation of repo-name in news () 
use 'official' repo.Name instead of incoming repoName; to enforce
correct capitalisation
Robin Lambertz bc00da1721 Fix negative issue count ()
Unknwon e9ae926e04 fix wrong closed issue count when create closed issue via API 
Add start count corrector for Repository.NumClosedIssues
Andrey Nering 12d30255a7 Add comment note ()
Kim Carlbäcker 3c0c7a9f83 Fix listing team members ()
Andrey Nering d8612f7704 Fix remove folder issues, including initialization failling. () 
- Prevent panic on creating notice if database is not available
- Prevent incorrect folder on Windows ("/" instead of "\")
Unknwon 0a78d99a4d models/release: filter input to prevent command line argument vulnerability
Unknwon 0325bec283 minor fix for bug of xorm
Thomas Boerger dfad51fe9e Made the issue stats query more secure with parameterized placeholders ()
Unknwon 78b8b63774 set default style name when empty in AfterSet
Cosmin Stroe ba314a7a36 Support alphanumeric issue style (ABC-1234) for external issue tracker ()
Unknwon 762ab056a2 Fix XORM IN condition table name parse
Thomas Boerger 746c7fd4e7 Followup fix for previous query fix
Thomas Boerger b5948f2e71 Made the issues query more secure and simpler
Thomas Boerger 79a1bfd963 Try to make the SQL queries cleaner and more secure
Unknwon b1d41cfa60 add admin APIs to add/remove a user from teams
Unknwon 98b58fa050 Handle windows deletion when start 
Fix
Unknwon e6f927f61a api: admin list and create team under organization
Unknwon ff731ea07d LOWER() column value within search
Odin Ugedal 6ccb2d36cf Remove email from user search
Odin Ugedal 3253e3c5aa Make user search look in username, name and email 
Make user search function look in username (lower_name), full name
(full_name) and primary email (email). This will benefit searching after
user in "explore", admin panel and when adding new collaborators.
Unknwon 9bd9ad4205 add CRUD issue APIs 
- Fix go-gogs-client#10
- Related to
Unknwon f76d821bda fix
Unknwon 263304b6b7 fix postgres aggregate
Unknwon 2bf8494332 finish user and repository search 
Both are possible on explore and admin panel
Marin Jankovski 1314ba219e Updated and created were appended with _unix. Fresh databases have only the newly named fields.
Unknwon 5267dce210 Fix ref comment from commit create empty feed
Unknwon eed9966ad6 fix incompatible SQL in PostgreSQL
Unknwon ad513a20e9 Replace time.Time with Unix Timestamp (int64)
Unknwon 13bd16af92 Minor fixes for
Tamás Molnár 9c91e27933 Added: Ability to delete org avatar.
Unknwon a5b0400be7 finish new access rights for collaborators
Unknwon 045f14fbd0 finsih UI work for access mode of collaborators 
Collaborators have write access as default, and can be changed via repository
collaboration settings page to change between read, write and admin.
Unknwon 414eb22ef9 fix activitity feeds for pull requests
Unknwon a2f13eae55 some avatar setting changes 
- Allow to delete current avatar
Unknwon 2a931937a8 Update locales
Unknwon dfd6f8f7ab Merge pull request from joshfng/fix-fork-relative-url 
Use relative url when showing forked from
Josh Frye 275464e7fb Use relative url when showing forked from
Unknwon e2d370f0da fix pull request remote head can't update with force push
Unknwon 5335e671be more fixes on SQL errors
Unknwon 2d2d85bba4 support pull requests in same repository
Unknwon 9df6ce48c5 Minor fixes for
Unknwon 4d5911dbcf Merge pull request from joshfng/feature-delete-wiki-pages 
Add ability to delete single wiki pages.
Unknwon d57a2b908a and fix bad SQL generated by XORM 
Use hand-written SQL to do complex query
Josh Frye 1ca171dbe9 Add ability to delete single wiki pages.
Unknwon 260723e2cc Minor fixes for
Josh Frye f3358f5927 Repo setting to delete and disable wiki
Josh Frye 7f2733fa1b Return errors instead of just logging them.
Josh Frye edb7967dc7 Set DefaultBranch to master when importing a new repo if possible
Unknwon c9901bbba5 workaround to fix XORM problem
Unknwon 97429a25ab make IN clause compatible with Postgres
Unknwon 9e89584cb4 Allow setting git operations timeouts 
- Migrate:  
- Clone: 
- Mirror, Pull
Unknwon ea80274229 fix sqlite3 can't create issue with more than one label
Unknwon 8055a0bdac Post work for 
Improve test cases, config settings, also show SSH config settings on admin config panel.
Unknwon 83c74878df Merge pull request from Gibheer/ssh-publickeys 
allow native and ssh-keygen public key check
Unknwon d320915ad2 Minor fix for
Lukas Dietrich c0eaae200e Add ForegroundColor for labels
Unknwon 129638117f fix panic when close issue via commit message
Gibheer 2f27ee2232 variable should not use ALL_CAPS
Unknwon 912f7b51e9 add actions for close and reopen issues
Andrey Nering d160c7e565 Little refactoring of diff highlight. 
Moving cache variable to template instead of in the struct.
Unknwon ac78bae7b5 Replace uuid module with original package
Unknwon d5a3021a7d Make markdown as an independent module
Unknwon d8a994ef24 Move cron module to independent package 
Make it easier to keep track of upstream changes and bug fixes
Unknwon acf094fb07 Minor fix for 
Add AttributesInBind option in new auth source form.
Unknwon b7f3d94cd0 Minor fix for
Unknwon f6c98465c7 Merge pull request from mhartkorn/pullrefs 
Enable a way to checkout Pull Requests from remote refs
Unknwon aa12135b97 Fix panic when view profile without signin 
Also fix that no matter who, still able to see organizations with private membership.
Unknwon 2408df3f35 Merge pull request from Download-Fritz/MirrorForks 
 Allow to fork and disallow to create PRs for mirrors.
Download-Fritz a467184e13 Allow to fork and disallow to create PRs for mirrors.
Unknwon 338af89d56 fix possbility that use email as pusher user name 
Remove the possibility of using email as user name when user actually push
through combination of email and password with HTTP.

Also refactor update action function to replcae tons of arguments with
single PushUpdateOptions struct.
And define the user who pushes code as pusher, therefore variable names shouldn't
be confusing any more.
Gibheer dab74f21b7 remove ed25519 test for now 
TravisCI is too old for ed25519, so it can't be tested correctly.
Gibheer 9eef2e706c fix ssh public key tests 
The old API was using []byte, but was changed to string without running
the tests again.
It also sets the variables from the configuration to make them work.
Maybe there is a better way to do this.
Gibheer 12403bdfb0 allow native and ssh-keygen public key check 
This commit adds the possibibility to use either the native golang
libraries or ssh-keygen to check public keys. The check is adjusted
depending on the settings, so that only supported keys are let through.

This commit also brings back the blacklist feature, which was removed in
7ef9a05588. This allows to blacklist
algorythms or keys based on the key length. This works with the native
and the ssh-keygen way.

Because of  it also includes a way to adjust the path to
ssh-keygen and the working directory for ssh-keygen. With this,
sysadmins should be able to adjust the settings in a way, that SELinux
is okay with it. In the worst case, they can switch to the native
implementation and only loose support for ed25519 keys at the moment.
There are some other places which need adjustment to utilize the
parameters and the native implementation, but this sets the ground work.
Lunny Xiao 779b71eda4 fix dependency broken because xorm's API changed
Unknwon 2765b5c7cf fix wrong user avatar link in webhook 
Was using the wrong method and now uses the method which checks if
the avatar link is relative or not.
Unknwon 632c27802c Minor fix for
Unknwon dc89c51f3e Merge pull request from mhartkorn/convert-mirror-to-repo 
Convert mirrors to regular repositories
Martin Hartkorn bb595666ac Moved UpdateRepository() to CleanUpMigrateInfo() and correctly delete mirror from database
Unknwon 58e004f7da Remove cache avatar support and add its tests
Unknwon fd92d91da3 Minor fix for
Unknwon d8631b616e Merge pull request from exmex/develop 
Admins and user itself sees private org relations on profile
Unknwon a1d97e8f5c Minor fix for
Unknwon daa43cfb6e Merge pull request from fnkr/hide-other-teams-activity-from-dashboard 
Only show activities and repositories on the dashboard, that the user has access to
Unknwon 9adfe453d5 delete repo local copy when transfer 
Remote repository path is renamed but does not delete
outdated local copy which still has old repository path
as remote.
Martin Hartkorn 15d37b7a95 Refactored according to suggestions
Martin Hartkorn 3650bd8528 Convert mirrors to regular repositories.
Josh Frye 8662990746 Add default branch to repo payload
Josh Frye ce3708b3ea Remove local wiki copy on repo transfer. Fixes
Unknwon 59745c62b4 fix missing SQL query placeholder
Unknwon 297e772c20 fix payloads mixed up for webhook 
When repository contains a Slack type hook,
it changes original payload content.

This patch fixes it by using a local object to store
newly created Slack payload instead of assigning
back to the same variable.
Unknwon f15a2f9b25 Merge pull request from andreynering/diff-sintax-highlight-733 
Enable syntax highlighting on diff view
Andrey Nering d37cf09ccd Workaroud delete folder on Windows. Fix
ExMex 2cfe6f8c60 Admins and user itself sees private org relations on profile
Florian Kaiser 45db167f7a Only show activities for repositories on dashboard, that the user has access to
Tobias Kunicke fa5a1cb54f regulate timezone for milestone.deadline
Unknwon f8182ac521 delete local wiki copy when rename repo and user
Andrey Nering 2bfb8bb5fd Enable sintax highlighting on diff view. Close
Andrey Nering 137a49e834 go fmt models/git_diff_test.go
Martin Hartkorn a3bdede2ce Removed unused method GetUnmergedPullRequestByRepoPathAndHeadBranch
Unknwon ddf9fa06c7 Minor fix for
Martin Hartkorn d91004ee71 Removed dependency on post-receive hook and use TriggerTask instead
Unknwon 739d5aa1d3 Merge pull request from fnkr/hide-other-teams-repos-from-org-page 
Hide other teams & repos from organization page
Unknwon 04be8c0de5 reinitialize all repos from the db 
- Update locales
Florian Kaiser fb1708e1af Remove unnecessary private functions
Unknwon a47baa1b7a Add missing patch conflit pattern
Unknwon 995487e822 Minor fix for
Unknwon 5e97693e0e Merge pull request from sapk/add-branche-api-support 
Implement API for branches listing
Unknwon 5a27aea8e0 Fix random avatar does not work on Windows 
path.Dir can't handle Windows case, must use filepath.Dir
Unknwon 32efc3ec0a Merge pull request from JohnMaguire/bugfix/2447-delete-public-key-authorized_keys 
Fixes  (delete public key from authorized_keys)
John Maguire b3e0efc0c3 Trim whitespace when adding SSH keys (fixes )
John Maguire caa4ca46c0 Add debug log when SSH key for deletion isn't found
Florian Kaiser 90780a0d90 Use invalid value (-1) instead of 0 to prevent bug if auto increment starts with 0
Florian Kaiser bba1847a8e Everyone can see public repos
Florian Kaiser e35791b2b2 Only show teams the user has access to
Florian Kaiser 5eafe2b17e Only show repositories the user has access to, on the organization home
Martin Hartkorn 20403f75fb Enable a way to checkout Pull Requests from remote refs
Florian Kaiser 295de51b99 Show all orgs on user profile, except the private one's
Unknwon 112a7cab31 incorrect error handle for team name
Antoine GIRARD b7b30cd85e Corrections following recommendations
Antoine GIRARD c11c3b6c11 Near ready
Unknwon e2dde6eb0a Record error when fail to health check repository
Unknwon 4deb876343 Minor fix for 
- Change tooltip size from mini to tiny in profile page
Unknwon 0617720c0c Merge pull request from mhartkorn/pullreq-name-change 
Change user name in Pull Requests to avoid errors (fixes )
Martin Hartkorn 674c5c37be Change user name in Pull Requests
Andrey Nering 5deb726f3f Refactoring of inline diff computing to prevent empty diff box. Fix
Kim "BKC" Carlbäcker edc414c584 Fixed Webhook URL-length Issue
Unknwon 7ef9a05588 use Go sub-repo ssh to verify public key content
Unknwon c631a4a9b9 URL fix for
Antoine GIRARD 688fc515f8 Fix username display in lower-cased for comment in Dashboard
Unknwon f43cc90841 Truncate repository name if too long
Unknwon c199703e2a fix convert type
Unknwon 91bab801aa try to handle []int8 case
Andrey Nering 9620f48ed0 Fix test case after 86bce4a2ae.
Unknwon 8a93113192 roll back a small change
Unknwon 86bce4a2ae minor fix to
Unknwon bcf6aed452 Merge pull request from andreynering/highlight-diff 
Highlight diff
Andrey Nering 697b0e2aba Fix: now highlights in diff view are getting the correct lines.
Andrey Nering bf11ad19ea Semantic fixes.
Andrey Nering 81ed5c4bee Declaring specific types for enums constants. 
This makes the code more strict since you can't assign or compare
values of different types without proper cast.
Andrey Nering 73474c043b Highlighting differences of lines in the diff view.
zhuharev 0d5dc8a064 typo fix
Unknwon 4993ab1a76 fall back to use custom chardet lib
Unknwon 240fe07287 URL consistency on webhook payload
Unknwon 157d868254 Merge pull request from angus-g/fixes/user-following-migration 
Add default for NumFollowing field (fixes )
Unknwon e16042010e Merge pull request from Jofkos/patch-1 
Wiki pages containing question marks in their name weren't loading
Angus Gibson e914969e4c Add default for NumFollowing field (fixes ) 
We set the default value for the non-NULL field NumFollowing of the User
model to 0, which stops an error when the ORM tries to sync.
Unknwon a49af93faf APIs: Users Followers 
- User profile un/follow
- List user's followers/following
Jofkos 76d4af891f Removed empty line, multi return args
Jofkos 0721095944 Wiki pages containing question marks in their name weren't loading 
(untested)
Unknwon 53eb37d529 fix
Unknwon 9cd16c5b12 add organization APIs
Unknwon b117befc2b add user email APIs
Unknwon 7786cb76f3 fix
Unknwon 19423957b1 rename import path
Unknwon 3362b3a44f fix possible disclosure
Unknwon 50264200f0 fix huge diff hangs
Unknwon 91789930bc fix 500 on /watchers & /stars for pg
Unknwon 95f9c85bcc use Go sub-repo to detect encoding
Unknwon 79dcd7ee6e able to identify git version on Windows
Unknwon 76bdbcc969 fix SMTP authentication makes invalid assumption on protocol
Unknwon 4d31eb2c0d fix org max repo limit default to -1
Unknwon 5d95ffe3eb The owner has reached maximum creation limit of 0 repositories
Unknwon bc17f2f759 fix rewrites authorized_keys when builtin SSH server is enabled
Unknwon 40f3142264 External URL for wiki
Unknwon 7a3eccc709 Drop 0.5.x support
Unknwon 3d5d61778a disable password change for non-local users
Unknwon 99e9bbef6c fix bool check for repo max limit and fix hang when push repo with tons of commits
Unknwon 0e96a46020 fix user repo limit default value
Unknwon df5ed64cca "read-only" users
Unknwon 2a0bb1fa90 Limit repo creation
Unknwon 9a2e43bff2 move out git module and send push hook
Unknwon 718d3ae258 Able to config fsck timeout
Unknwon 120cd4e471 Better mirror repo management
Unknwon dce2a9e7e1 fix wrong slack webhook payload URL
Alex Myasoedov ae54d878c0 Fix misspelled words
Unknwon 978dc00305 APIs: admin users
Unknwon bf26808fb3 update README
Unknwon 404867f206 fix and fix
Unknwon f41360d864 advanced select ops for system notices
Unknwon e82ee40e9e init with all enabled
Unknwon e538ff2770 fix and fix
Unknwon 76d4b9288b have fallback but empty value
Unknwon 05ba8622f0 move fallback to empty string
Unknwon e0bae9547a more fixes on
Unknwon 81133d45a1 work on
Unknwon 37a372f6f5 500 when wiki not exists
Unknwon f122d0856e fix
Unknwon cc8f5add6e fix
Unknwon 926e91820a Diff is not showing full content when has super long one line
Unknwon 0be8b1b1a1 Ability to batch delete system notices
Unknwon 834d38a8fb add short version as fallback to Slack payload
Adam Strzelecki 573305f3d3 LDAP: Optional user name attribute specification 
Consider following LDAP search query example:

    (&(objectClass=Person)(|(uid=%s)(mail=%s)))

Right now on first login attempt Gogs will use the text supplied on login form
as the newly created user name. In example query above the text matches against
both e-mail or user name. So if user puts the e-mail then the new Gogs user
name will be e-mail which may be undesired.

Using optional user name attribute setting we can explicitly say we want Gogs
user name to be certain LDAP attribute eg. `uid`, so even user will use e-mail
to login 1st time, the new account will receive correct user name.
Unknwon 9ed60d96a9 fix API
Unknwon d3a5ff7b6b fix
Unknwon 830d000667 finish wiki
Unknwon e42fcb033d wiki: finish edit
Unknwon 392f3ee210 wiki: finish new
Unknwon c50a3503e6 introduce git-shell
Unknwon 2b10fdc4dc Wiki: UI for page new
Unknwon eb30cbab81 add unsupported migration prompt
Unknwon 3ca544912f Drop /org/ URL path prefix in organization home page
Unknwon ec8d41765d some fix to
Unknwon dcc740fd26 fix incorrect
Unknwon 8966750fd4 add some log
Unknwon b4877b1e06 fix for
Unknwon eea2e05da6 minor fix on
Unknwon 6a6a7512c2 notice
Unknwon 6b30b20765 add more debug info
Unknwon 74dfe439c2 more fix on
Unknwon 1d4a5b1825 fix
Unknwon 987dcc5372 fix
Unknwon 902b578465 better escape char handle
Unknwon 3d14e73fd8 fix and data race in timming tasks
Unknwon 2158e6fc43 fix
Unknwon f455125d4d fix
Unknwon f04d773f4f UI: long organization name in create repository owner list
Unknwon efea642d6c add admin op: delete missing repos
Unknwon ab9411be2a clean up code
Unknwon 9ab96172fc new watchers, stars and forks UI