gitea

Commit Graph

Author	SHA1	Message	Date
TheFox0x7	2a02734f93	Refactor older tests to use testify (#33140 ) Refactor checks to use assert/require Use require.Eventually for waiting in elastic and meilisearch tests Use require to exit early instead of assert	3 months ago
caicandong	13359581df	refactor improve NoBetterThan (#26126 ) - The `NoBetterThan` function can only handle comparisons between "pending," "success," "error," and "failure." For any other comparison, we directly return false. This prevents logic errors like the one in #26121. - The callers of the `NoBetterThan` function should also avoid making incomparable calls. --------- Co-authored-by: yp05327 <576951401@qq.com> Co-authored-by: puni9869 <80308335+puni9869@users.noreply.github.com>	2 years ago

Author

SHA1

Message

Date

TheFox0x7

2a02734f93

Refactor older tests to use testify (#33140 )

Refactor checks to use assert/require
Use require.Eventually for waiting in elastic and meilisearch tests
Use require to exit early instead of assert

caicandong

13359581df

refactor improve NoBetterThan (#26126 )

- The `NoBetterThan` function can only handle comparisons between
"pending," "success," "error," and "failure." For any other comparison,
we directly return false. This prevents logic errors like the one in
#26121.
- The callers of the `NoBetterThan` function should also avoid making
incomparable calls.

---------

Co-authored-by: yp05327 <576951401@qq.com>
Co-authored-by: puni9869 <80308335+puni9869@users.noreply.github.com>

2 Commits (2a02734f93c0091275c77e370b7eed03b2c5f18e)