gitea

Commit Graph

Author	SHA1	Message	Date
Jimmy Praet	22b9c2c95c	Load outdated comments when (un)resolving conversation on PR timeline (#29203 ) Relates to #28654, #29039 and #29050. The "show outdated comments" flag should only apply to the file diff view. On the PR timeline, outdated comments are always shown. So they should also be loaded when (un)resolving a conversation on the timeline page.	1 year ago
wxiaoguang	a4859dcfea	Improve user experience for outdated comments (#29050 ) Try to improve #28949 1. Make `ctx.Data["ShowOutdatedComments"] = true` by default: it brings consistent user experience, and sometimes the "outdated (source changed)" comments are still valuable. 2. Show a friendly message if the comment won't show, then the end users won't fell that "the comment disappears" (it is the special case when `ShowOutdatedComments = false`)	1 year ago

Author

SHA1

Message

Date

Jimmy Praet

22b9c2c95c

Load outdated comments when (un)resolving conversation on PR timeline (#29203 )

Relates to #28654, #29039 and #29050.

The "show outdated comments" flag should only apply to the file diff
view.
On the PR timeline, outdated comments are always shown.
So they should also be loaded when (un)resolving a conversation on the
timeline page.

wxiaoguang

a4859dcfea

Improve user experience for outdated comments (#29050 )

Try to improve #28949

1. Make `ctx.Data["ShowOutdatedComments"] = true` by default: it brings
consistent user experience, and sometimes the "outdated (source
changed)" comments are still valuable.
2. Show a friendly message if the comment won't show, then the end users
won't fell that "the comment disappears" (it is the special case when
`ShowOutdatedComments = false`)

2 Commits (0ea8de2d0729e1e1d0ea9de1e59fbcb673e87fd2)