Don't select join table's columns (#19660)

* Don't select join table * Add comment
3 years ago · e435283c0f
parent cd99540cdc
commit e435283c0f
1 changed files with 3 additions and 1 deletions
--- a/models/action.go
+++ b/models/action.go
@ -340,7 +340,9 @@ func GetFeeds(ctx context.Context, opts GetFeedsOptions) (ActionList, error) {
 	}

 	e := db.GetEngine(ctx)
-	sess := e.Where(cond).Join("INNER", "repository", "`repository`.id = `action`.repo_id")
+	sess := e.Where(cond).
+		Select("`action`.*"). // this line will avoid select other joined table's columns
+		Join("INNER", "repository", "`repository`.id = `action`.repo_id")

 	opts.SetDefaultValues()
 	sess = db.SetSessionPagination(sess, &opts)