From e2b8f70e0def66091c29fd8e5b75ccdfabfda932 Mon Sep 17 00:00:00 2001 From: yuxiqian <34335406+yuxiqian@users.noreply.github.com> Date: Thu, 16 Jan 2025 10:17:34 +0800 Subject: [PATCH] [FLINK-37124][build] Simplify logs in test cases to avoid flooding GHA outputs This closes #3860 --- .../src/test/resources/log4j2-test.properties | 4 +- .../src/test/resources/log4j2-test.properties | 4 +- .../FlinkParallelizedPipelineITCase.java | 13 ++++-- .../src/test/resources/log4j2-test.properties | 4 +- .../src/test/resources/log4j2-test.properties | 4 +- .../Elasticsearch6DataSinkITCaseTest.java | 6 +-- .../Elasticsearch7DataSinkITCaseTest.java | 6 +-- .../ElasticsearchDataSinkFactoryTest.java | 43 ++++++++++--------- .../sink/ElasticsearchDataSinkITCaseTest.java | 6 +-- .../src/test/resources/log4j2-test.properties | 4 +- .../src/test/resources/log4j2-test.properties | 4 +- .../maxcompute/EmulatorTestBase.java | 8 +++- .../src/test/resources/log4j2-test.properties | 4 +- .../src/test/resources/log4j2-test.properties | 4 +- .../src/test/resources/log4j2-test.properties | 4 +- .../src/test/resources/log4j2-test.properties | 4 +- .../src/test/resources/log4j2-test.properties | 4 +- .../src/test/resources/log4j2-test.properties | 4 +- .../connectors/db2/table/StartupOptions.java | 2 +- .../src/test/resources/log4j2-test.properties | 4 +- .../src/test/resources/log4j2-test.properties | 4 +- .../MysqlDebeziumTimeConverter.java | 2 +- .../src/test/resources/log4j2-test.properties | 4 +- .../src/test/resources/log4j2-test.properties | 4 +- .../src/test/resources/log4j2-test.properties | 4 +- .../src/test/resources/log4j2-test.properties | 4 +- .../src/test/resources/log4j2-test.properties | 4 +- .../src/test/resources/log4j2-test.properties | 4 +- .../src/test/resources/log4j2-test.properties | 4 +- .../pipeline/tests/MaxComputeE2eITCase.java | 5 ++- .../src/test/resources/log4j2-test.properties | 4 +- .../utils/FlinkContainerTestEnvironment.java | 3 +- .../src/test/resources/log4j2-test.properties | 4 +- .../src/test/resources/log4j2-test.properties | 4 +- .../serializer/SerializerTestBase.java | 43 ++++++++----------- .../schema/DataTypeSerializerTest.java | 11 +++-- .../src/test/resources/log4j2-test.properties | 4 +- 37 files changed, 129 insertions(+), 119 deletions(-) diff --git a/flink-cdc-cli/src/test/resources/log4j2-test.properties b/flink-cdc-cli/src/test/resources/log4j2-test.properties index 1ea721efd..d4efb016b 100644 --- a/flink-cdc-cli/src/test/resources/log4j2-test.properties +++ b/flink-cdc-cli/src/test/resources/log4j2-test.properties @@ -11,9 +11,9 @@ # See the License for the specific language governing permissions and # limitations under the License. -# Set root logger level to OFF to not flood build logs +# Set root logger level to ERROR to not flood build logs # set manually to INFO for debugging purposes -rootLogger.level = INFO +rootLogger.level = ERROR rootLogger.appenderRef.test.ref = TestLogger appender.testlogger.name = TestLogger diff --git a/flink-cdc-common/src/test/resources/log4j2-test.properties b/flink-cdc-common/src/test/resources/log4j2-test.properties index cad8aa6dd..0d45bab80 100644 --- a/flink-cdc-common/src/test/resources/log4j2-test.properties +++ b/flink-cdc-common/src/test/resources/log4j2-test.properties @@ -13,9 +13,9 @@ # limitations under the License. ################################################################################ -# Set root logger level to OFF to not flood build logs +# Set root logger level to ERROR to not flood build logs # set manually to INFO for debugging purposes -rootLogger.level = OFF +rootLogger.level = ERROR rootLogger.appenderRef.test.ref = TestLogger appender.testlogger.name = TestLogger diff --git a/flink-cdc-composer/src/test/java/org/apache/flink/cdc/composer/flink/FlinkParallelizedPipelineITCase.java b/flink-cdc-composer/src/test/java/org/apache/flink/cdc/composer/flink/FlinkParallelizedPipelineITCase.java index 1920227da..90b2e5233 100644 --- a/flink-cdc-composer/src/test/java/org/apache/flink/cdc/composer/flink/FlinkParallelizedPipelineITCase.java +++ b/flink-cdc-composer/src/test/java/org/apache/flink/cdc/composer/flink/FlinkParallelizedPipelineITCase.java @@ -47,6 +47,8 @@ import org.junit.jupiter.api.Timeout; import org.junit.jupiter.api.extension.RegisterExtension; import org.junit.jupiter.params.ParameterizedTest; import org.junit.jupiter.params.provider.EnumSource; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; import java.io.ByteArrayOutputStream; import java.io.PrintStream; @@ -65,6 +67,9 @@ import static org.apache.flink.configuration.CoreOptions.ALWAYS_PARENT_FIRST_LOA @Timeout(value = 600, unit = java.util.concurrent.TimeUnit.SECONDS) class FlinkParallelizedPipelineITCase { + private static final Logger LOG = + LoggerFactory.getLogger(FlinkParallelizedPipelineITCase.class); + private static final int MAX_PARALLELISM = 4; private static final int UPSTREAM_TABLE_COUNT = 4; private static final List ROUTING_RULES; @@ -144,11 +149,11 @@ class FlinkParallelizedPipelineITCase { @AfterEach void cleanup() { System.setOut(standardOut); - System.out.println( + LOG.debug( "NOTICE: This is a semi-fuzzy test. Please also check if value sink prints expected events:"); - System.out.println("================================"); - System.out.print(outCaptor); - System.out.println("================================"); + LOG.debug("================================"); + LOG.debug(outCaptor.toString()); + LOG.debug("================================"); outCaptor.reset(); } diff --git a/flink-cdc-composer/src/test/resources/log4j2-test.properties b/flink-cdc-composer/src/test/resources/log4j2-test.properties index f0d32fb59..32df1c025 100644 --- a/flink-cdc-composer/src/test/resources/log4j2-test.properties +++ b/flink-cdc-composer/src/test/resources/log4j2-test.properties @@ -13,9 +13,9 @@ # limitations under the License. ################################################################################ -# Set root logger level to OFF to not flood build logs +# Set root logger level to ERROR to not flood build logs # set manually to INFO for debugging purposes -rootLogger.level=INFO +rootLogger.level=ERROR rootLogger.appenderRef.test.ref = TestLogger appender.testlogger.name = TestLogger diff --git a/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-doris/src/test/resources/log4j2-test.properties b/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-doris/src/test/resources/log4j2-test.properties index f0d32fb59..32df1c025 100644 --- a/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-doris/src/test/resources/log4j2-test.properties +++ b/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-doris/src/test/resources/log4j2-test.properties @@ -13,9 +13,9 @@ # limitations under the License. ################################################################################ -# Set root logger level to OFF to not flood build logs +# Set root logger level to ERROR to not flood build logs # set manually to INFO for debugging purposes -rootLogger.level=INFO +rootLogger.level=ERROR rootLogger.appenderRef.test.ref = TestLogger appender.testlogger.name = TestLogger diff --git a/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-elasticsearch/src/test/java/org/apache/flink/cdc/connectors/elasticsearch/sink/Elasticsearch6DataSinkITCaseTest.java b/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-elasticsearch/src/test/java/org/apache/flink/cdc/connectors/elasticsearch/sink/Elasticsearch6DataSinkITCaseTest.java index b8cb39ddf..47e61a71f 100644 --- a/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-elasticsearch/src/test/java/org/apache/flink/cdc/connectors/elasticsearch/sink/Elasticsearch6DataSinkITCaseTest.java +++ b/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-elasticsearch/src/test/java/org/apache/flink/cdc/connectors/elasticsearch/sink/Elasticsearch6DataSinkITCaseTest.java @@ -86,7 +86,7 @@ public class Elasticsearch6DataSinkITCaseTest { @Test public void testElasticsearchSink() throws Exception { TableId tableId = TableId.tableId("default", "schema", "table"); - List events = ElasticsearchTestUtils.createTestEvents(tableId); // 使用工具类 + List events = ElasticsearchTestUtils.createTestEvents(tableId); runJobWithEvents(events); @@ -121,7 +121,7 @@ public class Elasticsearch6DataSinkITCaseTest { @Test public void testElasticsearchInsertAndDelete() throws Exception { TableId tableId = TableId.tableId("default", "schema", "table"); - List events = ElasticsearchTestUtils.createTestEventsWithDelete(tableId); // 使用工具类 + List events = ElasticsearchTestUtils.createTestEventsWithDelete(tableId); runJobWithEvents(events); @@ -131,7 +131,7 @@ public class Elasticsearch6DataSinkITCaseTest { @Test public void testElasticsearchAddColumn() throws Exception { TableId tableId = TableId.tableId("default", "schema", "table"); - List events = ElasticsearchTestUtils.createTestEventsWithAddColumn(tableId); // 使用工具类 + List events = ElasticsearchTestUtils.createTestEventsWithAddColumn(tableId); runJobWithEvents(events); diff --git a/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-elasticsearch/src/test/java/org/apache/flink/cdc/connectors/elasticsearch/sink/Elasticsearch7DataSinkITCaseTest.java b/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-elasticsearch/src/test/java/org/apache/flink/cdc/connectors/elasticsearch/sink/Elasticsearch7DataSinkITCaseTest.java index 8644a6af9..4539f96bf 100644 --- a/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-elasticsearch/src/test/java/org/apache/flink/cdc/connectors/elasticsearch/sink/Elasticsearch7DataSinkITCaseTest.java +++ b/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-elasticsearch/src/test/java/org/apache/flink/cdc/connectors/elasticsearch/sink/Elasticsearch7DataSinkITCaseTest.java @@ -92,7 +92,7 @@ public class Elasticsearch7DataSinkITCaseTest { @Test public void testElasticsearchSink() throws Exception { TableId tableId = TableId.tableId("default", "schema", "table"); - List events = ElasticsearchTestUtils.createTestEvents(tableId); // 使用工具类 + List events = ElasticsearchTestUtils.createTestEvents(tableId); runJobWithEvents(events); @@ -127,7 +127,7 @@ public class Elasticsearch7DataSinkITCaseTest { @Test public void testElasticsearchInsertAndDelete() throws Exception { TableId tableId = TableId.tableId("default", "schema", "table"); - List events = ElasticsearchTestUtils.createTestEventsWithDelete(tableId); // 使用工具类 + List events = ElasticsearchTestUtils.createTestEventsWithDelete(tableId); runJobWithEvents(events); @@ -137,7 +137,7 @@ public class Elasticsearch7DataSinkITCaseTest { @Test public void testElasticsearchAddColumn() throws Exception { TableId tableId = TableId.tableId("default", "schema", "table"); - List events = ElasticsearchTestUtils.createTestEventsWithAddColumn(tableId); // 使用工具类 + List events = ElasticsearchTestUtils.createTestEventsWithAddColumn(tableId); runJobWithEvents(events); diff --git a/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-elasticsearch/src/test/java/org/apache/flink/cdc/connectors/elasticsearch/sink/ElasticsearchDataSinkFactoryTest.java b/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-elasticsearch/src/test/java/org/apache/flink/cdc/connectors/elasticsearch/sink/ElasticsearchDataSinkFactoryTest.java index 32835349d..56ce6199e 100644 --- a/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-elasticsearch/src/test/java/org/apache/flink/cdc/connectors/elasticsearch/sink/ElasticsearchDataSinkFactoryTest.java +++ b/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-elasticsearch/src/test/java/org/apache/flink/cdc/connectors/elasticsearch/sink/ElasticsearchDataSinkFactoryTest.java @@ -1,18 +1,20 @@ /* - * Licensed to the Apache Software Foundation (ASF) under one或多个 - * contributor license agreements. See the NOTICE file distributed with - * this work for additional信息 regarding copyright ownership. - * The ASF licenses this file to You under the Apache License, Version 2.0 - * (the "License"); you may not use this file except in compliance with - * the License. You may obtain a copy of the License at + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * http://www.apache.org/licenses/LICENSE-2.0 * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express或 implied. - * See the License for the specific language governing permissions and - * limitations under the License. + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. */ package org.apache.flink.cdc.connectors.elasticsearch.sink; @@ -29,6 +31,8 @@ import org.apache.flink.shaded.guava31.com.google.common.collect.ImmutableMap; import org.assertj.core.api.Assertions; import org.junit.jupiter.api.Test; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; import java.util.HashMap; import java.util.List; @@ -38,6 +42,9 @@ import java.util.stream.Collectors; /** Tests for {@link ElasticsearchDataSinkFactory}. */ public class ElasticsearchDataSinkFactoryTest { + private static final Logger LOG = + LoggerFactory.getLogger(ElasticsearchDataSinkFactoryTest.class); + private static final String ELASTICSEARCH_IDENTIFIER = "elasticsearch"; /** Tests the creation of an Elasticsearch DataSink with valid configuration. */ @@ -57,15 +64,11 @@ public class ElasticsearchDataSinkFactoryTest { DataSinkFactory sinkFactory = getElasticsearchDataSinkFactory(); List requiredKeys = getRequiredKeys(sinkFactory); for (String requiredKey : requiredKeys) { - // 创建一个新的配置 Map，包含所有必需选项 Map options = new HashMap<>(createValidOptions()); - // 移除当前正在测试的必需选项 options.remove(requiredKey); Configuration conf = Configuration.fromMap(options); - // 打印日志以确保我们在测试缺少必需选项的情况 - System.out.println("Testing missing required option: " + requiredKey); + LOG.info("Testing missing required option: {}", requiredKey); - // 添加创建 DataSink 对象的代码 Assertions.assertThatThrownBy(() -> createDataSink(sinkFactory, conf)) // Assertions to check for missing required option @@ -92,8 +95,7 @@ public class ElasticsearchDataSinkFactoryTest { .put("unsupported_key", "unsupported_value") .build()); - // 打印日志以确保我们在测试不受支持的选项 - System.out.println("Testing unsupported option"); + LOG.info("Testing unsupported option"); // Assertions to check for unsupported options Assertions.assertThatThrownBy(() -> createDataSink(sinkFactory, conf)) @@ -121,8 +123,7 @@ public class ElasticsearchDataSinkFactoryTest { .put("version", "7") // Added version to the test configuration .build()); - // 打印日志以确保我们在测试带前缀的必需选项 - System.out.println("Testing prefixed required option"); + LOG.info("Testing prefixed required option"); DataSink dataSink = createDataSink(sinkFactory, conf); Assertions.assertThat(dataSink).isInstanceOf(ElasticsearchDataSink.class); diff --git a/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-elasticsearch/src/test/java/org/apache/flink/cdc/connectors/elasticsearch/sink/ElasticsearchDataSinkITCaseTest.java b/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-elasticsearch/src/test/java/org/apache/flink/cdc/connectors/elasticsearch/sink/ElasticsearchDataSinkITCaseTest.java index ce8a25d49..e655ba406 100644 --- a/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-elasticsearch/src/test/java/org/apache/flink/cdc/connectors/elasticsearch/sink/ElasticsearchDataSinkITCaseTest.java +++ b/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-elasticsearch/src/test/java/org/apache/flink/cdc/connectors/elasticsearch/sink/ElasticsearchDataSinkITCaseTest.java @@ -94,7 +94,7 @@ public class ElasticsearchDataSinkITCaseTest { @Test public void testElasticsearchSink() throws Exception { TableId tableId = TableId.tableId("default", "schema", "table"); - List events = ElasticsearchTestUtils.createTestEvents(tableId); // 使用工具类 + List events = ElasticsearchTestUtils.createTestEvents(tableId); runJobWithEvents(events); @@ -129,7 +129,7 @@ public class ElasticsearchDataSinkITCaseTest { @Test public void testElasticsearchInsertAndDelete() throws Exception { TableId tableId = TableId.tableId("default", "schema", "table"); - List events = ElasticsearchTestUtils.createTestEventsWithDelete(tableId); // 使用工具类 + List events = ElasticsearchTestUtils.createTestEventsWithDelete(tableId); runJobWithEvents(events); @@ -139,7 +139,7 @@ public class ElasticsearchDataSinkITCaseTest { @Test public void testElasticsearchAddColumn() throws Exception { TableId tableId = TableId.tableId("default", "schema", "table"); - List events = ElasticsearchTestUtils.createTestEventsWithAddColumn(tableId); // 使用工具类 + List events = ElasticsearchTestUtils.createTestEventsWithAddColumn(tableId); runJobWithEvents(events); diff --git a/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-elasticsearch/src/test/resources/log4j2-test.properties b/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-elasticsearch/src/test/resources/log4j2-test.properties index 1eebcb739..0d45bab80 100644 --- a/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-elasticsearch/src/test/resources/log4j2-test.properties +++ b/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-elasticsearch/src/test/resources/log4j2-test.properties @@ -13,9 +13,9 @@ # limitations under the License. ################################################################################ -# Set root logger level to OFF to not flood build logs +# Set root logger level to ERROR to not flood build logs # set manually to INFO for debugging purposes -rootLogger.level = INFO +rootLogger.level = ERROR rootLogger.appenderRef.test.ref = TestLogger appender.testlogger.name = TestLogger diff --git a/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-kafka/src/test/resources/log4j2-test.properties b/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-kafka/src/test/resources/log4j2-test.properties index a9d045e0e..5fe3b384b 100644 --- a/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-kafka/src/test/resources/log4j2-test.properties +++ b/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-kafka/src/test/resources/log4j2-test.properties @@ -14,9 +14,9 @@ # limitations under the License. ################################################################################ -# Set root logger level to OFF to not flood build logs +# Set root logger level to ERROR to not flood build logs # set manually to INFO for debugging purposes -rootLogger.level=INFO +rootLogger.level=ERROR rootLogger.appenderRef.test.ref = TestLogger appender.testlogger.name = TestLogger diff --git a/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-maxcompute/src/test/java/org/apache/flink/cdc/connectors/maxcompute/EmulatorTestBase.java b/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-maxcompute/src/test/java/org/apache/flink/cdc/connectors/maxcompute/EmulatorTestBase.java index 6d40c3c41..717058ec6 100644 --- a/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-maxcompute/src/test/java/org/apache/flink/cdc/connectors/maxcompute/EmulatorTestBase.java +++ b/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-maxcompute/src/test/java/org/apache/flink/cdc/connectors/maxcompute/EmulatorTestBase.java @@ -22,7 +22,10 @@ import org.apache.flink.cdc.connectors.maxcompute.utils.MaxComputeUtils; import com.aliyun.odps.Odps; import org.junit.ClassRule; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; import org.testcontainers.containers.GenericContainer; +import org.testcontainers.containers.output.Slf4jLogConsumer; import org.testcontainers.containers.wait.strategy.Wait; import org.testcontainers.utility.DockerImageName; @@ -34,6 +37,9 @@ import java.net.UnknownHostException; /** init maxcompute-emulator use for e2e test. */ public class EmulatorTestBase { + + private static final Logger LOG = LoggerFactory.getLogger(EmulatorTestBase.class); + public static final DockerImageName MAXCOMPUTE_IMAGE = DockerImageName.parse("maxcompute/maxcompute-emulator:v0.0.4"); @@ -43,7 +49,7 @@ public class EmulatorTestBase { .withExposedPorts(8080) .waitingFor( Wait.forLogMessage(".*Started MaxcomputeEmulatorApplication.*\\n", 1)) - .withLogConsumer(frame -> System.out.print(frame.getUtf8String())); + .withLogConsumer(new Slf4jLogConsumer(LOG)); public final MaxComputeOptions testOptions = MaxComputeOptions.builder("ak", "sk", getEndpoint(), "mocked_mc").build(); diff --git a/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-maxcompute/src/test/resources/log4j2-test.properties b/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-maxcompute/src/test/resources/log4j2-test.properties index f0d32fb59..32df1c025 100644 --- a/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-maxcompute/src/test/resources/log4j2-test.properties +++ b/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-maxcompute/src/test/resources/log4j2-test.properties @@ -13,9 +13,9 @@ # limitations under the License. ################################################################################ -# Set root logger level to OFF to not flood build logs +# Set root logger level to ERROR to not flood build logs # set manually to INFO for debugging purposes -rootLogger.level=INFO +rootLogger.level=ERROR rootLogger.appenderRef.test.ref = TestLogger appender.testlogger.name = TestLogger diff --git a/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/test/resources/log4j2-test.properties b/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/test/resources/log4j2-test.properties index f0d32fb59..32df1c025 100644 --- a/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/test/resources/log4j2-test.properties +++ b/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/test/resources/log4j2-test.properties @@ -13,9 +13,9 @@ # limitations under the License. ################################################################################ -# Set root logger level to OFF to not flood build logs +# Set root logger level to ERROR to not flood build logs # set manually to INFO for debugging purposes -rootLogger.level=INFO +rootLogger.level=ERROR rootLogger.appenderRef.test.ref = TestLogger appender.testlogger.name = TestLogger diff --git a/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-paimon/src/test/resources/log4j2-test.properties b/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-paimon/src/test/resources/log4j2-test.properties index 8f6c07473..32df1c025 100644 --- a/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-paimon/src/test/resources/log4j2-test.properties +++ b/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-paimon/src/test/resources/log4j2-test.properties @@ -13,9 +13,9 @@ # limitations under the License. ################################################################################ -# Set root logger level to OFF to not flood build logs +# Set root logger level to ERROR to not flood build logs # set manually to INFO for debugging purposes -rootLogger.level=OFF +rootLogger.level=ERROR rootLogger.appenderRef.test.ref = TestLogger appender.testlogger.name = TestLogger diff --git a/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-starrocks/src/test/resources/log4j2-test.properties b/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-starrocks/src/test/resources/log4j2-test.properties index 8f6c07473..32df1c025 100644 --- a/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-starrocks/src/test/resources/log4j2-test.properties +++ b/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-starrocks/src/test/resources/log4j2-test.properties @@ -13,9 +13,9 @@ # limitations under the License. ################################################################################ -# Set root logger level to OFF to not flood build logs +# Set root logger level to ERROR to not flood build logs # set manually to INFO for debugging purposes -rootLogger.level=OFF +rootLogger.level=ERROR rootLogger.appenderRef.test.ref = TestLogger appender.testlogger.name = TestLogger diff --git a/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-values/src/test/resources/log4j2-test.properties b/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-values/src/test/resources/log4j2-test.properties index 8f6c07473..32df1c025 100644 --- a/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-values/src/test/resources/log4j2-test.properties +++ b/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-values/src/test/resources/log4j2-test.properties @@ -13,9 +13,9 @@ # limitations under the License. ################################################################################ -# Set root logger level to OFF to not flood build logs +# Set root logger level to ERROR to not flood build logs # set manually to INFO for debugging purposes -rootLogger.level=OFF +rootLogger.level=ERROR rootLogger.appenderRef.test.ref = TestLogger appender.testlogger.name = TestLogger diff --git a/flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/test/resources/log4j2-test.properties b/flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/test/resources/log4j2-test.properties index f0d32fb59..32df1c025 100644 --- a/flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/test/resources/log4j2-test.properties +++ b/flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/test/resources/log4j2-test.properties @@ -13,9 +13,9 @@ # limitations under the License. ################################################################################ -# Set root logger level to OFF to not flood build logs +# Set root logger level to ERROR to not flood build logs # set manually to INFO for debugging purposes -rootLogger.level=INFO +rootLogger.level=ERROR rootLogger.appenderRef.test.ref = TestLogger appender.testlogger.name = TestLogger diff --git a/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-db2-cdc/src/main/java/org/apache/flink/cdc/connectors/db2/table/StartupOptions.java b/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-db2-cdc/src/main/java/org/apache/flink/cdc/connectors/db2/table/StartupOptions.java index bac47c6b1..13bf9d281 100644 --- a/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-db2-cdc/src/main/java/org/apache/flink/cdc/connectors/db2/table/StartupOptions.java +++ b/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-db2-cdc/src/main/java/org/apache/flink/cdc/connectors/db2/table/StartupOptions.java @@ -28,7 +28,7 @@ public final class StartupOptions { /** * Performs an initial snapshot on the monitored database tables upon first startup, and - * continue to read change events from the database’s redo logs. + * continue to read change events from the database's redo logs. */ public static StartupOptions initial() { return new StartupOptions(StartupMode.INITIAL); diff --git a/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-db2-cdc/src/test/resources/log4j2-test.properties b/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-db2-cdc/src/test/resources/log4j2-test.properties index f0d32fb59..32df1c025 100644 --- a/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-db2-cdc/src/test/resources/log4j2-test.properties +++ b/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-db2-cdc/src/test/resources/log4j2-test.properties @@ -13,9 +13,9 @@ # limitations under the License. ################################################################################ -# Set root logger level to OFF to not flood build logs +# Set root logger level to ERROR to not flood build logs # set manually to INFO for debugging purposes -rootLogger.level=INFO +rootLogger.level=ERROR rootLogger.appenderRef.test.ref = TestLogger appender.testlogger.name = TestLogger diff --git a/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mongodb-cdc/src/test/resources/log4j2-test.properties b/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mongodb-cdc/src/test/resources/log4j2-test.properties index f0d32fb59..32df1c025 100644 --- a/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mongodb-cdc/src/test/resources/log4j2-test.properties +++ b/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mongodb-cdc/src/test/resources/log4j2-test.properties @@ -13,9 +13,9 @@ # limitations under the License. ################################################################################ -# Set root logger level to OFF to not flood build logs +# Set root logger level to ERROR to not flood build logs # set manually to INFO for debugging purposes -rootLogger.level=INFO +rootLogger.level=ERROR rootLogger.appenderRef.test.ref = TestLogger appender.testlogger.name = TestLogger diff --git a/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/io/debezium/connector/mysql/converters/MysqlDebeziumTimeConverter.java b/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/io/debezium/connector/mysql/converters/MysqlDebeziumTimeConverter.java index 753bb8f2d..a05db4ed0 100644 --- a/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/io/debezium/connector/mysql/converters/MysqlDebeziumTimeConverter.java +++ b/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/io/debezium/connector/mysql/converters/MysqlDebeziumTimeConverter.java @@ -44,7 +44,7 @@ import java.util.concurrent.TimeUnit; /** * Debezium converts the datetime type in MySQL into a UTC timestamp by default ({@link - * io.debezium.time.Timestamp} )，The time zone is hard-coded and cannot be changed. causing + * io.debezium.time.Timestamp} ), The time zone is hard-coded and cannot be changed. causing * conversion errors part of the time Enable this converter to convert the four times "DATE", * "DATETIME", "TIME", and "TIMESTAMP" into the format corresponding to the configured time zone * (for example, yyyy-MM-dd) diff --git a/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/test/resources/log4j2-test.properties b/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/test/resources/log4j2-test.properties index f0d32fb59..32df1c025 100644 --- a/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/test/resources/log4j2-test.properties +++ b/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/test/resources/log4j2-test.properties @@ -13,9 +13,9 @@ # limitations under the License. ################################################################################ -# Set root logger level to OFF to not flood build logs +# Set root logger level to ERROR to not flood build logs # set manually to INFO for debugging purposes -rootLogger.level=INFO +rootLogger.level=ERROR rootLogger.appenderRef.test.ref = TestLogger appender.testlogger.name = TestLogger diff --git a/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-oceanbase-cdc/src/test/resources/log4j2-test.properties b/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-oceanbase-cdc/src/test/resources/log4j2-test.properties index f0d32fb59..32df1c025 100644 --- a/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-oceanbase-cdc/src/test/resources/log4j2-test.properties +++ b/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-oceanbase-cdc/src/test/resources/log4j2-test.properties @@ -13,9 +13,9 @@ # limitations under the License. ################################################################################ -# Set root logger level to OFF to not flood build logs +# Set root logger level to ERROR to not flood build logs # set manually to INFO for debugging purposes -rootLogger.level=INFO +rootLogger.level=ERROR rootLogger.appenderRef.test.ref = TestLogger appender.testlogger.name = TestLogger diff --git a/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-oracle-cdc/src/test/resources/log4j2-test.properties b/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-oracle-cdc/src/test/resources/log4j2-test.properties index f0d32fb59..32df1c025 100644 --- a/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-oracle-cdc/src/test/resources/log4j2-test.properties +++ b/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-oracle-cdc/src/test/resources/log4j2-test.properties @@ -13,9 +13,9 @@ # limitations under the License. ################################################################################ -# Set root logger level to OFF to not flood build logs +# Set root logger level to ERROR to not flood build logs # set manually to INFO for debugging purposes -rootLogger.level=INFO +rootLogger.level=ERROR rootLogger.appenderRef.test.ref = TestLogger appender.testlogger.name = TestLogger diff --git a/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-postgres-cdc/src/test/resources/log4j2-test.properties b/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-postgres-cdc/src/test/resources/log4j2-test.properties index f0d32fb59..32df1c025 100644 --- a/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-postgres-cdc/src/test/resources/log4j2-test.properties +++ b/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-postgres-cdc/src/test/resources/log4j2-test.properties @@ -13,9 +13,9 @@ # limitations under the License. ################################################################################ -# Set root logger level to OFF to not flood build logs +# Set root logger level to ERROR to not flood build logs # set manually to INFO for debugging purposes -rootLogger.level=INFO +rootLogger.level=ERROR rootLogger.appenderRef.test.ref = TestLogger appender.testlogger.name = TestLogger diff --git a/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-sqlserver-cdc/src/test/resources/log4j2-test.properties b/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-sqlserver-cdc/src/test/resources/log4j2-test.properties index f0d32fb59..32df1c025 100644 --- a/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-sqlserver-cdc/src/test/resources/log4j2-test.properties +++ b/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-sqlserver-cdc/src/test/resources/log4j2-test.properties @@ -13,9 +13,9 @@ # limitations under the License. ################################################################################ -# Set root logger level to OFF to not flood build logs +# Set root logger level to ERROR to not flood build logs # set manually to INFO for debugging purposes -rootLogger.level=INFO +rootLogger.level=ERROR rootLogger.appenderRef.test.ref = TestLogger appender.testlogger.name = TestLogger diff --git a/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-tidb-cdc/src/test/resources/log4j2-test.properties b/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-tidb-cdc/src/test/resources/log4j2-test.properties index f0d32fb59..32df1c025 100644 --- a/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-tidb-cdc/src/test/resources/log4j2-test.properties +++ b/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-tidb-cdc/src/test/resources/log4j2-test.properties @@ -13,9 +13,9 @@ # limitations under the License. ################################################################################ -# Set root logger level to OFF to not flood build logs +# Set root logger level to ERROR to not flood build logs # set manually to INFO for debugging purposes -rootLogger.level=INFO +rootLogger.level=ERROR rootLogger.appenderRef.test.ref = TestLogger appender.testlogger.name = TestLogger diff --git a/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-vitess-cdc/src/test/resources/log4j2-test.properties b/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-vitess-cdc/src/test/resources/log4j2-test.properties index f0d32fb59..32df1c025 100644 --- a/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-vitess-cdc/src/test/resources/log4j2-test.properties +++ b/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-vitess-cdc/src/test/resources/log4j2-test.properties @@ -13,9 +13,9 @@ # limitations under the License. ################################################################################ -# Set root logger level to OFF to not flood build logs +# Set root logger level to ERROR to not flood build logs # set manually to INFO for debugging purposes -rootLogger.level=INFO +rootLogger.level=ERROR rootLogger.appenderRef.test.ref = TestLogger appender.testlogger.name = TestLogger diff --git a/flink-cdc-e2e-tests/flink-cdc-pipeline-e2e-tests/src/test/java/org/apache/flink/cdc/pipeline/tests/MaxComputeE2eITCase.java b/flink-cdc-e2e-tests/flink-cdc-pipeline-e2e-tests/src/test/java/org/apache/flink/cdc/pipeline/tests/MaxComputeE2eITCase.java index 9aa78cada..8717cf8f1 100644 --- a/flink-cdc-e2e-tests/flink-cdc-pipeline-e2e-tests/src/test/java/org/apache/flink/cdc/pipeline/tests/MaxComputeE2eITCase.java +++ b/flink-cdc-e2e-tests/flink-cdc-pipeline-e2e-tests/src/test/java/org/apache/flink/cdc/pipeline/tests/MaxComputeE2eITCase.java @@ -37,6 +37,7 @@ import org.junit.Test; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import org.testcontainers.containers.GenericContainer; +import org.testcontainers.containers.output.Slf4jLogConsumer; import org.testcontainers.containers.wait.strategy.Wait; import org.testcontainers.utility.DockerImageName; @@ -64,7 +65,7 @@ public class MaxComputeE2eITCase extends PipelineTestEnvironment { .withExposedPorts(8080) .waitingFor( Wait.forLogMessage(".*Started MaxcomputeEmulatorApplication.*\\n", 1)) - .withLogConsumer(frame -> System.out.print(frame.getUtf8String())); + .withLogConsumer(new Slf4jLogConsumer(LOG)); public final MaxComputeOptions testOptions = MaxComputeOptions.builder("ak", "sk", getEndpoint(), "mocked_mc") @@ -80,7 +81,7 @@ public class MaxComputeE2eITCase extends PipelineTestEnvironment { "select * from table1 order by col1;"); instance.waitForSuccess(); List result = SQLTask.getResult(instance); - System.out.println(result); + LOG.info("{}", result); Assert.assertEquals(2, result.size()); // 2,x Assert.assertEquals("2", result.get(0).get(0)); diff --git a/flink-cdc-e2e-tests/flink-cdc-pipeline-e2e-tests/src/test/resources/log4j2-test.properties b/flink-cdc-e2e-tests/flink-cdc-pipeline-e2e-tests/src/test/resources/log4j2-test.properties index a9d045e0e..5fe3b384b 100644 --- a/flink-cdc-e2e-tests/flink-cdc-pipeline-e2e-tests/src/test/resources/log4j2-test.properties +++ b/flink-cdc-e2e-tests/flink-cdc-pipeline-e2e-tests/src/test/resources/log4j2-test.properties @@ -14,9 +14,9 @@ # limitations under the License. ################################################################################ -# Set root logger level to OFF to not flood build logs +# Set root logger level to ERROR to not flood build logs # set manually to INFO for debugging purposes -rootLogger.level=INFO +rootLogger.level=ERROR rootLogger.appenderRef.test.ref = TestLogger appender.testlogger.name = TestLogger diff --git a/flink-cdc-e2e-tests/flink-cdc-source-e2e-tests/src/test/java/org/apache/flink/cdc/connectors/tests/utils/FlinkContainerTestEnvironment.java b/flink-cdc-e2e-tests/flink-cdc-source-e2e-tests/src/test/java/org/apache/flink/cdc/connectors/tests/utils/FlinkContainerTestEnvironment.java index 4614a582e..c924c98ed 100644 --- a/flink-cdc-e2e-tests/flink-cdc-source-e2e-tests/src/test/java/org/apache/flink/cdc/connectors/tests/utils/FlinkContainerTestEnvironment.java +++ b/flink-cdc-e2e-tests/flink-cdc-source-e2e-tests/src/test/java/org/apache/flink/cdc/connectors/tests/utils/FlinkContainerTestEnvironment.java @@ -186,7 +186,8 @@ public abstract class FlinkContainerTestEnvironment extends TestLogger { dockerClient.removeContainerCmd(container.getId()).exec(); }); - // List all images and remove the ones that are not flink、mysql、testcontainers related. + // List all images and remove the ones that are not Flink, MySQL, and TestContainers + // related. dockerClient.listImagesCmd().exec().stream() .filter( image -> diff --git a/flink-cdc-e2e-tests/flink-cdc-source-e2e-tests/src/test/resources/log4j2-test.properties b/flink-cdc-e2e-tests/flink-cdc-source-e2e-tests/src/test/resources/log4j2-test.properties index f0d32fb59..32df1c025 100644 --- a/flink-cdc-e2e-tests/flink-cdc-source-e2e-tests/src/test/resources/log4j2-test.properties +++ b/flink-cdc-e2e-tests/flink-cdc-source-e2e-tests/src/test/resources/log4j2-test.properties @@ -13,9 +13,9 @@ # limitations under the License. ################################################################################ -# Set root logger level to OFF to not flood build logs +# Set root logger level to ERROR to not flood build logs # set manually to INFO for debugging purposes -rootLogger.level=INFO +rootLogger.level=ERROR rootLogger.appenderRef.test.ref = TestLogger appender.testlogger.name = TestLogger diff --git a/flink-cdc-migration-tests/flink-cdc-migration-testcases/src/test/resources/log4j2-test.properties b/flink-cdc-migration-tests/flink-cdc-migration-testcases/src/test/resources/log4j2-test.properties index f0d32fb59..32df1c025 100644 --- a/flink-cdc-migration-tests/flink-cdc-migration-testcases/src/test/resources/log4j2-test.properties +++ b/flink-cdc-migration-tests/flink-cdc-migration-testcases/src/test/resources/log4j2-test.properties @@ -13,9 +13,9 @@ # limitations under the License. ################################################################################ -# Set root logger level to OFF to not flood build logs +# Set root logger level to ERROR to not flood build logs # set manually to INFO for debugging purposes -rootLogger.level=INFO +rootLogger.level=ERROR rootLogger.appenderRef.test.ref = TestLogger appender.testlogger.name = TestLogger diff --git a/flink-cdc-runtime/src/test/java/org/apache/flink/cdc/runtime/serializer/SerializerTestBase.java b/flink-cdc-runtime/src/test/java/org/apache/flink/cdc/runtime/serializer/SerializerTestBase.java index ea224d2ac..db91c4a8c 100644 --- a/flink-cdc-runtime/src/test/java/org/apache/flink/cdc/runtime/serializer/SerializerTestBase.java +++ b/flink-cdc-runtime/src/test/java/org/apache/flink/cdc/runtime/serializer/SerializerTestBase.java @@ -38,6 +38,8 @@ import org.apache.commons.lang3.SerializationException; import org.junit.Assert; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.extension.ExtendWith; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; import java.io.ByteArrayInputStream; import java.io.ByteArrayOutputStream; @@ -65,6 +67,8 @@ import static org.junit.Assert.fail; @ExtendWith(TestLoggerExtension.class) public abstract class SerializerTestBase { + private static final Logger LOG = LoggerFactory.getLogger(SerializerTestBase.class); + private final DeeplyEqualsChecker checker; protected SerializerTestBase() { @@ -123,8 +127,7 @@ public abstract class SerializerTestBase { + instance.getClass()); } } catch (Exception e) { - System.err.println(e.getMessage()); - e.printStackTrace(); + LOG.error("", e); fail("Exception in test: " + e.getMessage()); } } @@ -181,8 +184,7 @@ public abstract class SerializerTestBase { TypeSerializer serializer = getSerializer(); assertEquals(len, serializer.getLength()); } catch (Exception e) { - System.err.println(e.getMessage()); - e.printStackTrace(); + LOG.error("", e); fail("Exception in test: " + e.getMessage()); } } @@ -199,8 +201,7 @@ public abstract class SerializerTestBase { deepEquals("Copied element is not equal to the original element.", datum, copy); } } catch (Exception e) { - System.err.println(e.getMessage()); - e.printStackTrace(); + LOG.error("", e); fail("Exception in test: " + e.getMessage()); } } @@ -217,8 +218,7 @@ public abstract class SerializerTestBase { deepEquals("Copied element is not equal to the original element.", datum, copy); } } catch (Exception e) { - System.err.println(e.getMessage()); - e.printStackTrace(); + LOG.error("", e); fail("Exception in test: " + e.getMessage()); } } @@ -238,8 +238,7 @@ public abstract class SerializerTestBase { target = copy; } } catch (Exception e) { - System.err.println(e.getMessage()); - e.printStackTrace(); + LOG.error("", e); fail("Exception in test: " + e.getMessage()); } } @@ -265,8 +264,7 @@ public abstract class SerializerTestBase { assertTrue("Trailing data available after deserialization.", in.available() == 0); } } catch (Exception e) { - System.err.println(e.getMessage()); - e.printStackTrace(); + LOG.error("", e); fail("Exception in test: " + e.getMessage()); } } @@ -296,8 +294,7 @@ public abstract class SerializerTestBase { reuseValue = deserialized; } } catch (Exception e) { - System.err.println(e.getMessage()); - e.printStackTrace(); + LOG.error("", e); fail("Exception in test: " + e.getMessage()); } } @@ -326,8 +323,7 @@ public abstract class SerializerTestBase { assertEquals("Wrong number of elements deserialized.", testData.length, num); } catch (Exception e) { - System.err.println(e.getMessage()); - e.printStackTrace(); + LOG.error("", e); fail("Exception in test: " + e.getMessage()); } } @@ -358,8 +354,7 @@ public abstract class SerializerTestBase { assertEquals("Wrong number of elements deserialized.", testData.length, num); } catch (Exception e) { - System.err.println(e.getMessage()); - e.printStackTrace(); + LOG.error("", e); fail("Exception in test: " + e.getMessage()); } } @@ -392,8 +387,7 @@ public abstract class SerializerTestBase { toVerify.available() == 0); } } catch (Exception e) { - System.err.println(e.getMessage()); - e.printStackTrace(); + LOG.error("", e); fail("Exception in test: " + e.getMessage()); } } @@ -428,8 +422,7 @@ public abstract class SerializerTestBase { assertEquals("Wrong number of elements copied.", testData.length, num); } catch (Exception e) { - System.err.println(e.getMessage()); - e.printStackTrace(); + LOG.error("", e); fail("Exception in test: " + e.getMessage()); } } @@ -449,8 +442,7 @@ public abstract class SerializerTestBase { assertEquals( "The copy of the serializer is not equal to the original one.", ser1, ser2); } catch (Exception e) { - System.err.println(e.getMessage()); - e.printStackTrace(); + LOG.error("", e); fail("Exception in test: " + e.getMessage()); } } @@ -461,8 +453,7 @@ public abstract class SerializerTestBase { try { NullableSerializer.checkIfNullSupported(serializer); } catch (Throwable t) { - System.err.println(t.getMessage()); - t.printStackTrace(); + LOG.error("", t); fail("Unexpected failure of null value handling: " + t.getMessage()); } } diff --git a/flink-cdc-runtime/src/test/java/org/apache/flink/cdc/runtime/serializer/schema/DataTypeSerializerTest.java b/flink-cdc-runtime/src/test/java/org/apache/flink/cdc/runtime/serializer/schema/DataTypeSerializerTest.java index 3e822dcef..ab0c20065 100644 --- a/flink-cdc-runtime/src/test/java/org/apache/flink/cdc/runtime/serializer/schema/DataTypeSerializerTest.java +++ b/flink-cdc-runtime/src/test/java/org/apache/flink/cdc/runtime/serializer/schema/DataTypeSerializerTest.java @@ -28,6 +28,8 @@ import org.apache.flink.core.memory.DataOutputView; import org.apache.flink.core.memory.DataOutputViewStreamWrapper; import org.junit.jupiter.api.Test; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; import java.io.ByteArrayInputStream; import java.io.ByteArrayOutputStream; @@ -40,6 +42,9 @@ import static org.junit.jupiter.api.Assertions.assertNotNull; /** A test for the {@link DataTypeSerializer}. */ public class DataTypeSerializerTest extends SerializerTestBase { + + private static final Logger LOG = LoggerFactory.getLogger(DataTypeSerializerTest.class); + @Override protected TypeSerializer createSerializer() { return new DataTypeSerializer(); @@ -104,12 +109,12 @@ public class DataTypeSerializerTest extends SerializerTestBase { // Log to ensure INSTANCE is initialized assertNotNull(RowTypeSerializer.INSTANCE, "RowTypeSerializer.INSTANCE is null"); - System.out.println("RowTypeSerializer.INSTANCE is initialized"); + LOG.info("RowTypeSerializer.INSTANCE is initialized"); // Copy the RowType RowType copiedRow = (RowType) serializer.copy(outerRowType); assertNotNull(copiedRow, "Copied RowType is null"); - System.out.println("Copied RowType: " + copiedRow); + LOG.info("Copied RowType: {}", copiedRow); // Serialize the RowType ByteArrayOutputStream byteArrayOutputStream = new ByteArrayOutputStream(); @@ -126,6 +131,6 @@ public class DataTypeSerializerTest extends SerializerTestBase { assertNotNull(deserializedRow, "Deserialized RowType is null"); assertEquals( outerRowType, deserializedRow, "Deserialized RowType does not match the original"); - System.out.println("Deserialized RowType: " + deserializedRow); + LOG.info("Deserialized RowType: {}", deserializedRow); } } diff --git a/flink-cdc-runtime/src/test/resources/log4j2-test.properties b/flink-cdc-runtime/src/test/resources/log4j2-test.properties index 1eebcb739..0d45bab80 100644 --- a/flink-cdc-runtime/src/test/resources/log4j2-test.properties +++ b/flink-cdc-runtime/src/test/resources/log4j2-test.properties @@ -13,9 +13,9 @@ # limitations under the License. ################################################################################ -# Set root logger level to OFF to not flood build logs +# Set root logger level to ERROR to not flood build logs # set manually to INFO for debugging purposes -rootLogger.level = INFO +rootLogger.level = ERROR rootLogger.appenderRef.test.ref = TestLogger appender.testlogger.name = TestLogger