From b888b85119db7adde3d9399c9d9bd1d0079731f4 Mon Sep 17 00:00:00 2001 From: Mahmoud Ben Hassine Date: Sun, 31 May 2020 10:48:39 +0200 Subject: [PATCH] Polish 8748d602b26a444858e6ce85d7b4b246365a17d7 * Rename method `rulesCount` to `size` * Add Desislav-Petrov to contributors list --- README.md | 1 + .../src/main/java/org/jeasy/rules/api/Rules.java | 4 ++-- .../src/test/java/org/jeasy/rules/api/RulesTest.java | 8 ++++---- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/README.md b/README.md index 7d56bb6..0c11746 100644 --- a/README.md +++ b/README.md @@ -139,6 +139,7 @@ For any question, you can use [StackOverflow](https://stackoverflow.com/question * [cemo](https://github.com/cemo) * [dagframstad](https://github.com/dagframstad) * [danrivcap](https://github.com/danrivcap) +* [Desislav-Petrov](https://github.com/Desislav-Petrov) * [drem-darios](https://github.com/drem-darios) * [gs-spadmanabhan](https://github.com/gs-spadmanabhan) * [JurMarky](https://github.com/JurMarky) diff --git a/easy-rules-core/src/main/java/org/jeasy/rules/api/Rules.java b/easy-rules-core/src/main/java/org/jeasy/rules/api/Rules.java index fd23686..6761c3c 100644 --- a/easy-rules-core/src/main/java/org/jeasy/rules/api/Rules.java +++ b/easy-rules-core/src/main/java/org/jeasy/rules/api/Rules.java @@ -120,11 +120,11 @@ public class Rules implements Iterable { } /** - * Check how many rules are currently registered + * Return how many rules are currently registered. * * @return the number of rules currently registered */ - public int rulesCount() { + public int size() { return rules.size(); } diff --git a/easy-rules-core/src/test/java/org/jeasy/rules/api/RulesTest.java b/easy-rules-core/src/test/java/org/jeasy/rules/api/RulesTest.java index d97b10f..0571c0a 100644 --- a/easy-rules-core/src/test/java/org/jeasy/rules/api/RulesTest.java +++ b/easy-rules-core/src/test/java/org/jeasy/rules/api/RulesTest.java @@ -119,14 +119,14 @@ public class RulesTest { } @Test - public void rulesCount() { - assertThat(rules.rulesCount()).isEqualTo(0); + public void size() { + assertThat(rules.size()).isEqualTo(0); rules.register(new DummyRule()); - assertThat(rules.rulesCount()).isEqualTo(1); + assertThat(rules.size()).isEqualTo(1); rules.unregister(new DummyRule()); - assertThat(rules.rulesCount()).isEqualTo(0); + assertThat(rules.size()).isEqualTo(0); } @Test(expected = NullPointerException.class)