From a9390c92175f77419afe44fb9c7a3c905eead973 Mon Sep 17 00:00:00 2001 From: Mahmoud Ben Hassine Date: Sun, 1 Oct 2017 22:06:58 +0200 Subject: [PATCH] use single quote to log values. Double quotes were inherited from JUL log syntax --- .../java/org/jeasy/rules/core/DefaultRuleListener.java | 10 ++++------ .../java/org/jeasy/rules/core/DefaultRulesEngine.java | 4 ++-- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/easy-rules-core/src/main/java/org/jeasy/rules/core/DefaultRuleListener.java b/easy-rules-core/src/main/java/org/jeasy/rules/core/DefaultRuleListener.java index b8df9a8..63dc753 100644 --- a/easy-rules-core/src/main/java/org/jeasy/rules/core/DefaultRuleListener.java +++ b/easy-rules-core/src/main/java/org/jeasy/rules/core/DefaultRuleListener.java @@ -43,9 +43,9 @@ class DefaultRuleListener implements RuleListener { public void afterEvaluate(final Rule rule, final Facts facts, final boolean evaluationResult) { final String ruleName = rule.getName(); if (evaluationResult) { - LOGGER.info("Rule ''{}'' triggered", ruleName); + LOGGER.info("Rule '{}' triggered", ruleName); } else { - LOGGER.info("Rule ''{}'' has been evaluated to false, it has not been executed", ruleName); + LOGGER.info("Rule '{}' has been evaluated to false, it has not been executed", ruleName); } } @@ -56,13 +56,11 @@ class DefaultRuleListener implements RuleListener { @Override public void onSuccess(final Rule rule, final Facts facts) { - LOGGER.info("Rule ''{}'' performed successfully", rule.getName()); + LOGGER.info("Rule '{}' performed successfully", rule.getName()); } @Override public void onFailure(final Rule rule, final Facts facts, final Exception exception) { - if (LOGGER.isInfoEnabled()) { - LOGGER.info("Rule '" + rule.getName() + "' performed with error", exception); - } + LOGGER.info("Rule '" + rule.getName() + "' performed with error", exception); } } diff --git a/easy-rules-core/src/main/java/org/jeasy/rules/core/DefaultRulesEngine.java b/easy-rules-core/src/main/java/org/jeasy/rules/core/DefaultRulesEngine.java index 6f4cd59..8b9dc82 100644 --- a/easy-rules-core/src/main/java/org/jeasy/rules/core/DefaultRulesEngine.java +++ b/easy-rules-core/src/main/java/org/jeasy/rules/core/DefaultRulesEngine.java @@ -127,12 +127,12 @@ public final class DefaultRulesEngine implements RulesEngine { final String name = rule.getName(); final int priority = rule.getPriority(); if (priority > parameters.getPriorityThreshold()) { - LOGGER.info("Rule priority threshold ({}) exceeded at rule ''{}'' with priority={}, next rules will be skipped", + LOGGER.info("Rule priority threshold ({}) exceeded at rule '{}' with priority={}, next rules will be skipped", parameters.getPriorityThreshold(), name, priority); break; } if (!shouldBeEvaluated(rule, facts)) { - LOGGER.info("Rule ''{}'' has been skipped before being evaluated", + LOGGER.info("Rule '{}' has been skipped before being evaluated", name); continue; }