From 6de08b45a9f39bb240b563e72ad58afa93400ee6 Mon Sep 17 00:00:00 2001 From: Mahmoud Ben Hassine Date: Sun, 21 Feb 2021 21:14:07 +0100 Subject: [PATCH] Add tests for null checks in DefaultRulesEngine Refines c994ffb01ac1725a7881caa8dee84f07b72dac70 --- .../rules/core/DefaultRulesEngineTest.java | 22 +++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/easy-rules-core/src/test/java/org/jeasy/rules/core/DefaultRulesEngineTest.java b/easy-rules-core/src/test/java/org/jeasy/rules/core/DefaultRulesEngineTest.java index a314559..4ea4e8c 100644 --- a/easy-rules-core/src/test/java/org/jeasy/rules/core/DefaultRulesEngineTest.java +++ b/easy-rules-core/src/test/java/org/jeasy/rules/core/DefaultRulesEngineTest.java @@ -37,7 +37,9 @@ import org.assertj.core.api.Assertions; import org.jeasy.rules.annotation.Action; import org.jeasy.rules.annotation.Condition; import org.jeasy.rules.annotation.Priority; +import org.jeasy.rules.api.Facts; import org.jeasy.rules.api.RuleListener; +import org.jeasy.rules.api.Rules; import org.jeasy.rules.api.RulesEngineListener; import org.jeasy.rules.api.RulesEngineParameters; import org.junit.After; @@ -64,6 +66,26 @@ public class DefaultRulesEngineTest extends AbstractTest { annotatedRule = new AnnotatedRule(); } + @Test(expected = NullPointerException.class) + public void whenFireRules_thenNullRulesShouldNotBeAccepted() { + rulesEngine.fire(null, new Facts()); + } + + @Test(expected = NullPointerException.class) + public void whenFireRules_thenNullFactsShouldNotBeAccepted() { + rulesEngine.fire(new Rules(), null); + } + + @Test(expected = NullPointerException.class) + public void whenCheckRules_thenNullRulesShouldNotBeAccepted() { + rulesEngine.check(null, new Facts()); + } + + @Test(expected = NullPointerException.class) + public void whenCheckRules_thenNullFactsShouldNotBeAccepted() { + rulesEngine.check(new Rules(), null); + } + @Test public void whenConditionIsTrue_thenActionShouldBeExecuted() throws Exception { // Given