From cbc640203564f13f9f75cb927a358e466c0746f0 Mon Sep 17 00:00:00 2001 From: XenoAmess Date: Thu, 14 Oct 2021 11:09:19 +0800 Subject: [PATCH] use StringBuilder instead of StringBuffer when can (#1980) --- .../src/main/java/com/taobao/arthas/common/ReflectUtils.java | 2 +- core/src/main/java/com/taobao/arthas/core/util/NetUtils.java | 4 ++-- .../main/java/com/taobao/arthas/core/util/StringUtils.java | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/common/src/main/java/com/taobao/arthas/common/ReflectUtils.java b/common/src/main/java/com/taobao/arthas/common/ReflectUtils.java index bb7e3d155..7be111e77 100644 --- a/common/src/main/java/com/taobao/arthas/common/ReflectUtils.java +++ b/common/src/main/java/com/taobao/arthas/common/ReflectUtils.java @@ -212,7 +212,7 @@ public class ReflectUtils { while ((index = className.indexOf("[]", index) + 1) > 0) { dimensions++; } - StringBuffer brackets = new StringBuffer(className.length() - dimensions); + StringBuilder brackets = new StringBuilder(className.length() - dimensions); for (int i = 0; i < dimensions; i++) { brackets.append('['); } diff --git a/core/src/main/java/com/taobao/arthas/core/util/NetUtils.java b/core/src/main/java/com/taobao/arthas/core/util/NetUtils.java index f7be4f7ce..2b59c18b1 100644 --- a/core/src/main/java/com/taobao/arthas/core/util/NetUtils.java +++ b/core/src/main/java/com/taobao/arthas/core/util/NetUtils.java @@ -83,7 +83,7 @@ public class NetUtils { int responseCode = con.getResponseCode(); br = new BufferedReader(new InputStreamReader(con.getInputStream())); - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); String line = null; while ((line = br.readLine()) != null) { sb.append(line); @@ -138,7 +138,7 @@ public class NetUtils { pw.flush(); br = new BufferedReader(new InputStreamReader(s.getInputStream())); - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); String line = null; boolean start = false; while ((line = br.readLine()) != null) { diff --git a/core/src/main/java/com/taobao/arthas/core/util/StringUtils.java b/core/src/main/java/com/taobao/arthas/core/util/StringUtils.java index d18b8d88d..8e80eea8d 100644 --- a/core/src/main/java/com/taobao/arthas/core/util/StringUtils.java +++ b/core/src/main/java/com/taobao/arthas/core/util/StringUtils.java @@ -689,7 +689,7 @@ public abstract class StringUtils { } int arraySize = array.length; int bufSize = (arraySize == 0 ? 0 : (array[0].toString().length() + separator.length()) * arraySize); - StringBuffer buf = new StringBuffer(bufSize); + StringBuilder buf = new StringBuilder(bufSize); for (int i = 0; i < arraySize; i++) { if (i > 0) {