From c73c3d10a1e9a1ac603529927b58a870a2b2e724 Mon Sep 17 00:00:00 2001
From: XenoAmess <xenoamess@gmail.com>
Date: Mon, 18 Oct 2021 17:43:14 +0800
Subject: [PATCH] string concat in StringBuilder append chain (#1984)

---
 boot/src/main/java/com/taobao/arthas/boot/Bootstrap.java      | 4 ++--
 .../java/com/taobao/arthas/core/command/view/TraceView.java   | 4 ++--
 .../com/taobao/arthas/core/command/view/ViewRenderUtil.java   | 2 +-
 .../main/java/com/taobao/arthas/core/util/UserStatUtil.java   | 4 ++--
 .../com/taobao/arthas/core/util/affect/EnhancerAffect.java    | 2 +-
 5 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/boot/src/main/java/com/taobao/arthas/boot/Bootstrap.java b/boot/src/main/java/com/taobao/arthas/boot/Bootstrap.java
index e3685f157..06d2a9b04 100644
--- a/boot/src/main/java/com/taobao/arthas/boot/Bootstrap.java
+++ b/boot/src/main/java/com/taobao/arthas/boot/Bootstrap.java
@@ -694,14 +694,14 @@ public class Bootstrap {
 
         result.append("Local versions:\n");
         for (String version : versionList) {
-            result.append(" " + version).append('\n');
+            result.append(" ").append(version).append('\n');
         }
         result.append("Remote versions:\n");
 
 		List<String> remoteVersions = DownloadUtils.readRemoteVersions();
 		Collections.reverse(remoteVersions);
 		for (String version : remoteVersions) {
-			result.append(" " + version).append('\n');
+			result.append(" ").append(version).append('\n');
 		}
         return result.toString();
     }
diff --git a/core/src/main/java/com/taobao/arthas/core/command/view/TraceView.java b/core/src/main/java/com/taobao/arthas/core/command/view/TraceView.java
index f7e58185d..d30ba0788 100644
--- a/core/src/main/java/com/taobao/arthas/core/command/view/TraceView.java
+++ b/core/src/main/java/com/taobao/arthas/core/command/view/TraceView.java
@@ -98,10 +98,10 @@ public class TraceView extends ResultView<TraceModel> {
 
             //trace_id
             if (threadNode.getTraceId() != null) {
-                sb.append(";trace_id="+threadNode.getTraceId());
+                sb.append(";trace_id=").append(threadNode.getTraceId());
             }
             if (threadNode.getRpcId() != null) {
-                sb.append(";rpc_id="+threadNode.getRpcId());
+                sb.append(";rpc_id=").append(threadNode.getRpcId());
             }
         } else if (node instanceof ThrowNode) {
             ThrowNode throwNode = (ThrowNode) node;
diff --git a/core/src/main/java/com/taobao/arthas/core/command/view/ViewRenderUtil.java b/core/src/main/java/com/taobao/arthas/core/command/view/ViewRenderUtil.java
index a7799c1ac..6980abf0e 100644
--- a/core/src/main/java/com/taobao/arthas/core/command/view/ViewRenderUtil.java
+++ b/core/src/main/java/com/taobao/arthas/core/command/view/ViewRenderUtil.java
@@ -97,7 +97,7 @@ public class ViewRenderUtil {
                 affectVO.getListenerId()));
 
         if (affectVO.getThrowable() != null) {
-            infoSB.append("\nEnhance error! exception: " + affectVO.getThrowable());
+            infoSB.append("\nEnhance error! exception: ").append(affectVO.getThrowable());
         }
         infoSB.append("\n");
 
diff --git a/core/src/main/java/com/taobao/arthas/core/util/UserStatUtil.java b/core/src/main/java/com/taobao/arthas/core/util/UserStatUtil.java
index 683143ddf..cc112d851 100644
--- a/core/src/main/java/com/taobao/arthas/core/util/UserStatUtil.java
+++ b/core/src/main/java/com/taobao/arthas/core/util/UserStatUtil.java
@@ -91,9 +91,9 @@ public class UserStatUtil {
         public void appendQueryData(String key, String value) {
             if (key != null && value != null) {
                 if (queryData.length() == 0) {
-                    queryData.append(key + "=" + value);
+                    queryData.append(key).append("=").append(value);
                 } else {
-                    queryData.append("&" + key + "=" + value);
+                    queryData.append("&").append(key).append("=").append(value);
                 }
             }
         }
diff --git a/core/src/main/java/com/taobao/arthas/core/util/affect/EnhancerAffect.java b/core/src/main/java/com/taobao/arthas/core/util/affect/EnhancerAffect.java
index b0b3b3789..eebf0746d 100644
--- a/core/src/main/java/com/taobao/arthas/core/util/affect/EnhancerAffect.java
+++ b/core/src/main/java/com/taobao/arthas/core/util/affect/EnhancerAffect.java
@@ -144,7 +144,7 @@ public final class EnhancerAffect extends Affect {
                 cost(),
                 listenerId));
         if (this.throwable != null) {
-            infoSB.append("\nEnhance error! exception: " + this.throwable);
+            infoSB.append("\nEnhance error! exception: ").append(this.throwable);
         }
         return infoSB.toString();
     }