From c073b2c77703e7a5c180121fd7dff1e6d3e3b6ed Mon Sep 17 00:00:00 2001 From: gongdewei Date: Tue, 25 May 2021 18:00:44 +0800 Subject: [PATCH] clean inactive request topic --- .../server/message/impl/MessageExchangeServiceImpl.java | 6 +++--- .../arthas/channel/server/web/LegacyApiController.java | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/channel/channel-server/src/main/java/com/alibaba/arthas/channel/server/message/impl/MessageExchangeServiceImpl.java b/channel/channel-server/src/main/java/com/alibaba/arthas/channel/server/message/impl/MessageExchangeServiceImpl.java index 3f47c715a..6259db887 100644 --- a/channel/channel-server/src/main/java/com/alibaba/arthas/channel/server/message/impl/MessageExchangeServiceImpl.java +++ b/channel/channel-server/src/main/java/com/alibaba/arthas/channel/server/message/impl/MessageExchangeServiceImpl.java @@ -215,9 +215,9 @@ public class MessageExchangeServiceImpl implements MessageExchangeService { long now = System.currentTimeMillis(); List topicDataList = new ArrayList<>(topicMap.values()); for (TopicData topicData : topicDataList) { - if (topicData.topic instanceof ActionRequestTopic) { - continue; - } +// if (topicData.topic instanceof ActionRequestTopic) { +// continue; +// } long idle = now - topicData.getLastActiveTime(); if (!topicData.isSubscribed() && idle > timeout) { try { diff --git a/channel/channel-server/src/main/java/com/alibaba/arthas/channel/server/web/LegacyApiController.java b/channel/channel-server/src/main/java/com/alibaba/arthas/channel/server/web/LegacyApiController.java index 3948e3338..50c1bbd6d 100644 --- a/channel/channel-server/src/main/java/com/alibaba/arthas/channel/server/web/LegacyApiController.java +++ b/channel/channel-server/src/main/java/com/alibaba/arthas/channel/server/web/LegacyApiController.java @@ -188,7 +188,7 @@ public class LegacyApiController { long idleTime = currentTimeMillis - entry.getValue().time; boolean outdated = idleTime > topicSurvivalTimeMills; if (outdated) { - logger.info("Removing outdated request data, idle time: {}, sessionId: {}, request: {}", idleTime, entry.getKey(), entry.getValue()); + logger.info("Removing inactive request data, idle time: {}, sessionId: {}, request: {}", idleTime, entry.getKey(), entry.getValue()); } return outdated; });