From 98e645f7bc1d63bc896cd388153de53526ec6807 Mon Sep 17 00:00:00 2001 From: hengyunabc Date: Fri, 5 Jun 2020 16:59:56 +0800 Subject: [PATCH] SpyImpl print error log --- .../taobao/arthas/core/advisor/SpyImpl.java | 24 +++++-------------- 1 file changed, 6 insertions(+), 18 deletions(-) diff --git a/core/src/main/java/com/taobao/arthas/core/advisor/SpyImpl.java b/core/src/main/java/com/taobao/arthas/core/advisor/SpyImpl.java index 41e355e04..607ceb2f8 100644 --- a/core/src/main/java/com/taobao/arthas/core/advisor/SpyImpl.java +++ b/core/src/main/java/com/taobao/arthas/core/advisor/SpyImpl.java @@ -41,9 +41,7 @@ public class SpyImpl extends AbstractSpy { } adviceListener.before(clazz, methodName, methodDesc, target, args); } catch (Throwable e) { - if (logger.isDebugEnabled()) { - logger.error("class: {}, methodInfo: {}", clazz.getName(), methodInfo, e); - } + logger.error("class: {}, methodInfo: {}", clazz.getName(), methodInfo, e); } } } @@ -68,9 +66,7 @@ public class SpyImpl extends AbstractSpy { } adviceListener.afterReturning(clazz, methodName, methodDesc, target, args, returnObject); } catch (Throwable e) { - if (logger.isDebugEnabled()) { - logger.error("class: {}, methodInfo: {}", clazz.getName(), methodInfo, e); - } + logger.error("class: {}, methodInfo: {}", clazz.getName(), methodInfo, e); } } } @@ -94,9 +90,7 @@ public class SpyImpl extends AbstractSpy { } adviceListener.afterThrowing(clazz, methodName, methodDesc, target, args, throwable); } catch (Throwable e) { - if (logger.isDebugEnabled()) { - logger.error("class: {}, methodInfo: {}", clazz.getName(), methodInfo, e); - } + logger.error("class: {}, methodInfo: {}", clazz.getName(), methodInfo, e); } } } @@ -122,9 +116,7 @@ public class SpyImpl extends AbstractSpy { final InvokeTraceable listener = (InvokeTraceable) adviceListener; listener.invokeBeforeTracing(owner, methodName, methodDesc, Integer.parseInt(info[3])); } catch (Throwable e) { - if (logger.isDebugEnabled()) { - logger.error("class: {}, invokeInfo: {}", clazz.getName(), invokeInfo, e); - } + logger.error("class: {}, invokeInfo: {}", clazz.getName(), invokeInfo, e); } } } @@ -149,9 +141,7 @@ public class SpyImpl extends AbstractSpy { final InvokeTraceable listener = (InvokeTraceable) adviceListener; listener.invokeAfterTracing(owner, methodName, methodDesc, Integer.parseInt(info[3])); } catch (Throwable e) { - if (logger.isDebugEnabled()) { - logger.error("class: {}, invokeInfo: {}", clazz.getName(), invokeInfo, e); - } + logger.error("class: {}, invokeInfo: {}", clazz.getName(), invokeInfo, e); } } } @@ -178,9 +168,7 @@ public class SpyImpl extends AbstractSpy { final InvokeTraceable listener = (InvokeTraceable) adviceListener; listener.invokeThrowTracing(owner, methodName, methodDesc, Integer.parseInt(info[3])); } catch (Throwable e) { - if (logger.isDebugEnabled()) { - logger.error("class: {}, invokeInfo: {}", clazz.getName(), invokeInfo, e); - } + logger.error("class: {}, invokeInfo: {}", clazz.getName(), invokeInfo, e); } } }