Commit Graph

52 Commits (78f0201dfafede2ef68a5776ab5f80a6d196d3af)

Author SHA1 Message Date
Bastian Bittorf 2f4b84c074 travis: use only POSIX constructs here, avoid bashisms
e.g. [[ ]] -> [ ] and 'which' -> command -V

Although this is not strictly needed, it keeps the project uniformly POSIX.

Signed-off-by: Bastian Bittorf <bb@npl.de>
Bastian Bittorf 3ca93f4a4c shellcheck: fix several occurences of SC2034
message:
SC2034: $VARNAME appears unused. Verify it or export it.

most of these are related to the style:
we generate global vars, which are used in other functions.

the var "lexical_url" was really unused (left it as comment)

the travis-check now does not need anymore special flags.

Signed-off-by: Bastian Bittorf <bb@npl.de>
Bastian Bittorf 3b67cf4378 dnsapi/dns_dp.sh: shellcheck: fix 1 occurence of SC2126
shellcheck message was:
"Consider using grep -c instead of grep | wc"
Bastian Bittorf 800f02ba38 dnsapi/dns_lexicon.sh: shellcheck: fix 4 occurences of SC2021:
"Don't use [] around ranges in tr, it replaces literal square brackets."

this introduces another warning:
"Use '[:lower:]' to support accents and foreign alphabets."

This is more a style thingy because we really want to only catch A-Z.
work around this by using a shellcheck-directive and a comment
that the [:lower:] will not work with e.g. busybox-ash.

if we later really want to use [:lower:], we should use 'sed' for that.
neilpang 058e5d5f4b LF
neil 8b1fb3cb0c Dev ()
* fix CI

* fix ci

* fix ci
neilpang 74a7592b4b fix ci, remove NGROK_TOKEN_OSX
neilpang df86ff2191 fix ci
neilpang 41266f05e9 fix CI
neilpang d2aa331838 fix ci
neilpang 670cb9d223 fix ci
neilpang a205762bf0 fix ci
neilpang 2ffab66d97 fix ci
neilpang 10a6aec998 fix ci
neil 7cbe31baad fix ci
neil 8a09dc1b9b fix ci
neil fa6e174651 fix ci
neil 8dee328eae fix ci
neil 340155e6a6 fix ci
neil 7fe19a030a fix osx ci
neil 11e0ccdc91 fix ci
neil e55b2f4f8d fix ci
neilpang d78c1f695e fix ci
neilpang cfbb3e86b3 fix ci
neilpang fa6234e417 add NGROK_TOKEN_OSX
neilpang 9eeae9ad7e fix ch
neilpang 28688488ff fix ci
neilpang 41d804719f fix ci
neilpang bc18168662 fix ci
neilpang 1fadae82c7 fix ci
neilpang 791c62ca64 fix ci
neilpang 4441a6ff59 support osx CI
neilpang 5a7b7b51c5 fix ngrok
neilpang fa574fe833 fix shfmt
neilpang 9a6e18ce80 fix shfmt
neilpang 8f9034fc8b fix shfmt
neilpang c947322a69 sudo for travis
neilpang 09f1c58872 test ngrok
neilpang 7f944c2c8b test ngrok
neilpang 1c02b85802 test ngrok
neilpang a2801649b4 test ngrok
neilpang 15777732d3 test ngrok
neilpang b875037150 check NGROK_BIN
neilpang f6ed197cd3 run acmetest in CI
neilpang 87edf71e93 fast_finish: true
neilpang 158a628c0e fix CI
neilpang 5766250288 fix CI
neilpang 870274ad9d fix CI
neilpang 9d6abcd9be fix CI
neilpang 432771dfe3 add shellcheck to CI