Commit Graph

78 Commits (dc5771e679eff69d006e1fbe89b1c3edbbc4c98b)

Author SHA1 Message Date
Brett Wooldridge cd3af22e29 Nitin thinks this is more readable. Not sure I agree, but I don't care enough to argue. 10 years ago
Brett Wooldridge 3d80609d6a Nitin thinks this is more readable. Not sure I agree, but I don't care enough to argue. 10 years ago
Brett Wooldridge 77d6f5084a Issue #213 allow initialization fail fast even when minimumIdle is 0. 10 years ago
Brett Wooldridge 3fc263b5e2 Fix a bug that was introduced in commit fb18eff that would prevent force-close warnings from being logged for connections already flagged for eviction. These warnings should still occur regardless of destined eviction. 10 years ago
Brett Wooldridge cdc171f18a JavaDoc fixes 10 years ago
Brett Wooldridge c9f6d90ab2 Javadoc fixes 10 years ago
Brett Wooldridge 1067111883 JavaDoc fixes 10 years ago
Brett Wooldridge bc42fe797a JavaDoc fixes 10 years ago
Brett Wooldridge 69612f0076 Issue#201 @cowwoc merged toString() changes (largely intact) 10 years ago
Brett Wooldridge fb18eff0c8 Eliminate the isForceClose member, and set bagEntry.evicted instead. We still use
a local isForceClose to avoid a race (where we might fail to log a broken connection).
10 years ago
Brett Wooldridge 7d1f0c72b5 Mainly doc fixup and method reordering. 10 years ago
Brett Wooldridge 590dbf1870 Add some comments. Add evicted check back to housekeeper to cover a rare race condition
where the connection is being released at the same time the maxLifetime eviction shedule is
running.  That could have allowed the bag entry to be marked evicted, but have the check
in releaseConnection() just missing it, which would result in a maxLifetime connection sitting
in the pool for an indefinite amount of time.
10 years ago
Brett Wooldridge 19049c54ad Fix #194 no need to initialize the CodaHaleShim in the JNDI factory 10 years ago
Brett Wooldridge 6772e5f4ca Don't throw sun internal NotImplementedException, just throw a RunTimeException 10 years ago
Brett Wooldridge fafa5050ad Remove maxLifeTime check from getConnection() and use housekeeping scheduler instead. 10 years ago
Brett Wooldridge 44ecfd7f01 Fix #208 little bit cleaner impl of unwrap() and isWrapper() 10 years ago
Brett Wooldridge a4c6c03ded ConcurrentBag to common code refactor (share code between Java 6/7 and Java 8) 10 years ago
Brett Wooldridge 50a4de5fa4 Fix #208 all unwrap when the specified "iface" is actually a HikariDataSource 10 years ago
Brett Wooldridge 7e170daf15 Remove IDE warnings 10 years ago
Brett Wooldridge f7415c7284 Fix #207 remove unneeded test utility class 10 years ago
Brett Wooldridge 62d3f4e9d9 Fix #207 opps, missed a crucial part of the fix... 10 years ago
Brett Wooldridge d47d5a7b0e Fix #207 Make PoolUtilities stateful, because using statics causes issues when two pools with different drivers and different capabilities exist in the same JVM. Pull out non-pooly things into a separate utility class. 10 years ago
Brett Wooldridge f0b735cb02 Issue #206 Use a discard policy rather than an abort policy for the housekeeping thread, the abort policy causes unnecessary looping in addConnection() during shutdown() due to the housekeeping thread being used as the executor for the setNetworkTImeout() call. We could create another executor just for that, but it doesn't really make sense or matter. 10 years ago
Brett Wooldridge 5a90be9199 Make non-overridden methods final. Gets back to pre-refactor performance. 10 years ago
Brett Wooldridge a6152f58a9 Merge more common code. Benchmarks are showing no negative impact so far. 10 years ago
Brett Wooldridge 688d1911e2 Merge more common code. HikariConfig is not a critical class, but we need to be careful about what we merge due to performance implications of inheritance and virtual dispatch that cannot be optimized by the JIT. 10 years ago
Brett Wooldridge 9d486abbfa Massive structure refactor. Make IDE setup hell, but greatly improves maintainability. 10 years ago
Brett Wooldridge 82f98fc57e Project restructuring experiment 10 years ago