Commit Graph

2896 Commits (9f9175195e4509ce206767fa61b72c261efd52a1)
 

Author SHA1 Message Date
Nitin dcd8fdb3a9 final 10 years ago
Brett Wooldridge 476180b0bc Merge pull request #448 from nitincchauhan/dev
using Throwable, better for backport too
10 years ago
Nitin 0218ed14b5 format 10 years ago
Nitin 1daf44b754 using Throwable, better for backport too 10 years ago
Brett Wooldridge b08f693d9c Merge pull request #446 from jack-kerouac/set-login-timeout-unsupported
do not fail if setLoginTimeout on delegate data source is not supported
10 years ago
Florian Rampp 678b2ce139 use multi-catch statement
I was not aware that this feature is available in JDK7 already and the README specifies that JDK7 is required only.
10 years ago
Brett Wooldridge 4e1aaa1802 Prepare for 2.4.2 release candidate. 10 years ago
Florian Rampp 8a7901f292 do not fail if setLoginTimeout on delegate data source is not supported
Some `DataSource` implementations (like [`BasicDataSource`](https://commons.apache.org/proper/commons-dbcp/api-1.4/org/apache/commons/dbcp/BasicDataSource.html) or [`DriverManagerDataSource`](https://docs.spring.io/spring/docs/current/javadoc-api/org/springframework/jdbc/datasource/DriverManagerDataSource.html) do not support setting a login timeout. `UnsupportedOperationException` is thrown in these cases.

When a delegate `dataSource` is set for the HikariCP, it tries to invoke this method on the delegate. Only log a warning in this case instead of failing to initialize the HikariCP in this case.

This is amongst others relevant for using HikariCP in Grails, which creates instances of `org.springframework.jdbc.datasource.DriverManagerDataSource` (at least in version 2.2.4).
10 years ago
Brett Wooldridge c0c6daf93d Fixed #401 log warning when both dataSourceClassName and jdbcUrl are specified. 10 years ago
Brett Wooldridge 23c1b80bfd Tighten bypass window. May tighten further to 250ms later. 10 years ago
Brett Wooldridge efa9726835 Adjust test timeout to try to address travis-ci transient failures. 10 years ago
Brett Wooldridge ea680f7ff5 Merge commit '49be257130ba7bc3080f5bc8a0f191db86f23394' into dev
* commit '49be257130ba7bc3080f5bc8a0f191db86f23394':
  commented log & added changes removed from old commit
  align log with 'Before cleanup'
10 years ago
Nitin 49be257130 commented log & added changes removed from old commit 10 years ago
Brett Wooldridge 716dd345cd Fixed issue with proxy generation 10 years ago
Nitin 0da14c8ce9 align log with 'Before cleanup' 10 years ago
Brett Wooldridge 19e0c5d575 Merge pull request #440 from nitincchauhan/dev
removed old call to close statements
10 years ago
Nitin 1c2f1c13a5 loop is required 10 years ago
Nitin c3482cde10 removed redundant loop, addItem() is actually adding itemS 10 years ago
Nitin f9d493a7d8 checking evict only when required 10 years ago
Nitin 285157c335 removed old call 10 years ago
Brett Wooldridge 5553fe5dcf Merge pull request #438 from nitincchauhan/dev
removed isClosed() check.
10 years ago
Nitin c37a6cb20a removed isClosed(), why trip to check when close() is no-op if already
closed, moreover isClosed() was not guarded by network timeout. mostly
call to close would be once anyway.
10 years ago
Brett Wooldridge 03aad4ea35 minor cleanup 10 years ago
Brett Wooldridge 3c3a14bd3f Merge pull request #437 from nitincchauhan/dev
minor cleanup
10 years ago
Nitin 6137805ab3 minor cleanup 10 years ago
Brett Wooldridge 4ae5c69eae Shorten some tests timeouts to speed-up build. 10 years ago
Brett Wooldridge 410f240c0a Merge branch 'dev' of https://github.com/brettwooldridge/HikariCP into dev 10 years ago
Brett Wooldridge 31447dd1e2 Evict connection immediately upon broken state detection. 10 years ago
Brett Wooldridge 2362af9e14 Update CHANGES 10 years ago
Brett Wooldridge 79386c6487 Fixes #432 improve accuracy of elapsed time calculation to account for time spent in isConnectionAlive() call. 10 years ago
Brett Wooldridge b2cfd09998 Fix timing sensitive test that often fails on travis-ci 10 years ago
Brett Wooldridge c399b46551 Merge branch 'dev' of github.com-brettwooldridge:brettwooldridge/HikariCP into experimental 10 years ago
Brett Wooldridge e125d509fe Cleanup. Former code would remove N elements if PoolEntries were unreservable. Additionally, I'd like to see stats every 30 seconds, as long as idleTimeout is enabled, regardless of idle removable (because connection attrition occurs by other means as well. 10 years ago
Brett Wooldridge d954f46f05 Merge pull request #430 from nitincchauhan/dev
sort before closing idle connections
10 years ago
Nitin a2593599d6 sort before closing idle connections 10 years ago
Brett Wooldridge cb8d1bf775 Merge pull request #428 from nitincchauhan/dev
renamed method/var names, moved toString() to PoolBase, checking for
10 years ago
Nitin 298bf85c36 renamed method/var names, moved toString() to PoolBase, checking for
'readonly' before commit/rollback.
10 years ago
Brett Wooldridge 64ac691c7f Merge pull request #427 from kschmit90/dev
Typo fix
10 years ago
Kyle 11252bd7ad Undo my own typo 10 years ago
Kyle 9fce5de138 Typo 10 years ago
Brett Wooldridge 295ff59ab7 Fixes #425 a low impact change to satisfy an edge-case.
Still, relying on object identities from getResultSet() is an extremely bad idea, regardless of how some drivers seem to implement it.  Relying on that implementation artifact is contrary to the Statement interface documentation, and likely to fail in a variety of environments.  HikariCP itself does not and will not guarantee the future behaviour of this method.
10 years ago
Brett Wooldridge 3bb13c03db More refactors to isolate metrics from internal pool classes 10 years ago
Brett Wooldridge eaa5ca879e More metrics refactor. Isolate poolEntry from metrics package, reinstate no-op class to allow JIT to DCE the code. 10 years ago
Brett Wooldridge e50be62d4f More metrics refactor. Isolate poolEntry from metrics package, reinstate no-op class to allow JIT to DCE the code. 10 years ago
Brett Wooldridge 350a18e74f Merge pull request #423 from nitincchauhan/dev
removed redundant creationTime. lastAceess is initialized at creation as
10 years ago
Nitin cc3f8614af more cleanup 10 years ago
Nitin ff8e54c56f correct time 10 years ago
Nitin eaaf64f93f renamed and removed volatile from lastBorrowed and cleanup 10 years ago
Nitin e3167d40a6 protect pool entry 10 years ago
Brett Wooldridge ca0464d659 Tweaks to investigate Windows infinite loop and/or spurious wakeup. 10 years ago